From: Jonathan Cameron <jic23@kernel.org>
To: Jon Brenner <Jon.Brenner@ams.com>, Sebastian Reichel <sre@debian.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>, Jonathan Cameron <jic23@cam.ac.uk>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bill Pemberton <wfp5p@virginia.edu>,
Sachin Kamat <sachin.kamat@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio:light:tsl2563: Add DT support
Date: Thu, 24 Oct 2013 16:13:02 +0100 [thread overview]
Message-ID: <526938FE.4080309@kernel.org> (raw)
In-Reply-To: <3C879D35B299F147B1DEDFBEE12F2E06012E5631C1@SUX2182.office.amsiag.com>
On 10/24/13 14:58, Jon Brenner wrote:
> AMS-TAOS
amstaos
so lowercase, and based on their being no other hyphenated
names (ST-Ericson is ste for example)
>
> -----Original Message-----
> From: Sebastian Reichel [mailto:sre@debian.org]
> Sent: Thursday, October 24, 2013 8:43 AM
> To: Jonathan Cameron
> Cc: linux-iio@vger.kernel.org; Rob Herring; Pawel Moll; Mark Rutland; Stephen Warren; Ian Campbell; Rob Landley; Jonathan Cameron; Peter Meerwald; Greg Kroah-Hartman; Bill Pemberton; Sachin Kamat; devicetree@vger.kernel.org; linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; Jon Brenner
> Subject: Re: [PATCH] iio:light:tsl2563: Add DT support
>
> On Thu, Oct 24, 2013 at 09:29:42AM +0100, Jonathan Cameron wrote:
>> On 10/23/13 22:51, Sebastian Reichel wrote:
>>> Add Device Tree support for the TSL2563 driver and document the
>>> binding.
>>>
>>> Signed-off-by: Sebastian Reichel <sre@debian.org>
>>> ---
>>> .../devicetree/bindings/iio/light/tsl2563.txt | 19 +++++++++++++++++++
>>> drivers/iio/light/tsl2563.c | 4 ++++
>>> 2 files changed, 23 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/iio/light/tsl2563.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2563.txt
>>> b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
>>> new file mode 100644
>>> index 0000000..b52cf4b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
>>> @@ -0,0 +1,19 @@
>>> +* TAOS TSL2563 ambient light sensor
>>> +
>>> +Required properties:
>>> +
>>> + - compatible : should be "taos,tsl2563"
>>> + - reg : the I2C address of the sensor
>>> +
>>> +Optional properties:
>>> +
>> So two options for this one. Either pitch it as a possible general
>> parameter, or mark it with a vendor prefix. It seems like something
>> fairly general, but in that case it probably needs a more detailed proposal and explanation of exactly what it is.
>
> OK, I will add a vendor prefix in a PATCHv2. When I converted the driver to DT I had a look how this is used and I don't think it's "fairly general".
>
>> Also, is taos listed in vendor-prefixes.txt? Jon, is that the right vendor prefix to use?
>> I'm guessing you have some non mainline bindings out there already so
>> it would be good to match those...
>
> taos is currently not listed in the vendor-prefixes.txt file. Also it seems that "TAOS Inc." has been absorbed by "ams AG" in 2011.
> So how to proceed with the patch?
>
> -- Sebastian
>
next prev parent reply other threads:[~2013-10-24 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 21:51 [PATCH] iio:light:tsl2563: Add DT support Sebastian Reichel
2013-10-24 8:29 ` Jonathan Cameron
2013-10-24 13:43 ` Sebastian Reichel
2013-10-24 13:58 ` Jon Brenner
2013-10-24 15:13 ` Jonathan Cameron [this message]
2013-10-24 14:27 ` [PATCHv2] " Sebastian Reichel
2013-10-25 3:32 ` Kumar Gala
2013-10-25 8:23 ` Sebastian Reichel
2013-10-25 8:37 ` Kumar Gala
2013-10-25 9:10 ` [PATCHv3] " Sebastian Reichel
2013-11-23 11:52 ` Jonathan Cameron
2013-10-25 19:10 ` [PATCH] " Grant Likely
2013-10-25 23:09 ` Sebastian Reichel
2013-11-23 11:50 ` Jonathan Cameron
2013-11-23 12:06 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526938FE.4080309@kernel.org \
--to=jic23@kernel.org \
--cc=Jon.Brenner@ams.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@cam.ac.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sachin.kamat@linaro.org \
--cc=sre@debian.org \
--cc=swarren@wwwdotorg.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).