From: Jonathan Cameron <jic23@kernel.org>
To: Andi Shyti <andi@etezian.org>, Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: Add Freescale MPL3115A2 pressure / temperature sensor driver
Date: Sun, 17 Nov 2013 15:17:40 +0000 [thread overview]
Message-ID: <5288DE14.1040407@kernel.org> (raw)
In-Reply-To: <20131115103716.GA4134@jack.whiskey>
On 11/15/13 10:37, Andi Shyti wrote:
>> I2C-controlled MEMS sensor with 20-bit pressure measurement (pascal) and
>> 12-bit temperature measurement
>>
>> driver only exposes basic functionality, see TODO remarks
>> datasheet: http://cache.freescale.com/files/sensors/doc/data_sheet/MPL3115A2.pdf
>>
>> v2:
>> * store 20-bit value in 32-bit buffer element (instead of 24-bit)
>> * zero buffer to prevent kernel data leak to userspace
>> * fix mutex unlock in trigger handler (thanks Andi Shyti)
>
> You're very welcome :)
>
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Andi Shyti <andi@etezian.org>
>
> Look good to me as well, if you want you can add
>
> Reviewed-by: Andi Shyti <andi@etezian.org>
Of course. Thanks for the review. I am always happy to acknowledge
reviewers as they make life easier!
Applied to the togreg branch of iio.git - note that for now I'm pushing this out
to testing to get build test coverage before pushing to the togreg branch on
kernel.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-11-17 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 19:43 [PATCH v2] iio: Add Freescale MPL3115A2 pressure / temperature sensor driver Peter Meerwald
2013-11-13 23:00 ` Jonathan Cameron
2013-11-15 10:37 ` Andi Shyti
2013-11-17 15:17 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5288DE14.1040407@kernel.org \
--to=jic23@kernel.org \
--cc=andi@etezian.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).