From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-iio@vger.kernel.org
Cc: lars@metafoo.de
Subject: Re: [PATCH Resend 00/33] iio: Implement and use devm_iio_device_register
Date: Sat, 23 Nov 2013 18:43:09 +0000 [thread overview]
Message-ID: <5290F73D.1000306@kernel.org> (raw)
In-Reply-To: <1383046796-329-1-git-send-email-sachin.kamat@linaro.org>
On 10/29/13 11:39, Sachin Kamat wrote:
> Resending this series after rebasing onto the latest iio tree.
> Previous version is available at [1].
> [1] http://www.spinics.net/lists/linux-iio/msg10682.html
>
> * Added tested and reviewed by tags to patch 1. Thank you Lars.
> * Included a patch (patch2) to re-organise the kernel doc
> as suggested by Lars.
Hi Sachin,
Having finaly waded through this whole set I have a few general comments.
Firstly, I am sorry I am refusing to take so many of these. I did mention
in response to an earlier series that I was not keen on applying this
shortening in code, if there was stuff that should be done after the
unregister, but which was not.
I have kept to that as I would much rather see those drivers improved by
adding for example power down of the part on removal of the driver or making
sure that the removal is in the correct order. Feel free to try and
talk me around though!
Anyhow, thanks for your hard work on this.
Note that if anyone wants to take a look at the reasons I have refused to
take the individual patches, they may well highlight places I feel the
individual drivers could be easily improved.
Thanks,
Jonathan
>
> Sachin Kamat (33):
> iio: core: Implement devm_iio_device_{register,unregister}
> iio: core: Move kernel doc to the right location
> iio: accel: kxsd9: Use devm_iio_device_register
> iio: adc: mcp3422: Use devm_iio_device_register
> iio: adc: twl6030-gpadc: Use devm_iio_device_register
> iio: adc: viperboard: Use devm_iio_device_register
> iio: dac: ad5421: Use devm_iio_device_register
> iio: dac: ad5755: Use devm_iio_device_register
> iio: dac: max517: Use devm_iio_device_register
> iio: dac: mcp4725: Use devm_iio_device_register
> iio: gyro: adis16130: Use devm_iio_device_register
> iio: gyro: adxrs450: Use devm_iio_device_register
> iio: light: vcnl4000: Use devm_iio_device_register
> staging: iio: adis16220: Use devm_iio_device_register
> staging: iio: ad7816: Use devm_iio_device_register
> staging: iio: lpc32xx_adc: Use devm_iio_device_register
> staging: iio: addac: Use devm_iio_device_register
> staging: iio: ad7150: Use devm_iio_device_register
> staging: iio: ad7746: Use devm_iio_device_register
> staging: iio: ad5930: Use devm_iio_device_register
> staging: iio: ad9850: Use devm_iio_device_register
> staging: iio: ad9852: Use devm_iio_device_register
> staging: iio: ad9910: Use devm_iio_device_register
> staging: iio: ad9951: Use devm_iio_device_register
> staging: iio: adis16060: Use devm_iio_device_register
> staging: iio: isl29018: Use devm_iio_device_register
> staging: iio: isl29028: Use devm_iio_device_register
> staging: iio: tsl2583: Use devm_iio_device_register
> staging: iio: tsl2x7x_core: Use devm_iio_device_register
> staging: iio: ade7854: Use devm_iio_device_register
> staging: iio: ad2s1200: Use devm_iio_device_register
> staging: iio: ad2s90: Use devm_iio_device_register
> staging: iio: ad7152: Use devm_iio_device_register
>
> Documentation/driver-model/devres.txt | 2 +
> drivers/iio/accel/kxsd9.c | 10 +--
> drivers/iio/adc/mcp3422.c | 9 +--
> drivers/iio/adc/twl6030-gpadc.c | 5 +-
> drivers/iio/adc/viperboard_adc.c | 12 +---
> drivers/iio/dac/ad5421.c | 12 +---
> drivers/iio/dac/ad5755.c | 12 +---
> drivers/iio/dac/max517.c | 9 +--
> drivers/iio/dac/mcp4725.c | 9 +--
> drivers/iio/gyro/adis16130.c | 9 +--
> drivers/iio/gyro/adxrs450.c | 14 +---
> drivers/iio/industrialio-core.c | 101 ++++++++++++++++++++++++++++
> drivers/iio/industrialio-event.c | 6 ++
> drivers/iio/industrialio-trigger.c | 24 +++++++
> drivers/iio/light/vcnl4000.c | 9 +--
> drivers/staging/iio/accel/adis16220_core.c | 7 +-
> drivers/staging/iio/adc/ad7816.c | 12 +---
> drivers/staging/iio/adc/lpc32xx_adc.c | 12 +---
> drivers/staging/iio/addac/adt7316-i2c.c | 6 --
> drivers/staging/iio/addac/adt7316-spi.c | 6 --
> drivers/staging/iio/addac/adt7316.c | 12 +---
> drivers/staging/iio/addac/adt7316.h | 1 -
> drivers/staging/iio/cdc/ad7150.c | 12 +---
> drivers/staging/iio/cdc/ad7152.c | 12 +---
> drivers/staging/iio/cdc/ad7746.c | 12 +---
> drivers/staging/iio/frequency/ad5930.c | 10 +--
> drivers/staging/iio/frequency/ad9850.c | 10 +--
> drivers/staging/iio/frequency/ad9852.c | 10 +--
> drivers/staging/iio/frequency/ad9910.c | 10 +--
> drivers/staging/iio/frequency/ad9951.c | 10 +--
> drivers/staging/iio/gyro/adis16060_core.c | 10 +--
> drivers/staging/iio/light/isl29018.c | 13 +---
> drivers/staging/iio/light/isl29028.c | 11 +--
> drivers/staging/iio/light/tsl2583.c | 10 +--
> drivers/staging/iio/light/tsl2x7x_core.c | 4 +-
> drivers/staging/iio/meter/ade7854-i2c.c | 6 --
> drivers/staging/iio/meter/ade7854-spi.c | 7 --
> drivers/staging/iio/meter/ade7854.c | 14 +---
> drivers/staging/iio/meter/ade7854.h | 1 -
> drivers/staging/iio/resolver/ad2s1200.c | 10 +--
> drivers/staging/iio/resolver/ad2s90.c | 10 +--
> include/linux/iio/iio.h | 81 +---------------------
> 42 files changed, 168 insertions(+), 394 deletions(-)
>
next prev parent reply other threads:[~2013-11-23 17:42 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 11:39 [PATCH Resend 00/33] iio: Implement and use devm_iio_device_register Sachin Kamat
2013-10-29 11:39 ` [PATCH 01/33] iio: core: Implement devm_iio_device_{register,unregister} Sachin Kamat
2013-11-09 17:44 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 02/33] iio: core: Move kernel doc to the right location Sachin Kamat
2013-11-09 17:45 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 03/33] iio: accel: kxsd9: Use devm_iio_device_register Sachin Kamat
2013-11-09 17:47 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 04/33] iio: adc: mcp3422: " Sachin Kamat
2013-11-09 17:54 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 05/33] iio: adc: twl6030-gpadc: " Sachin Kamat
2013-11-23 13:26 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 06/33] iio: adc: viperboard: " Sachin Kamat
2013-11-23 13:31 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 07/33] iio: dac: ad5421: " Sachin Kamat
2013-11-23 13:34 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 08/33] iio: dac: ad5755: " Sachin Kamat
2013-11-23 13:35 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 09/33] iio: dac: max517: " Sachin Kamat
2013-11-23 13:37 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 10/33] iio: dac: mcp4725: " Sachin Kamat
2013-11-23 13:39 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 11/33] iio: gyro: adis16130: " Sachin Kamat
2013-11-23 13:43 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 12/33] iio: gyro: adxrs450: " Sachin Kamat
2013-11-23 13:45 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 13/33] iio: light: vcnl4000: " Sachin Kamat
2013-11-23 13:48 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 14/33] staging: iio: adis16220: " Sachin Kamat
2013-11-23 18:01 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 15/33] staging: iio: ad7816: " Sachin Kamat
2013-11-23 18:04 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 16/33] staging: iio: lpc32xx_adc: " Sachin Kamat
2013-11-23 18:06 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 17/33] staging: iio: addac: " Sachin Kamat
2013-11-23 18:08 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 18/33] staging: iio: ad7150: " Sachin Kamat
2013-11-23 18:10 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 19/33] staging: iio: ad7746: " Sachin Kamat
2013-11-23 18:12 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 20/33] staging: iio: ad5930: " Sachin Kamat
2013-11-23 18:14 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 21/33] staging: iio: ad9850: " Sachin Kamat
2013-11-23 18:15 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 22/33] staging: iio: ad9852: " Sachin Kamat
2013-11-23 18:17 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 23/33] staging: iio: ad9910: " Sachin Kamat
2013-11-23 18:18 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 24/33] staging: iio: ad9951: " Sachin Kamat
2013-11-23 18:19 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 25/33] staging: iio: adis16060: " Sachin Kamat
2013-11-23 18:22 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 26/33] staging: iio: isl29018: " Sachin Kamat
2013-11-23 18:24 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 27/33] staging: iio: isl29028: " Sachin Kamat
2013-11-23 18:28 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 28/33] staging: iio: tsl2583: " Sachin Kamat
2013-11-23 18:30 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 29/33] staging: iio: tsl2x7x_core: " Sachin Kamat
2013-11-23 18:31 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 30/33] staging: iio: ade7854: " Sachin Kamat
2013-11-23 18:33 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 31/33] staging: iio: ad2s1200: " Sachin Kamat
2013-11-23 18:36 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 32/33] staging: iio: ad2s90: " Sachin Kamat
2013-11-23 18:37 ` Jonathan Cameron
2013-10-29 11:39 ` [PATCH 33/33] staging: iio: ad7152: " Sachin Kamat
2013-11-23 18:39 ` Jonathan Cameron
2013-10-29 13:11 ` [PATCH Resend 00/33] iio: Implement and use devm_iio_device_register Jonathan Cameron
2013-10-30 8:31 ` Sachin Kamat
2013-10-30 17:12 ` Jonathan Cameron
2013-11-23 18:43 ` Jonathan Cameron [this message]
2013-11-27 4:40 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5290F73D.1000306@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).