From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Fugang Duan <B38611@freescale.com>,
jic23@kernel.org, shawn.guo@linaro.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver
Date: Tue, 26 Nov 2013 13:49:11 +0100 [thread overview]
Message-ID: <529498C7.80408@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.01.1311261302560.18875@pmeerw.net>
On 11/26/2013 01:24 PM, Peter Meerwald wrote:
>> +static inline void vf610_adc_cfg_set(struct vf610_adc *info)
>> +{
>
> why are some functions marked inline and others not?
> this function does not seem time critical
And the compiler knows much better which functions to (partially) inline and
which not, I think inline is mostly ignored by the compiler anyway, so yes,
it should be removed here.
>> +static int vf610_adc_reg_access(struct iio_dev *indio_dev,
>> + unsigned reg, unsigned writeval,
>> + unsigned *readval)
>> +{
>> + struct vf610_adc *info = iio_priv(indio_dev);
>> +
>> + if (readval == NULL)
>> + return -EINVAL;
>
> can this ever happen?
>
> I'd rather check the value of reg
It is NULL when writing to a register.
next prev parent reply other threads:[~2013-11-26 12:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 10:56 [PATCH v3 0/3] *** iio:adc:imx: Add Freescale vf610 ADC driver support *** Fugang Duan
2013-11-26 10:56 ` [PATCH v3 1/3] ARM: dts: vf610-twr: Add ADC support Fugang Duan
2013-11-26 10:56 ` [PATCH v3 2/3] iio:adc:imx: add Freescale Vybrid vf610 adc driver Fugang Duan
2013-11-26 11:51 ` Lars-Peter Clausen
2013-11-27 4:44 ` Fugang Duan
2013-11-27 8:20 ` Lars-Peter Clausen
2013-11-27 8:31 ` Fugang Duan
2013-11-26 12:24 ` Peter Meerwald
2013-11-26 12:49 ` Lars-Peter Clausen [this message]
2013-11-27 2:57 ` Fugang Duan
2013-11-27 7:17 ` Peter Meerwald
2013-11-27 7:30 ` Fugang Duan
2013-11-26 14:25 ` Mark Rutland
2013-11-27 5:37 ` Fugang Duan
2013-11-27 14:18 ` Mark Rutland
2013-11-28 1:25 ` Fugang Duan
2013-11-26 10:56 ` [PATCH v3 3/3] Documentation: add the binding file for Freescale vf610 ADC driver Fugang Duan
2013-11-26 13:37 ` Shawn Guo
2013-11-27 1:38 ` Fugang Duan
2013-11-26 14:09 ` Mark Rutland
2013-11-27 6:05 ` Fugang Duan
2013-11-27 8:09 ` Jonathan Cameron
2013-11-27 8:55 ` Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529498C7.80408@metafoo.de \
--to=lars@metafoo.de \
--cc=B38611@freescale.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).