From: Jonathan Cameron <jic23@kernel.org>
To: Axel Lin <axel.lin@ingics.com>, Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:trigger: Convert to use ATTRIBUTE_GROUPS
Date: Mon, 02 Dec 2013 22:08:24 +0000 [thread overview]
Message-ID: <529D04D8.5050600@kernel.org> (raw)
In-Reply-To: <1385953044.30717.5.camel@phoenix>
On 12/02/13 02:57, Axel Lin wrote:
> Use new ATTRIBUTE_GROUPS macro to declare attribute groups.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied to the testing (and soon togreg) branch of iio.git
Thanks
> ---
> drivers/iio/industrialio-trigger.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 7ba2f00..766fab2 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -55,15 +55,7 @@ static struct attribute *iio_trig_dev_attrs[] = {
> &dev_attr_name.attr,
> NULL,
> };
> -
> -static struct attribute_group iio_trig_attr_group = {
> - .attrs = iio_trig_dev_attrs,
> -};
> -
> -static const struct attribute_group *iio_trig_attr_groups[] = {
> - &iio_trig_attr_group,
> - NULL
> -};
> +ATTRIBUTE_GROUPS(iio_trig_dev);
>
> int iio_trigger_register(struct iio_trigger *trig_info)
> {
> @@ -403,7 +395,7 @@ static void iio_trig_release(struct device *device)
>
> static struct device_type iio_trig_type = {
> .release = iio_trig_release,
> - .groups = iio_trig_attr_groups,
> + .groups = iio_trig_dev_groups,
> };
>
> static void iio_trig_subirqmask(struct irq_data *d)
>
prev parent reply other threads:[~2013-12-02 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 2:57 [PATCH] iio:trigger: Convert to use ATTRIBUTE_GROUPS Axel Lin
2013-12-02 22:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D04D8.5050600@kernel.org \
--to=jic23@kernel.org \
--cc=axel.lin@ingics.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).