From: Jonathan Cameron <jic23@kernel.org>
To: Beomho Seo <beomho.seo@samsung.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: cm36651: Changed return value of read function
Date: Sat, 14 Dec 2013 11:17:27 +0000 [thread overview]
Message-ID: <52AC3E47.4010007@kernel.org> (raw)
In-Reply-To: <52A5284D.4080906@samsung.com>
On 12/09/13 02:17, Beomho Seo wrote:
> Hello,
>
> I have fixed cm36651 driver.
> Some return value of callback have been changed to IIO_VAL_INT.
> If not IIO_VAL_INT, driver will print wrong value(*_read_int_time) or not print(*_read_prox_thresh).
>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
Applied to the fixes-togreg branch of iio.git
This is going to cause a merge conflict with the reworking of the event
handling in the togreg branch, but the solution is simple so shouldn't
cause any problems (hopefully I'll remember to metion it when I send
the pull requests!)
> ---
> drivers/iio/light/cm36651.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
> index 21df571..0206eab 100644
> --- a/drivers/iio/light/cm36651.c
> +++ b/drivers/iio/light/cm36651.c
> @@ -387,7 +387,7 @@ static int cm36651_read_int_time(struct cm36651_data *cm36651,
> return -EINVAL;
> }
>
> - return IIO_VAL_INT_PLUS_MICRO;
> + return IIO_VAL_INT;
> }
>
> static int cm36651_write_int_time(struct cm36651_data *cm36651,
> @@ -494,7 +494,7 @@ static int cm36651_read_prox_thresh(struct iio_dev *indio_dev,
>
> *val = cm36651->ps_ctrl_regs[CM36651_PS_THD];
>
> - return 0;
> + return IIO_VAL_INT;
> }
>
> static int cm36651_write_prox_thresh(struct iio_dev *indio_dev,
>
next prev parent reply other threads:[~2013-12-14 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 2:17 [PATCH] iio: cm36651: Changed return value of read function Beomho Seo
2013-12-14 11:17 ` Jonathan Cameron [this message]
2013-12-15 13:04 ` Lars-Peter Clausen
2013-12-15 21:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AC3E47.4010007@kernel.org \
--to=jic23@kernel.org \
--cc=beomho.seo@samsung.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).