From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, pmeerw@pmeerw.net,
o.v.kravchenko@globallogic.com, stigge@antcom.de
Subject: Re: [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements.
Date: Mon, 16 Dec 2013 09:55:53 +0100 [thread overview]
Message-ID: <52AEC019.1020002@metafoo.de> (raw)
In-Reply-To: <1386787542-19666-1-git-send-email-jic23@kernel.org>
On 12/11/2013 07:45 PM, Jonathan Cameron wrote:
> This macro is no longer fit for purpose given it doesn't allow the endianness
> of the element to be set. Missuse of the macro has also been responsible for
> a couple of bugs including some fixed in this series.
>
> If everyone is happy I'll be apply the fixes through the fixes-togreg branch
> and follow up with the others after those have worked their way through.
>
> Please do check the fixes in particular as I'm not entirely sure they are
> correct (particularly the ad7887 which gave me a headache on a train last
> night at the end of a very long day).
>
Looks all good to me, except for the ad799x.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
One minor nitpick though. I think the proper indention is
{
.foo = bar,
}
instead of
{
.foo = bar,
}
- Lars
> Thanks,
>
> Jonathan
>
> Jonathan Cameron (24):
> staging:iio:mag:hmc5843 fix incorrect endianness of channel as a
> result of missuse of the IIO_ST macro.
> iio:imu:adis16400 fix pressure channel scan type
> iio:adc:ad7887 Fix channel reported endianness from cpu to big endian
> iio:accel:bma180 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:mag:mag3110 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5064 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5360 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5380 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5421 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5446 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5449 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5504 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5624r replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5686 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5755 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5764 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:ad5791 replaces IIO_ST macro with explicit entries to struct
> scan_type
> iio:dac:max517 drop specification of scan type as unused in this
> driver.
> iio:dac:mcp4725 drop specification of scan type as unused in this
> driver.
> iio:light:adjd_s311 replaces IIO_ST macro with explicit entries to
> struct scan_type
> iio:light:tcs3472 replaces IIO_ST macro with explicit entries to
> struct scan_type
> staging:iio:ad7606 replaces IIO_ST macro with explicit entries to
> struct scan_type
> staging:iio:ad799x replaces IIO_ST macro with explicit entries to
> struct scan_type
> iio:drop IIO_ST macro
>
> drivers/iio/accel/bma180.c | 7 ++++++-
> drivers/iio/adc/ad7887.c | 16 ++++++++++++++--
> drivers/iio/dac/ad5064.c | 7 ++++++-
> drivers/iio/dac/ad5360.c | 7 ++++++-
> drivers/iio/dac/ad5380.c | 7 ++++++-
> drivers/iio/dac/ad5421.c | 6 +++++-
> drivers/iio/dac/ad5446.c | 9 +++++++--
> drivers/iio/dac/ad5449.c | 7 ++++++-
> drivers/iio/dac/ad5504.c | 6 +++++-
> drivers/iio/dac/ad5624r_spi.c | 7 ++++++-
> drivers/iio/dac/ad5686.c | 9 +++++++--
> drivers/iio/dac/ad5755.c | 7 ++++++-
> drivers/iio/dac/ad5764.c | 7 ++++++-
> drivers/iio/dac/ad5791.c | 9 +++++++--
> drivers/iio/dac/max517.c | 1 -
> drivers/iio/dac/mcp4725.c | 1 -
> drivers/iio/imu/adis16400_core.c | 7 ++++++-
> drivers/iio/light/adjd_s311.c | 7 ++++++-
> drivers/iio/light/tcs3472.c | 7 ++++++-
> drivers/iio/magnetometer/mag3110.c | 6 +++++-
> drivers/staging/iio/adc/ad7606_core.c | 7 ++++++-
> drivers/staging/iio/adc/ad799x_core.c | 8 +++++++-
> drivers/staging/iio/magnetometer/hmc5843.c | 7 ++++++-
> include/linux/iio/iio.h | 16 ++++++++++------
> 24 files changed, 145 insertions(+), 33 deletions(-)
>
next prev parent reply other threads:[~2013-12-16 8:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 18:45 [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Jonathan Cameron
2013-12-11 18:45 ` [PATCH 01/24] staging:iio:mag:hmc5843 fix incorrect endianness of channel as a result of missuse of the IIO_ST macro Jonathan Cameron
2013-12-17 20:35 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 02/24] iio:imu:adis16400 fix pressure channel scan type Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 03/24] iio:adc:ad7887 Fix channel reported endianness from cpu to big endian Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 04/24] iio:accel:bma180 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 05/24] iio:mag:mag3110 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 06/24] iio:dac:ad5064 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 07/24] iio:dac:ad5360 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 08/24] iio:dac:ad5380 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 09/24] iio:dac:ad5421 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 10/24] iio:dac:ad5446 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 11/24] iio:dac:ad5449 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 12/24] iio:dac:ad5504 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 13/24] iio:dac:ad5624r " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 14/24] iio:dac:ad5686 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 15/24] iio:dac:ad5755 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 16/24] iio:dac:ad5764 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 17/24] iio:dac:ad5791 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 18/24] iio:dac:max517 drop specification of scan type as unused in this driver Jonathan Cameron
2013-12-11 18:45 ` [PATCH 19/24] iio:dac:mcp4725 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 20/24] iio:light:adjd_s311 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 21/24] iio:light:tcs3472 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 22/24] staging:iio:ad7606 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 23/24] staging:iio:ad799x " Jonathan Cameron
2013-12-16 8:53 ` Lars-Peter Clausen
2013-12-17 20:29 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 24/24] iio:drop IIO_ST macro Jonathan Cameron
2014-02-15 10:58 ` Jonathan Cameron
2013-12-16 8:55 ` Lars-Peter Clausen [this message]
2013-12-17 21:53 ` [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AEC019.1020002@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
--cc=pmeerw@pmeerw.net \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).