From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, pmeerw@pmeerw.net,
o.v.kravchenko@globallogic.com, stigge@antcom.de
Subject: Re: [PATCH 23/24] staging:iio:ad799x replaces IIO_ST macro with explicit entries to struct scan_type
Date: Tue, 17 Dec 2013 20:29:29 +0000 [thread overview]
Message-ID: <52B0B429.8020109@kernel.org> (raw)
In-Reply-To: <52AEBF77.1000800@metafoo.de>
On 12/16/13 08:53, Lars-Peter Clausen wrote:
> On 12/11/2013 07:45 PM, Jonathan Cameron wrote:
>> IIO_ST is going away as it is a pain to maintain. As an i2c driver, multi byte
>> words will be read by the driver in the native cpu endianness.
>
> Are you sure about this? As far as I understand it the I2C message will be
> read byte by byte. The device sends the MSB first, so I think it should be
> IIO_BE.
Gah. I just spent 5 minutes writing an essay on the fact it was an smbus
word read call, only to realise I was looking at the wrong function and
this is done with a block read. Doh. You are quite right! I'll
switch this one to IIO_BE.
>
>>
>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>> drivers/staging/iio/adc/ad799x_core.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
>> index 5ea36410f716..45e64d8bf29b 100644
>> --- a/drivers/staging/iio/adc/ad799x_core.c
>> +++ b/drivers/staging/iio/adc/ad799x_core.c
>> @@ -409,7 +409,13 @@ static const struct iio_event_spec ad799x_events[] = {
>> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
>> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
>> .scan_index = (_index), \
>> - .scan_type = IIO_ST('u', _realbits, 16, 12 - (_realbits)), \
>> + .scan_type = { \
>> + .sign = 'u', \
>> + .realbits = (_realbits), \
>> + .storagebits = 16, \
>> + .shift = 12 - (_realbits), \
>> + .endianness = IIO_CPU, \
>> + }, \
>> .event_spec = _ev_spec, \
>> .num_event_specs = _num_ev_spec, \
>> }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-12-17 20:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 18:45 [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Jonathan Cameron
2013-12-11 18:45 ` [PATCH 01/24] staging:iio:mag:hmc5843 fix incorrect endianness of channel as a result of missuse of the IIO_ST macro Jonathan Cameron
2013-12-17 20:35 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 02/24] iio:imu:adis16400 fix pressure channel scan type Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 03/24] iio:adc:ad7887 Fix channel reported endianness from cpu to big endian Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 04/24] iio:accel:bma180 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 05/24] iio:mag:mag3110 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 06/24] iio:dac:ad5064 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 07/24] iio:dac:ad5360 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 08/24] iio:dac:ad5380 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 09/24] iio:dac:ad5421 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 10/24] iio:dac:ad5446 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 11/24] iio:dac:ad5449 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 12/24] iio:dac:ad5504 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 13/24] iio:dac:ad5624r " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 14/24] iio:dac:ad5686 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 15/24] iio:dac:ad5755 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 16/24] iio:dac:ad5764 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 17/24] iio:dac:ad5791 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 18/24] iio:dac:max517 drop specification of scan type as unused in this driver Jonathan Cameron
2013-12-11 18:45 ` [PATCH 19/24] iio:dac:mcp4725 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 20/24] iio:light:adjd_s311 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 21/24] iio:light:tcs3472 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 22/24] staging:iio:ad7606 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 23/24] staging:iio:ad799x " Jonathan Cameron
2013-12-16 8:53 ` Lars-Peter Clausen
2013-12-17 20:29 ` Jonathan Cameron [this message]
2013-12-11 18:45 ` [PATCH 24/24] iio:drop IIO_ST macro Jonathan Cameron
2014-02-15 10:58 ` Jonathan Cameron
2013-12-16 8:55 ` [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Lars-Peter Clausen
2013-12-17 21:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B0B429.8020109@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
--cc=pmeerw@pmeerw.net \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).