From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: lars@metafoo.de, pmeerw@pmeerw.net,
o.v.kravchenko@globallogic.com, stigge@antcom.de,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 02/24] iio:imu:adis16400 fix pressure channel scan type
Date: Tue, 17 Dec 2013 20:38:16 +0000 [thread overview]
Message-ID: <52B0B638.7060004@kernel.org> (raw)
In-Reply-To: <1386787542-19666-3-git-send-email-jic23@kernel.org>
On 12/11/13 18:45, Jonathan Cameron wrote:
> A single channel in this driver was using the IIO_ST macro.
> This does not provide a parameter for setting the endianness of
> the channel. Thus this channel will have been reported as whatever
> is the native endianness of the cpu rather than big endian. This
> means it would be incorrect on little endian platforms.
>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Applied to the fixes-togreg branch of iio.git
> ---
> drivers/iio/imu/adis16400_core.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
> index 3fb7757a1028..368660dfe135 100644
> --- a/drivers/iio/imu/adis16400_core.c
> +++ b/drivers/iio/imu/adis16400_core.c
> @@ -651,7 +651,12 @@ static const struct iio_chan_spec adis16448_channels[] = {
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),
> .address = ADIS16448_BARO_OUT,
> .scan_index = ADIS16400_SCAN_BARO,
> - .scan_type = IIO_ST('s', 16, 16, 0),
> + .scan_type = {
> + .sign = 's',
> + .realbits = 16,
> + .storagebits = 16,
> + .endianness = IIO_BE,
> + },
> },
> ADIS16400_TEMP_CHAN(ADIS16448_TEMP_OUT, 12),
> IIO_CHAN_SOFT_TIMESTAMP(11)
>
next prev parent reply other threads:[~2013-12-17 20:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 18:45 [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Jonathan Cameron
2013-12-11 18:45 ` [PATCH 01/24] staging:iio:mag:hmc5843 fix incorrect endianness of channel as a result of missuse of the IIO_ST macro Jonathan Cameron
2013-12-17 20:35 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 02/24] iio:imu:adis16400 fix pressure channel scan type Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron [this message]
2013-12-11 18:45 ` [PATCH 03/24] iio:adc:ad7887 Fix channel reported endianness from cpu to big endian Jonathan Cameron
2013-12-17 20:38 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 04/24] iio:accel:bma180 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 05/24] iio:mag:mag3110 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 06/24] iio:dac:ad5064 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 07/24] iio:dac:ad5360 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 08/24] iio:dac:ad5380 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 09/24] iio:dac:ad5421 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 10/24] iio:dac:ad5446 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 11/24] iio:dac:ad5449 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 12/24] iio:dac:ad5504 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 13/24] iio:dac:ad5624r " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 14/24] iio:dac:ad5686 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 15/24] iio:dac:ad5755 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 16/24] iio:dac:ad5764 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 17/24] iio:dac:ad5791 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 18/24] iio:dac:max517 drop specification of scan type as unused in this driver Jonathan Cameron
2013-12-11 18:45 ` [PATCH 19/24] iio:dac:mcp4725 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 20/24] iio:light:adjd_s311 replaces IIO_ST macro with explicit entries to struct scan_type Jonathan Cameron
2013-12-11 18:45 ` [PATCH 21/24] iio:light:tcs3472 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 22/24] staging:iio:ad7606 " Jonathan Cameron
2013-12-11 18:45 ` [PATCH 23/24] staging:iio:ad799x " Jonathan Cameron
2013-12-16 8:53 ` Lars-Peter Clausen
2013-12-17 20:29 ` Jonathan Cameron
2013-12-11 18:45 ` [PATCH 24/24] iio:drop IIO_ST macro Jonathan Cameron
2014-02-15 10:58 ` Jonathan Cameron
2013-12-16 8:55 ` [PATCH 00/24] Drop the IIO_ST macro for setting scan_type elements Lars-Peter Clausen
2013-12-17 21:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B0B638.7060004@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
--cc=pmeerw@pmeerw.net \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).