From: Jonathan <jic23@kernel.org>
To: Kevin Tsai <ktsai@capellamicro.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Teddy Reed <teddy@prosauce.org>,
Kent Yoder <key@linux.vnet.ibm.com>,
Arnaud Ebalard <arno@natisbad.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH V4 1/1] iio: add Capella CM32181 ambient light sensor driver.
Date: Wed, 01 Jan 2014 12:05:54 +0000 [thread overview]
Message-ID: <52C404A2.9030106@kernel.org> (raw)
In-Reply-To: <1387850035-4030-1-git-send-email-ktsai@capellamicro.com>
On 24/12/13 01:53, Kevin Tsai wrote:
> Add Capella Microsystem CM32181 Ambient Light Sensor IIO driver.
> This driver will convert raw data to lux value under open-air
> condition. Change the calibscale based on the cover material.
>
> Signed-off-by: Kevin Tsai <ktsai@capellamicro.com>
> ---
Hi Kevin,
It is good practice to list here (nothing from here goes in final commit
message) any changes since the previous version. This just makes it clear
whether you have responded to all review comments, particularly when there
are multiple people reviewing the patch.
Other than that, I'm happy with this and have applied it to the togreg
branch of iio.git - initially pushed out as testing for build tests.
Note I made one tiny white space change (dropped a blank line where
there were two...
prev parent reply other threads:[~2014-01-01 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 1:53 [PATCH V4 1/1] iio: add Capella CM32181 ambient light sensor driver Kevin Tsai
2014-01-01 12:05 ` Jonathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C404A2.9030106@kernel.org \
--to=jic23@kernel.org \
--cc=arno@natisbad.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=key@linux.vnet.ibm.com \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=o.v.kravchenko@globallogic.com \
--cc=pawel.moll@arm.com \
--cc=peterhuewe@gmx.de \
--cc=pmeerw@pmeerw.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=teddy@prosauce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).