[PATCH 0/6] some staging:iio:access:sca3000 cleanup

[PATCH 0/6] some staging:iio:access:sca3000 cleanup

[Peter Meerwald]

Hi,

sca3000 seems to be broken, esp. for the chip variant that supports
temperature (no event_attribute_group, no channels at all registered, 
this variant seem to be ... not popular :)

this series cleans kerneldoc and comments (patches 1, 2), adds the 
event_attribute_group for the temp_output case (patch 3), registers channels
for the temp_output case (patch 4), uses IIO_TEMP instead of DEV_ATTR_TEMP
(patch 5), and cleans sca3000.h

I'm not sure if it is worth cleaning up this old sensor
driver, but still...

my motivation was to get rid of DEV_ATTR_TEMP which is only used in staging by
accel/sca3000 and meter/ade7* and superceeded (?) by IIO_TEMP

ciao, p.

Peter Meerwald (6):
  staging:iio:accel:sca3000: Fix kerneldoc
  staging:iio:accel:sca3000: Fix format of comments
  staging:iio:accel:sca3000: Event_attribute_group seems to be missing
    for _info_with_temp
  staging:iio:accel:sca3000: Channels missing in temp_output case
  staging:iio:accel:sca3000: Move temperature attribute to channels
  staging:iio:accel:sca3000: Cleanup sca3000.h

 drivers/staging/iio/accel/sca3000.h      |  26 +++--
 drivers/staging/iio/accel/sca3000_core.c | 172 +++++++++++++------------------
 2 files changed, 90 insertions(+), 108 deletions(-)

-- 
1.8.3.2

[PATCH 1/6] staging:iio:accel:sca3000: Fix kerneldoc

[Peter Meerwald]

match function names with kerneldoc

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/staging/iio/accel/sca3000_core.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
index 7f6ccdf..908d5cd 100644
--- a/drivers/staging/iio/accel/sca3000_core.c
+++ b/drivers/staging/iio/accel/sca3000_core.c
@@ -250,9 +250,8 @@ error_ret:
 }
 #endif /* SCA3000_DEBUG */
 
-
 /**
- * sca3000_show_reg() - sysfs interface to read the chip revision number
+ * sca3000_show_rev() - sysfs interface to read the chip revision number
  **/
 static ssize_t sca3000_show_rev(struct device *dev,
 				struct device_attribute *attr,
@@ -312,7 +311,7 @@ sca3000_show_available_measurement_modes(struct device *dev,
 }
 
 /**
- * sca3000_show_measurmenet_mode() sysfs read of current mode
+ * sca3000_show_measurement_mode() sysfs read of current mode
  **/
 static ssize_t
 sca3000_show_measurement_mode(struct device *dev,
@@ -547,7 +546,7 @@ error_ret:
 	return ret;
 }
 /**
- * __sca3000_get_base_frequency() obtain mode specific base frequency
+ * __sca3000_get_base_freq() obtain mode specific base frequency
  *
  * lock must be held
  **/
@@ -972,7 +971,7 @@ error_ret:
 }
 
 /**
- * sca3000_set_mo_det() simple on off control for motion detector
+ * sca3000_write_event_config() simple on off control for motion detector
  *
  * This is a per axis control, but enabling any will result in the
  * motion detector unit being enabled.
-- 
1.8.3.2

Re: [PATCH 1/6] staging:iio:accel:sca3000: Fix kerneldoc

[Jonathan Cameron]

On 13/01/14 21:16, Peter Meerwald wrote:
> match function names with kerneldoc
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Applied to the togreg branch of iio.git, thanks.

Jonathan