From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iio: dac: ad7303: remove an unneeded check
Date: Mon, 03 Feb 2014 21:45:12 +0000 [thread overview]
Message-ID: <52F00DE8.5070002@kernel.org> (raw)
In-Reply-To: <52EB6EF4.9020203@metafoo.de>
On 31/01/14 09:37, Lars-Peter Clausen wrote:
> On 01/30/2014 12:58 PM, Dan Carpenter wrote:
>> "ret" is zero here. There is no need to check again.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
Thanks,
>
> Thanks.
>
>>
>> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
>> index d0505fd22ef4..fa2810032968 100644
>> --- a/drivers/iio/dac/ad7303.c
>> +++ b/drivers/iio/dac/ad7303.c
>> @@ -92,7 +92,7 @@ static ssize_t ad7303_write_dac_powerdown(struct iio_dev *indio_dev,
>> ad7303_write(st, chan->channel, st->dac_cache[chan->channel]);
>>
>> mutex_unlock(&indio_dev->mlock);
>> - return ret ? ret : len;
>> + return len;
>> }
>>
>> static int ad7303_get_vref(struct ad7303_state *st,
>>
>
prev parent reply other threads:[~2014-02-03 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 11:58 [patch] iio: dac: ad7303: remove an unneeded check Dan Carpenter
2014-01-31 9:37 ` Lars-Peter Clausen
2014-02-03 21:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F00DE8.5070002@kernel.org \
--to=jic23@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).