From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Mark Brown <broonie@kernel.org>, Harald Geyer <harald@ccbib.org>,
linux-iio@vger.kernel.org, Marek Vasut <marex@denx.de>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [RFC] iio: mxs-lradc: Add support for current source
Date: Wed, 12 Feb 2014 18:28:36 +0100 [thread overview]
Message-ID: <52FBAF44.6090008@metafoo.de> (raw)
In-Reply-To: <3adf03e3-5f35-4400-8d5a-2fa415f46d2e@email.android.com>
On 02/12/2014 06:20 PM, Jonathan Cameron wrote:
>
>
> On February 12, 2014 4:10:46 PM GMT+00:00, Mark Brown <broonie@kernel.org> wrote:
>> On Sat, Feb 08, 2014 at 11:59:38AM +0000, Jonathan Cameron wrote:
>>> On 28/01/14 13:52, Harald Geyer wrote:
>>
>>>> The LRADC can drive two of its ADC channels with a defined current
>>>> between 0 and 300uA to allow reading thermistors without external
>>>> current source. I'm not sure what the right IIO ABI in this case
>>
>>> I'd be tempted to do this via the regulator framework instead of IIO.
>>> At somepoint we could have a bridge to allow an iio interface on a
>> regulator
>>> if anyone wants it (you never know)
>>
>> I'm very worried about the idea of an ABI - if IIO wants to offer
>> something that is implemented using the regulator API that's fine but
>> doing it directly from the regulator API sounds worrying.
>
> Would definitely be implemented using the regulator ABI. Would effectively pipe DAC writes from user space to regulator voltage requests.
>
> Not sure I really like the idea anyway but some DACs look awfully like regulators so it might become an issue...
Yep, e.g. see drivers/regulator/ad5398.c
- Lars
next prev parent reply other threads:[~2014-02-12 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 13:52 [RFC] iio: mxs-lradc: Add support for current source Harald Geyer
2014-02-08 11:59 ` Jonathan Cameron
2014-02-12 16:10 ` Mark Brown
2014-02-12 17:20 ` Jonathan Cameron
2014-02-12 17:28 ` Lars-Peter Clausen [this message]
2014-02-08 14:38 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FBAF44.6090008@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@kernel.org \
--cc=harald@ccbib.org \
--cc=jic23@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).