From: Jonathan Cameron <jic23@kernel.org>
To: Denis CIOCCA <denis.ciocca@st.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:gyro: bug on L3GD20H gyroscope support
Date: Tue, 18 Feb 2014 10:26:03 +0000 [thread overview]
Message-ID: <5303353B.8050603@kernel.org> (raw)
In-Reply-To: <1392387337-25324-1-git-send-email-denis.ciocca@st.com>
On 14/02/14 14:15, Denis CIOCCA wrote:
> The driver was not able to manage the sensor: during probe function
> and wai check, the driver stops and writes: "device name and WhoAmI mismatch."
> The correct value of L3GD20H wai is 0xd7 instead of 0xd4.
> Dropped support for the sensor.
>
> Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
Applied to the the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/gyro/Kconfig | 2 +-
> drivers/iio/gyro/st_gyro.h | 1 -
> drivers/iio/gyro/st_gyro_core.c | 9 ++++-----
> drivers/iio/gyro/st_gyro_i2c.c | 1 -
> drivers/iio/gyro/st_gyro_spi.c | 1 -
> 5 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
> index 41c64a4..ac2d69e 100644
> --- a/drivers/iio/gyro/Kconfig
> +++ b/drivers/iio/gyro/Kconfig
> @@ -70,7 +70,7 @@ config IIO_ST_GYRO_3AXIS
> select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)
> help
> Say yes here to build support for STMicroelectronics gyroscopes:
> - L3G4200D, LSM330DL, L3GD20, L3GD20H, LSM330DLC, L3G4IS, LSM330.
> + L3G4200D, LSM330DL, L3GD20, LSM330DLC, L3G4IS, LSM330.
>
> This driver can also be built as a module. If so, these modules
> will be created:
> diff --git a/drivers/iio/gyro/st_gyro.h b/drivers/iio/gyro/st_gyro.h
> index f8f2bf8..c197360 100644
> --- a/drivers/iio/gyro/st_gyro.h
> +++ b/drivers/iio/gyro/st_gyro.h
> @@ -19,7 +19,6 @@
> #define LSM330DL_GYRO_DEV_NAME "lsm330dl_gyro"
> #define LSM330DLC_GYRO_DEV_NAME "lsm330dlc_gyro"
> #define L3GD20_GYRO_DEV_NAME "l3gd20"
> -#define L3GD20H_GYRO_DEV_NAME "l3gd20h"
> #define L3G4IS_GYRO_DEV_NAME "l3g4is_ui"
> #define LSM330_GYRO_DEV_NAME "lsm330_gyro"
>
> diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c
> index d53d91a..a8e174a 100644
> --- a/drivers/iio/gyro/st_gyro_core.c
> +++ b/drivers/iio/gyro/st_gyro_core.c
> @@ -167,11 +167,10 @@ static const struct st_sensors st_gyro_sensors[] = {
> .wai = ST_GYRO_2_WAI_EXP,
> .sensors_supported = {
> [0] = L3GD20_GYRO_DEV_NAME,
> - [1] = L3GD20H_GYRO_DEV_NAME,
> - [2] = LSM330D_GYRO_DEV_NAME,
> - [3] = LSM330DLC_GYRO_DEV_NAME,
> - [4] = L3G4IS_GYRO_DEV_NAME,
> - [5] = LSM330_GYRO_DEV_NAME,
> + [1] = LSM330D_GYRO_DEV_NAME,
> + [2] = LSM330DLC_GYRO_DEV_NAME,
> + [3] = L3G4IS_GYRO_DEV_NAME,
> + [4] = LSM330_GYRO_DEV_NAME,
> },
> .ch = (struct iio_chan_spec *)st_gyro_16bit_channels,
> .odr = {
> diff --git a/drivers/iio/gyro/st_gyro_i2c.c b/drivers/iio/gyro/st_gyro_i2c.c
> index 16b8b8d..23c12f3 100644
> --- a/drivers/iio/gyro/st_gyro_i2c.c
> +++ b/drivers/iio/gyro/st_gyro_i2c.c
> @@ -55,7 +55,6 @@ static const struct i2c_device_id st_gyro_id_table[] = {
> { LSM330DL_GYRO_DEV_NAME },
> { LSM330DLC_GYRO_DEV_NAME },
> { L3GD20_GYRO_DEV_NAME },
> - { L3GD20H_GYRO_DEV_NAME },
> { L3G4IS_GYRO_DEV_NAME },
> { LSM330_GYRO_DEV_NAME },
> {},
> diff --git a/drivers/iio/gyro/st_gyro_spi.c b/drivers/iio/gyro/st_gyro_spi.c
> index 94763e2..b4ad3be 100644
> --- a/drivers/iio/gyro/st_gyro_spi.c
> +++ b/drivers/iio/gyro/st_gyro_spi.c
> @@ -54,7 +54,6 @@ static const struct spi_device_id st_gyro_id_table[] = {
> { LSM330DL_GYRO_DEV_NAME },
> { LSM330DLC_GYRO_DEV_NAME },
> { L3GD20_GYRO_DEV_NAME },
> - { L3GD20H_GYRO_DEV_NAME },
> { L3G4IS_GYRO_DEV_NAME },
> { LSM330_GYRO_DEV_NAME },
> {},
>
prev parent reply other threads:[~2014-02-18 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 14:15 [PATCH] iio:gyro: bug on L3GD20H gyroscope support Denis CIOCCA
2014-02-18 10:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5303353B.8050603@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).