* re: iio:magnetometer:mag3110: Scale factor missing for temperature
@ 2014-02-24 22:04 Dan Carpenter
2014-02-25 19:53 ` [PATCH] iio:magnetometer:mag3110: Fix unreachable code Peter Meerwald
2014-02-25 20:00 ` iio:magnetometer:mag3110: Scale factor missing for temperature Peter Meerwald
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-02-24 22:04 UTC (permalink / raw)
To: pmeerw; +Cc: linux-iio
Hello Peter Meerwald,
The patch f9279d3a8cc8: "iio:magnetometer:mag3110: Scale factor
missing for temperature" from Oct 1, 2014, leads to the following
^^^^^^^^^^^
[ just the other day people were searching the internet for time
travellers from the future ].
static checker warning:
drivers/iio/magnetometer/mag3110.c:197 mag3110_read_raw()
info: ignoring unreachable code.
drivers/iio/magnetometer/mag3110.c
185 case IIO_CHAN_INFO_SCALE:
186 switch (chan->type) {
187 case IIO_MAGN:
188 *val = 0;
189 *val2 = 1000;
190 return IIO_VAL_INT_PLUS_MICRO;
191 case IIO_TEMP:
192 *val = 1000;
193 return IIO_VAL_INT;
194 default:
195 return -EINVAL;
196 }
197 return IIO_VAL_INT_PLUS_MICRO;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Was -EINVAL intended here?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] iio:magnetometer:mag3110: Fix unreachable code
2014-02-24 22:04 iio:magnetometer:mag3110: Scale factor missing for temperature Dan Carpenter
@ 2014-02-25 19:53 ` Peter Meerwald
2014-02-25 20:50 ` Jonathan Cameron
2014-02-25 20:00 ` iio:magnetometer:mag3110: Scale factor missing for temperature Peter Meerwald
1 sibling, 1 reply; 5+ messages in thread
From: Peter Meerwald @ 2014-02-25 19:53 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald
drivers/iio/magnetometer/mag3110.c:197 mag3110_read_raw()
info: ignoring unreachable code.
drivers/iio/magnetometer/mag3110.c
185 case IIO_CHAN_INFO_SCALE:
186 switch (chan->type) {
187 case IIO_MAGN:
188 *val = 0;
189 *val2 = 1000;
190 return IIO_VAL_INT_PLUS_MICRO;
191 case IIO_TEMP:
192 *val = 1000;
193 return IIO_VAL_INT;
194 default:
195 return -EINVAL;
196 }
197 return IIO_VAL_INT_PLUS_MICRO;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
introduced by f9279d3a, mag3110: Scale factor missing
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/magnetometer/mag3110.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/mag3110.c
index 9f260a5..e3106b4 100644
--- a/drivers/iio/magnetometer/mag3110.c
+++ b/drivers/iio/magnetometer/mag3110.c
@@ -194,7 +194,6 @@ static int mag3110_read_raw(struct iio_dev *indio_dev,
default:
return -EINVAL;
}
- return IIO_VAL_INT_PLUS_MICRO;
case IIO_CHAN_INFO_SAMP_FREQ:
i = data->ctrl_reg1 >> MAG3110_CTRL_DR_SHIFT;
*val = mag3110_samp_freq[i][0];
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] iio:magnetometer:mag3110: Fix unreachable code
2014-02-25 19:53 ` [PATCH] iio:magnetometer:mag3110: Fix unreachable code Peter Meerwald
@ 2014-02-25 20:50 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2014-02-25 20:50 UTC (permalink / raw)
To: Peter Meerwald, linux-iio
On 25/02/14 19:53, Peter Meerwald wrote:
> drivers/iio/magnetometer/mag3110.c:197 mag3110_read_raw()
> info: ignoring unreachable code.
>
> drivers/iio/magnetometer/mag3110.c
> 185 case IIO_CHAN_INFO_SCALE:
> 186 switch (chan->type) {
> 187 case IIO_MAGN:
> 188 *val = 0;
> 189 *val2 = 1000;
> 190 return IIO_VAL_INT_PLUS_MICRO;
> 191 case IIO_TEMP:
> 192 *val = 1000;
> 193 return IIO_VAL_INT;
> 194 default:
> 195 return -EINVAL;
> 196 }
> 197 return IIO_VAL_INT_PLUS_MICRO;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> introduced by f9279d3a, mag3110: Scale factor missing
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/iio/magnetometer/mag3110.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/mag3110.c
> index 9f260a5..e3106b4 100644
> --- a/drivers/iio/magnetometer/mag3110.c
> +++ b/drivers/iio/magnetometer/mag3110.c
> @@ -194,7 +194,6 @@ static int mag3110_read_raw(struct iio_dev *indio_dev,
> default:
> return -EINVAL;
> }
> - return IIO_VAL_INT_PLUS_MICRO;
> case IIO_CHAN_INFO_SAMP_FREQ:
> i = data->ctrl_reg1 >> MAG3110_CTRL_DR_SHIFT;
> *val = mag3110_samp_freq[i][0];
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* re: iio:magnetometer:mag3110: Scale factor missing for temperature
2014-02-24 22:04 iio:magnetometer:mag3110: Scale factor missing for temperature Dan Carpenter
2014-02-25 19:53 ` [PATCH] iio:magnetometer:mag3110: Fix unreachable code Peter Meerwald
@ 2014-02-25 20:00 ` Peter Meerwald
2014-02-25 20:49 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Peter Meerwald @ 2014-02-25 20:00 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-iio
> The patch f9279d3a8cc8: "iio:magnetometer:mag3110: Scale factor
> missing for temperature" from Oct 1, 2014, leads to the following
> ^^^^^^^^^^^
> [ just the other day people were searching the internet for time
> travellers from the future ].
this is indeed weird
> drivers/iio/magnetometer/mag3110.c:197 mag3110_read_raw()
> info: ignoring unreachable code.
>
> drivers/iio/magnetometer/mag3110.c
> 185 case IIO_CHAN_INFO_SCALE:
> 186 switch (chan->type) {
> 187 case IIO_MAGN:
> 188 *val = 0;
> 189 *val2 = 1000;
> 190 return IIO_VAL_INT_PLUS_MICRO;
> 191 case IIO_TEMP:
> 192 *val = 1000;
> 193 return IIO_VAL_INT;
> 194 default:
> 195 return -EINVAL;
> 196 }
> 197 return IIO_VAL_INT_PLUS_MICRO;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Was -EINVAL intended here?
no, this is dead code as the checker indicated
thanks for reporting, sent fix to linux-iio
p.
--
Peter Meerwald
+43-664-2444418 (mobile)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: iio:magnetometer:mag3110: Scale factor missing for temperature
2014-02-25 20:00 ` iio:magnetometer:mag3110: Scale factor missing for temperature Peter Meerwald
@ 2014-02-25 20:49 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2014-02-25 20:49 UTC (permalink / raw)
To: Peter Meerwald, Dan Carpenter; +Cc: linux-iio
On 25/02/14 20:00, Peter Meerwald wrote:
>
>> The patch f9279d3a8cc8: "iio:magnetometer:mag3110: Scale factor
>> missing for temperature" from Oct 1, 2014, leads to the following
>> ^^^^^^^^^^^
>> [ just the other day people were searching the internet for time
>> travellers from the future ].
>
> this is indeed weird
Quite. The interesting question is how did the date format get messed up.
>
>> drivers/iio/magnetometer/mag3110.c:197 mag3110_read_raw()
>> info: ignoring unreachable code.
>>
>> drivers/iio/magnetometer/mag3110.c
>> 185 case IIO_CHAN_INFO_SCALE:
>> 186 switch (chan->type) {
>> 187 case IIO_MAGN:
>> 188 *val = 0;
>> 189 *val2 = 1000;
>> 190 return IIO_VAL_INT_PLUS_MICRO;
>> 191 case IIO_TEMP:
>> 192 *val = 1000;
>> 193 return IIO_VAL_INT;
>> 194 default:
>> 195 return -EINVAL;
>> 196 }
>> 197 return IIO_VAL_INT_PLUS_MICRO;
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Was -EINVAL intended here?
>
> no, this is dead code as the checker indicated
>
> thanks for reporting, sent fix to linux-iio
>
> p.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-25 20:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-24 22:04 iio:magnetometer:mag3110: Scale factor missing for temperature Dan Carpenter
2014-02-25 19:53 ` [PATCH] iio:magnetometer:mag3110: Fix unreachable code Peter Meerwald
2014-02-25 20:50 ` Jonathan Cameron
2014-02-25 20:00 ` iio:magnetometer:mag3110: Scale factor missing for temperature Peter Meerwald
2014-02-25 20:49 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).