linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] staging:iio:ad799x: Move ring functions to the main file
Date: Sat, 15 Mar 2014 15:48:54 +0000	[thread overview]
Message-ID: <53247666.3000504@kernel.org> (raw)
In-Reply-To: <531E3BDC.4020609@gmx.de>

On 10/03/14 22:25, Hartmut Knaack wrote:
> Lars-Peter Clausen schrieb:
>> The ad799x_ring.c file is pretty much only one function these days. No need to
>> keep it in a separate file. Since there is then only one user of the header left
>> also move everything from the header to the main file.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> ---
>>   drivers/staging/iio/adc/Kconfig       |  13 +--
>>   drivers/staging/iio/adc/Makefile      |   1 -
>>   drivers/staging/iio/adc/ad799x.h      | 121 ----------------------------
>>   drivers/staging/iio/adc/ad799x_core.c | 145 +++++++++++++++++++++++++++++++++-
>>   drivers/staging/iio/adc/ad799x_ring.c |  84 --------------------
>>   5 files changed, 143 insertions(+), 221 deletions(-)
>>   delete mode 100644 drivers/staging/iio/adc/ad799x.h
>>   delete mode 100644 drivers/staging/iio/adc/ad799x_ring.c
>>
>>
> Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Small point Hartmut, but if adding an ack, put it just below the last sign off etc
above.  Makes it harder for me to miss ;)

Applied to the togreg branch of iio.git

Thanks and keep up the good work. I'll start pesting Lars about drivers I think he
is being too fussy about ;)
>


      reply	other threads:[~2014-03-15 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 10:31 [PATCH 1/2] staging:iio:ad799x: Move ring functions to the main file Lars-Peter Clausen
2014-03-10 10:31 ` [PATCH 2/2] staging:iio: Move ad799x driver out of staging Lars-Peter Clausen
2014-03-10 22:25   ` Hartmut Knaack
2014-03-15 15:47     ` Jonathan Cameron
2014-03-10 22:25 ` [PATCH 1/2] staging:iio:ad799x: Move ring functions to the main file Hartmut Knaack
2014-03-15 15:48   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53247666.3000504@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).