From: Jonathan Cameron <jic23@kernel.org>
To: Jean Delvare <jdelvare@suse.de>, linux-iio@vger.kernel.org
Cc: Kukjin Kim <kgene.kim@samsung.com>, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2] iio: adc: Fix exynos_adc dependencies
Date: Fri, 11 Apr 2014 21:48:54 +0100 [thread overview]
Message-ID: <53485536.10900@kernel.org> (raw)
In-Reply-To: <20140408152451.6dc2b230@endymion.delvare>
On 08/04/14 14:24, Jean Delvare wrote:
> EXYNOS_ADC shouldn't only depend on OF. It is useless on architectures
> other than Exynos so it should depend on ARCH_EXYNOS (which implies
> OF.)
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
Applied to the togreg branch of iio.git - initially pushed out as testing.
Thanks,
Jonathan
> ---
> Changes since v1:
> * Alternatively depend on COMPILE_TEST as requested by Lars-Peter
> Clausen. Thanks for the review!
>
> drivers/iio/adc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.15-rc0.orig/drivers/iio/adc/Kconfig 2014-04-08 14:54:37.418421834 +0200
> +++ linux-3.15-rc0/drivers/iio/adc/Kconfig 2014-04-08 15:20:42.735670677 +0200
> @@ -107,7 +107,7 @@ config AT91_ADC
>
> config EXYNOS_ADC
> bool "Exynos ADC driver support"
> - depends on OF
> + depends on ARCH_EXYNOS || (OF && COMPILE_TEST)
> help
> Core support for the ADC block found in the Samsung EXYNOS series
> of SoCs for drivers such as the touchscreen and hwmon to use to share
>
>
prev parent reply other threads:[~2014-04-11 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:24 [PATCH v2] iio: adc: Fix exynos_adc dependencies Jean Delvare
2014-04-11 20:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53485536.10900@kernel.org \
--to=jic23@kernel.org \
--cc=jdelvare@suse.de \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox