public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Michael Welling <mwelling@ieee.org>,
	linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jon.Brenner@ams.com
Subject: Re: [PATCH 3/3] Staging: iio: Switch from msleep to usleep range per timers-howto.txt
Date: Sat, 12 Apr 2014 18:39:39 +0100	[thread overview]
Message-ID: <53497A5B.5010709@kernel.org> (raw)
In-Reply-To: <1397096805-25168-4-git-send-email-mwelling@ieee.org>

On 10/04/14 03:26, Michael Welling wrote:
> Signed-off-by: Michael Welling <mwelling@ieee.org>
Hmm. I wonder if this is a little too tight on the range, but
given it is in a function that is likely to be called infrequently
it doesn't really matter.  Note this is where we find out whether
the datasheet is actually accurate is saying 3 msecs is long enough
by whether anyone screams :)

Also cc'd Jon as if anyone screams about this they are likely to do it
at him.  As a general rule, do cc the original author unless you know
there email bounces (and if so mention it in the cover letter as someone
might know where to get hold of them).

Applied to the togreg branch of iio.git - initially pushed out as testing.

Thanks,

Jonathan
> ---
>   drivers/staging/iio/light/tsl2583.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index f015fb4..fa96498 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -451,7 +451,7 @@ static int taos_chip_on(struct iio_dev *indio_dev)
>   		}
>   	}
>
> -	msleep(3);
> +	usleep_range(3000, 3500);
>   	/* NOW enable the ADC
>   	 * initialize the desired mode of operation */
>   	utmp = TSL258X_CNTL_PWR_ON | TSL258X_CNTL_ADC_ENBL;
>


      reply	other threads:[~2014-04-12 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  2:26 [PATCH 0/3] Staging: iio: tsl2583 checkpatch fixes Michael Welling
2014-04-10  2:26 ` [PATCH 1/3] Staging: iio: Removes unwanted space before semicolon Michael Welling
2014-04-12 17:30   ` Jonathan Cameron
2014-04-10  2:26 ` [PATCH 2/3] Staging: iio: Remove quoted string split across lines warnings Michael Welling
2014-04-12 17:31   ` Jonathan Cameron
2014-04-10  2:26 ` [PATCH 3/3] Staging: iio: Switch from msleep to usleep range per timers-howto.txt Michael Welling
2014-04-12 17:39   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53497A5B.5010709@kernel.org \
    --to=jic23@kernel.org \
    --cc=Jon.Brenner@ams.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mwelling@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox