From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35636 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbaDWVBu (ORCPT ); Wed, 23 Apr 2014 17:01:50 -0400 Message-ID: <53582A95.30805@kernel.org> Date: Wed, 23 Apr 2014 22:03:17 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 16/16] iio: hid-sensors: Pressure: Raw read support References: <1397863356-2470-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1397863356-2470-16-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1397863356-2470-16-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 19/04/14 00:22, Srinivas Pandruvada wrote: > Added support for raw reading of channel. If the sensor is powered > off, it will turn on for reading value. > > Signed-off-by: Srinivas Pandruvada Hi Srinivas. Looks like a good patch set. Probably should have been 'formally' broken in two to separate the ABI related fixes and the new stuff. I'll let this sit for a while to garner opinions on the ABI change. > --- > drivers/iio/pressure/hid-sensor-press.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c > index 39df50c..1cd190c 100644 > --- a/drivers/iio/pressure/hid-sensor-press.c > +++ b/drivers/iio/pressure/hid-sensor-press.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -79,6 +80,7 @@ static int press_read_raw(struct iio_dev *indio_dev, > u32 address; > int ret; > int ret_type; > + s32 poll_value; > > *val = 0; > *val2 = 0; > @@ -94,12 +96,23 @@ static int press_read_raw(struct iio_dev *indio_dev, > report_id = -1; > break; > } > - if (report_id >= 0) > + if (report_id >= 0) { > + poll_value = hid_sensor_read_poll_value( > + &press_state->common_attributes); > + if (poll_value < 0) > + return -EINVAL; > + hid_sensor_power_state(&press_state->common_attributes, > + true); > + > + msleep_interruptible(poll_value * 2); > + > *val = sensor_hub_input_attr_get_raw_value( > press_state->common_attributes.hsdev, > HID_USAGE_SENSOR_PRESSURE, address, > report_id); > - else { > + hid_sensor_power_state(&press_state->common_attributes, > + false); > + } else { > *val = 0; > return -EINVAL; > } >