From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, Denis CIOCCA <denis.ciocca@st.com>
Cc: Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/6] iio: st_sensors: announce registered sensors
Date: Wed, 23 Apr 2014 22:21:55 +0100 [thread overview]
Message-ID: <53582EF3.2040307@kernel.org> (raw)
In-Reply-To: <1397416143-4396-2-git-send-email-linus.walleij@linaro.org>
On 13/04/14 20:08, Linus Walleij wrote:
> It is pretty helpful to know already from dmesg that a certain
> device is successfully registered, instead of having to browse
> sysfs to see if it's actually there.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Denis CIOCCA <denis.ciocca@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hmm.. Normally I get irritated with these sorts of I'm here
messages - it's not exactly hard to tell it has been successfully
probed without filling the logs with messages fairly light on
info. Having said that I tend to let these go in new drivers
so I don't care that strongly...
> ---
> drivers/iio/accel/st_accel_core.c | 3 +++
> drivers/iio/gyro/st_gyro_core.c | 3 +++
> drivers/iio/magnetometer/st_magn_core.c | 3 +++
> drivers/iio/pressure/st_pressure_core.c | 3 +++
> 4 files changed, 12 insertions(+)
>
> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
> index 38caedc76b98..4e06fcf5b891 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -496,6 +496,9 @@ int st_accel_common_probe(struct iio_dev *indio_dev,
> if (err)
> goto st_accel_device_register_error;
>
> + dev_info(&indio_dev->dev, "registered accelerometer %s\n",
> + indio_dev->name);
> +
> return 0;
>
> st_accel_device_register_error:
> diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c
> index a8e174a47bc4..bc71f4d1e2ce 100644
> --- a/drivers/iio/gyro/st_gyro_core.c
> +++ b/drivers/iio/gyro/st_gyro_core.c
> @@ -344,6 +344,9 @@ int st_gyro_common_probe(struct iio_dev *indio_dev,
> if (err)
> goto st_gyro_device_register_error;
>
> + dev_info(&indio_dev->dev, "registered gyroscope %s\n",
> + indio_dev->name);
> +
> return 0;
>
> st_gyro_device_register_error:
> diff --git a/drivers/iio/magnetometer/st_magn_core.c b/drivers/iio/magnetometer/st_magn_core.c
> index 52bbcfa1e077..8e33a7682d33 100644
> --- a/drivers/iio/magnetometer/st_magn_core.c
> +++ b/drivers/iio/magnetometer/st_magn_core.c
> @@ -387,6 +387,9 @@ int st_magn_common_probe(struct iio_dev *indio_dev,
> if (err)
> goto st_magn_device_register_error;
>
> + dev_info(&indio_dev->dev, "registered magnetometer %s\n",
> + indio_dev->name);
> +
> return 0;
>
> st_magn_device_register_error:
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index 7418768ed49c..013becbe8f47 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -474,6 +474,9 @@ int st_press_common_probe(struct iio_dev *indio_dev,
> if (err)
> goto st_press_device_register_error;
>
> + dev_info(&indio_dev->dev, "registered pressure sensor %s\n",
> + indio_dev->name);
> +
> return err;
>
> st_press_device_register_error:
>
next prev parent reply other threads:[~2014-04-23 21:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 19:08 [PATCH 0/6] iio: enable ST Sensors on Ux500 Linus Walleij
2014-04-13 19:08 ` [PATCH 1/6] iio: st_sensors: announce registered sensors Linus Walleij
2014-04-23 21:21 ` Jonathan Cameron [this message]
2014-04-24 8:30 ` Linus Walleij
2014-04-26 10:51 ` Jonathan Cameron
2014-04-13 19:08 ` [PATCH 2/6] iio: st_sensors: move regulator retrieveal to core Linus Walleij
2014-04-13 19:09 ` [PATCH 3/6] iio: st_sensors: get platform data from device tree Linus Walleij
2014-04-26 10:56 ` Jonathan Cameron
2014-04-13 19:09 ` [PATCH 4/6] iio: st_sensors: add device tree bindings Linus Walleij
2014-04-13 19:09 ` [PATCH 5/6] iio: st_sensors: add devicetree probing support Linus Walleij
2014-04-23 21:19 ` Jonathan Cameron
2014-04-24 8:33 ` Linus Walleij
2014-04-26 10:57 ` Jonathan Cameron
2014-06-02 12:07 ` Linus Walleij
2014-04-13 19:09 ` [PATCH 6/6] ARM: ux500: add misc sensors to the device trees Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53582EF3.2040307@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).