Re: [PATCH 16/16] iio: hid-sensors: Pressure: Raw read support

[Jonathan Cameron <jic23@kernel.org>]

On 23/04/14 22:03, Jonathan Cameron wrote:
> On 19/04/14 00:22, Srinivas Pandruvada wrote:
>> Added support for raw reading of channel. If the sensor is powered
>> off, it will turn on for reading value.
>>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Hi Srinivas.
>
> Looks like a good patch set.  Probably should have been 'formally'
> broken in two to separate the ABI related fixes and the new stuff.
>
> I'll let this sit for a while to garner opinions on the ABI change.
Seems no one cares so lets put it in.

All applied to the togreg branch of iio.git pushed out initially as testing.

Jonathan
>> ---
>>   drivers/iio/pressure/hid-sensor-press.c | 17 +++++++++++++++--
>>   1 file changed, 15 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c
>> index 39df50c..1cd190c 100644
>> --- a/drivers/iio/pressure/hid-sensor-press.c
>> +++ b/drivers/iio/pressure/hid-sensor-press.c
>> @@ -21,6 +21,7 @@
>>   #include <linux/interrupt.h>
>>   #include <linux/irq.h>
>>   #include <linux/slab.h>
>> +#include <linux/delay.h>
>>   #include <linux/hid-sensor-hub.h>
>>   #include <linux/iio/iio.h>
>>   #include <linux/iio/sysfs.h>
>> @@ -79,6 +80,7 @@ static int press_read_raw(struct iio_dev *indio_dev,
>>       u32 address;
>>       int ret;
>>       int ret_type;
>> +    s32 poll_value;
>>
>>       *val = 0;
>>       *val2 = 0;
>> @@ -94,12 +96,23 @@ static int press_read_raw(struct iio_dev *indio_dev,
>>               report_id = -1;
>>               break;
>>           }
>> -        if (report_id >= 0)
>> +        if (report_id >= 0) {
>> +            poll_value = hid_sensor_read_poll_value(
>> +                    &press_state->common_attributes);
>> +            if (poll_value < 0)
>> +                return -EINVAL;
>> +            hid_sensor_power_state(&press_state->common_attributes,
>> +                        true);
>> +
>> +            msleep_interruptible(poll_value * 2);
>> +
>>               *val = sensor_hub_input_attr_get_raw_value(
>>                   press_state->common_attributes.hsdev,
>>                   HID_USAGE_SENSOR_PRESSURE, address,
>>                   report_id);
>> -        else {
>> +            hid_sensor_power_state(&press_state->common_attributes,
>> +                        false);
>> +        } else {
>>               *val = 0;
>>               return -EINVAL;
>>           }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html