public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: hardware buffer enabling
Date: Wed, 07 May 2014 21:03:15 +0100	[thread overview]
Message-ID: <536A9183.4090304@kernel.org> (raw)
In-Reply-To: <53691420.8060503@linux.intel.com>



On May 6, 2014 5:56:00 PM GMT+01:00, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
>Hi Jonathan,
>
>The Android user space has some capability to ask the supported
>hardware
>to enable buffering in hardware.
>I don't think that we can achieve this by current ABI.  Do you want me
>to propose new ABI?
This is closely related to watershed events on buffers, both software and hardware.  We
had these back in the early days but the interface was fiddly. It used a couple of iio
events to tell user space the watershed was passed.

One suggestion from Arnd Bergmann was to use one of the less commonly used poll
types to indicate this to user space. It was in a long system wide review he did not long
after we entered staging.  Looked like a neat idea as could coexist nicely with existing
interfaces on the same buffer. Would definitely require a fair bit of documentation.
Thread in question is around about:
https://lkml.org/lkml/2011/3/16/190


Also note we already have hardware buffered devices pushing into software
buffers (without a trigger) which effectively handle the same use case using existing interfaces.
See the ti_am335x_adc driver.

There is definitely room for something more controllable but it shouldn't be too focused
on hardware buffering as makes sense for software buffers too!

So to take a stab in the air we need some means of setting the watershed level
(and a callback to pass this on to the hardware if that makes sense).
The fiddly cases are going to be the corner cases such as when the length changes.

what do you think?
>
>"
>Android batch mode:
>batch(int handle, int flags, int64_t period_ns, int64_t
>max_report_latency)
>
>Enabling batch mode for a given sensor sets the delay between events.
>max_report_latency sets the maximum time by which events can be delayed
>
>and batched together before being reported to the applications. A value
>
>of zero disables batch mode for the given sensor. The period_ns
>parameter is equivalent to calling setDelay() -- this function both
>enables or disables the batch mode AND sets the event's period in
>nanoseconds. See setDelay() for a detailed explanation of the period_ns
>
>parameter.

Hmm. Max latency would just be a timeout on the poll. Period is a trigger characteristic
  or a hardware one if no explicit trigger is present.

There is clearly ad
>
>In non-batch mode, all sensor events must be reported as soon as they
>are detected. For example, an accelerometer activated at 50Hz will
>trigger interrupts 50 times per second.
>While in batch mode, sensor events do not need to be reported as soon
>as
>they are detected. They can be temporarily stored and reported in
>batches, as long as no event is delayed by more than
>maxReportingLatency
>nanoseconds. That is, all events since the previous batch are recorded
>and returned at once. This reduces the amount of interrupts sent to the
>
>SoC and allows the SoC to switch to a lower power mode (idle) while the
>
>sensor is capturing and batching data.
>
>setDelay() is not affected and it behaves as usual.
>
>Each event has a timestamp associated with it. The timestamp must be
>accurate and correspond to the time at which the event physically
>happened.
>
>Batching does not modify the behavior of poll(): batches from different
>
>sensors can be interleaved and split. As usual, all events from the
>same
>sensor are time-ordered.
>"
>
>
>Thanks,
>Srinivas

  reply	other threads:[~2014-05-07 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 16:56 hardware buffer enabling Srinivas Pandruvada
2014-05-07 20:03 ` Jonathan Cameron [this message]
2014-05-08 16:17   ` Srinivas Pandruvada
2014-05-10 10:50     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536A9183.4090304@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox