linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Reyad Attiyat <reyad.attiyat@gmail.com>
Cc: jic23@kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: HID Sensor support for True/Magnetic North usage attributes
Date: Fri, 16 May 2014 10:46:06 -0700	[thread overview]
Message-ID: <53764EDE.8090008@linux.intel.com> (raw)
In-Reply-To: <CA+BWVUShz2_Xd8EBWE+igjYk6Bc+K=LbjCr6EH7hNhvVodka6A@mail.gmail.com>

On 05/13/2014 07:14 PM, Reyad Attiyat wrote:
> Dear IIO/HID maintainers,
>
> I have a device, Surface Pro, that has the hid-sensor-hub and many
> sensors attached. With the help of Srinivas I was able to get them all
> working except for the magnometer. It uses the hid-magn-3d driver as
> it should but it does not contain an axis (X, Y, Z) usage attributes.
> Instead it only has a True North usage attribute. I see two solutions
> to this problem and was inquiring which one would work best?
>
> 1) Modify the hid-magn-3d driver to handle True North attribute. I
> realize there might not be many devices that have this so not sure if
> appropriate. I think this could be done; by passing a variable amount
> of IIO Channels when setting up the hid-magn-3d driver, depending on
> how many axis and/or if it find True/Magnetic North usage attribute.
I prefer this approach. The spec doesn't say whether magnetic flux for 
x,y or z are mandatory.
Ultimately they are used to calculate the true north. So if the hub is 
trying to expose true north,
we should add this attribute.

"Heading True North SV – Indicates compass true north heading is not 
compensated.
                     Default unit of measure is degrees; can be 
overridden using
                    explicit Unit and/or Unit Exponent."

Thanks,
Srinivas
> 2) Create a whole new driver that handles True/Magnetic North. This
> would not work on my device as it is set to Compass 3D Usage
> Attribute. This could be resolved by adding another quirk for the
> Surface to ensure it used the new driver.
>
> For both options I think we'd need a new IIO_MOD_NORTH for the
> iio_chan_spec, as the current ones don't really apply. I like the
> first solution as it could allow for handling of devices with only one
> or two axis present. I do realize if the hid-mangn-3d driver was
> changed it's name would not make sense anymore and the pattern I'm
> notcing is a driver for each HID Usage.
>
> Here's a link to the hid report description with some labels for my device:
> Bug 73321 Comment 7
> https://bugzilla.kernel.org/show_bug.cgi?id=73321#c7
>
> I'd be willing to work on this. Just wanted to know what would work best
>
> Thank You,
> Reyad Attiyat
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2014-05-16 17:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  2:14 HID Sensor support for True/Magnetic North usage attributes Reyad Attiyat
2014-05-16 17:46 ` Srinivas Pandruvada [this message]
2014-05-24 10:39   ` Jonathan Cameron
2014-05-27  3:20     ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat
2014-05-27  3:20       ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat
2014-05-27 15:27         ` Srinivas Pandruvada
2014-05-31 10:20           ` Jonathan Cameron
2014-05-27 15:34       ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada
2014-05-31 10:17         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53764EDE.8090008@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reyad.attiyat@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).