[PATCH] iio: hid-sensors: Get feature report from sensor hub after changing power state

[PATCH] iio: hid-sensors: Get feature report from sensor hub after changing power state

[Archana Patni]

Some sensor hubs require a get feature report call to be issued soon after
changing the power state of the sensor. Without this, the sensor remains in
the current state. This patch adds a call soon after the power state.

This is retained as a generic call across all sensor hubs since the behavior
has been noticed on more than one implementation.

Signed-off-by: Archana Patni <archana.patni@intel.com>
Signed-off-by: Subramony Sesha <subramony.sesha@intel.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
---
 .../iio/common/hid-sensors/hid-sensor-trigger.c    |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index dbefbda..f26f52d 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -73,6 +73,9 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
 					(s32)report_val);
 	}
 
+	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
+					st->power_state.index,
+					&state_val);
 	return 0;
 }
 
-- 
1.7.9.5

Re: [PATCH] iio: hid-sensors: Get feature report from sensor hub after changing power state

[Jonathan Cameron]

On 19/05/14 12:19, Archana Patni wrote:
> Some sensor hubs require a get feature report call to be issued soon after
> changing the power state of the sensor. Without this, the sensor remains in
> the current state. This patch adds a call soon after the power state.
>
> This is retained as a generic call across all sensor hubs since the behavior
> has been noticed on more than one implementation.
>
> Signed-off-by: Archana Patni <archana.patni@intel.com>
> Signed-off-by: Subramony Sesha <subramony.sesha@intel.com>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
As this isn't a regression (never worked) I've applied it to the
togreg branch of iio.git.

Thanks,

Jonathan
> ---
>   .../iio/common/hid-sensors/hid-sensor-trigger.c    |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index dbefbda..f26f52d 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -73,6 +73,9 @@ static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
>   					(s32)report_val);
>   	}
>
> +	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
> +					st->power_state.index,
> +					&state_val);
>   	return 0;
>   }
>
>