linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] fix format string msimatch in staging/iio/Documentation/iio_utils.h
Date: Sun, 25 May 2014 12:11:02 +0100	[thread overview]
Message-ID: <5381CFC6.6050307@kernel.org> (raw)
In-Reply-To: <1400937951-31693-1-git-send-email-toralf.foerster@gmx.de>

On 24/05/14 14:25, Toralf Förster wrote:
> spotted by cppcheck
>
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Applied to the togreg branch of iio.git.

Thanks,
> ---
>   drivers/staging/iio/Documentation/iio_utils.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/Documentation/iio_utils.h b/drivers/staging/iio/Documentation/iio_utils.h
> index 2064839..a9cfc06 100644
> --- a/drivers/staging/iio/Documentation/iio_utils.h
> +++ b/drivers/staging/iio/Documentation/iio_utils.h
> @@ -318,7 +318,7 @@ inline int build_channel_array(const char *device_dir,
>   				free(filename);
>   				goto error_close_dir;
>   			}
> -			fscanf(sysfsfp, "%u", &ret);
> +			fscanf(sysfsfp, "%i", &ret);
>   			if (ret == 1)
>   				(*counter)++;
>   			fclose(sysfsfp);
> @@ -350,7 +350,7 @@ inline int build_channel_array(const char *device_dir,
>   				ret = -errno;
>   				goto error_cleanup_array;
>   			}
> -			fscanf(sysfsfp, "%u", &current_enabled);
> +			fscanf(sysfsfp, "%i", &current_enabled);
>   			fclose(sysfsfp);
>
>   			if (!current_enabled) {
>


      reply	other threads:[~2014-05-25 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-24 13:25 [PATCH] fix format string msimatch in staging/iio/Documentation/iio_utils.h Toralf Förster
2014-05-25 11:11 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5381CFC6.6050307@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).