From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Reyad Attiyat <reyad.attiyat@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
jic23@kernel.org
Subject: Re: [PATCH] IIO: Support for True/Magnetic north
Date: Tue, 27 May 2014 08:34:49 -0700 [thread overview]
Message-ID: <5384B099.2070808@linux.intel.com> (raw)
In-Reply-To: <1401160821-5006-1-git-send-email-reyad.attiyat@gmail.com>
Hi Reyad,
On 05/26/2014 08:20 PM, Reyad Attiyat wrote:
> Hey Jonathan and Srinivas,
>
> I have added in the needed magn_north iio sysfs attributes to the documentation.
> I hope I did everything correct.
> I noticed that the line length was very long as compensated is a fairly long word.
> I'm thinking I could shorten some of the sysfs paths or shorten the name.
>
> For updating the hid-sensor-magn-3d do you have any tips on this? I'm thinking I'll need a
> dynamic iio_chan array that is passed to iio_register function. It would need to
> be dynamic in the sense it would only add channels if it found x, y, z, or one of
> the north attributes. I'll start working on this soon.
I think you mean dynamic " iio_chan_spec magn_3d_channels[]". Currently
this is a
constant. So we can change this to add only channel, which are available.
Also your other changes must be submitted as series of patches,
including the drivers using them.
Thanks,
Srinivas
> Thank You,
> Reyad Attiyat
>
>
>
> Reyad Attiyat (1):
> IIO: Added iio magn_north ABI documentation
>
> Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
>
next prev parent reply other threads:[~2014-05-27 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 2:14 HID Sensor support for True/Magnetic North usage attributes Reyad Attiyat
2014-05-16 17:46 ` Srinivas Pandruvada
2014-05-24 10:39 ` Jonathan Cameron
2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat
2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat
2014-05-27 15:27 ` Srinivas Pandruvada
2014-05-31 10:20 ` Jonathan Cameron
2014-05-27 15:34 ` Srinivas Pandruvada [this message]
2014-05-31 10:17 ` [PATCH] IIO: Support for True/Magnetic north Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384B099.2070808@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reyad.attiyat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).