* HID Sensor support for True/Magnetic North usage attributes @ 2014-05-14 2:14 Reyad Attiyat 2014-05-16 17:46 ` Srinivas Pandruvada 0 siblings, 1 reply; 9+ messages in thread From: Reyad Attiyat @ 2014-05-14 2:14 UTC (permalink / raw) To: jic23, Srinivas Pandruvada, linux-kernel, linux-iio Dear IIO/HID maintainers, I have a device, Surface Pro, that has the hid-sensor-hub and many sensors attached. With the help of Srinivas I was able to get them all working except for the magnometer. It uses the hid-magn-3d driver as it should but it does not contain an axis (X, Y, Z) usage attributes. Instead it only has a True North usage attribute. I see two solutions to this problem and was inquiring which one would work best? 1) Modify the hid-magn-3d driver to handle True North attribute. I realize there might not be many devices that have this so not sure if appropriate. I think this could be done; by passing a variable amount of IIO Channels when setting up the hid-magn-3d driver, depending on how many axis and/or if it find True/Magnetic North usage attribute. 2) Create a whole new driver that handles True/Magnetic North. This would not work on my device as it is set to Compass 3D Usage Attribute. This could be resolved by adding another quirk for the Surface to ensure it used the new driver. For both options I think we'd need a new IIO_MOD_NORTH for the iio_chan_spec, as the current ones don't really apply. I like the first solution as it could allow for handling of devices with only one or two axis present. I do realize if the hid-mangn-3d driver was changed it's name would not make sense anymore and the pattern I'm notcing is a driver for each HID Usage. Here's a link to the hid report description with some labels for my device: Bug 73321 Comment 7 https://bugzilla.kernel.org/show_bug.cgi?id=73321#c7 I'd be willing to work on this. Just wanted to know what would work best Thank You, Reyad Attiyat ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: HID Sensor support for True/Magnetic North usage attributes 2014-05-14 2:14 HID Sensor support for True/Magnetic North usage attributes Reyad Attiyat @ 2014-05-16 17:46 ` Srinivas Pandruvada 2014-05-24 10:39 ` Jonathan Cameron 0 siblings, 1 reply; 9+ messages in thread From: Srinivas Pandruvada @ 2014-05-16 17:46 UTC (permalink / raw) To: Reyad Attiyat; +Cc: jic23, linux-kernel, linux-iio On 05/13/2014 07:14 PM, Reyad Attiyat wrote: > Dear IIO/HID maintainers, > > I have a device, Surface Pro, that has the hid-sensor-hub and many > sensors attached. With the help of Srinivas I was able to get them all > working except for the magnometer. It uses the hid-magn-3d driver as > it should but it does not contain an axis (X, Y, Z) usage attributes. > Instead it only has a True North usage attribute. I see two solutions > to this problem and was inquiring which one would work best? > > 1) Modify the hid-magn-3d driver to handle True North attribute. I > realize there might not be many devices that have this so not sure if > appropriate. I think this could be done; by passing a variable amount > of IIO Channels when setting up the hid-magn-3d driver, depending on > how many axis and/or if it find True/Magnetic North usage attribute. I prefer this approach. The spec doesn't say whether magnetic flux for x,y or z are mandatory. Ultimately they are used to calculate the true north. So if the hub is trying to expose true north, we should add this attribute. "Heading True North SV – Indicates compass true north heading is not compensated. Default unit of measure is degrees; can be overridden using explicit Unit and/or Unit Exponent." Thanks, Srinivas > 2) Create a whole new driver that handles True/Magnetic North. This > would not work on my device as it is set to Compass 3D Usage > Attribute. This could be resolved by adding another quirk for the > Surface to ensure it used the new driver. > > For both options I think we'd need a new IIO_MOD_NORTH for the > iio_chan_spec, as the current ones don't really apply. I like the > first solution as it could allow for handling of devices with only one > or two axis present. I do realize if the hid-mangn-3d driver was > changed it's name would not make sense anymore and the pattern I'm > notcing is a driver for each HID Usage. > > Here's a link to the hid report description with some labels for my device: > Bug 73321 Comment 7 > https://bugzilla.kernel.org/show_bug.cgi?id=73321#c7 > > I'd be willing to work on this. Just wanted to know what would work best > > Thank You, > Reyad Attiyat > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: HID Sensor support for True/Magnetic North usage attributes 2014-05-16 17:46 ` Srinivas Pandruvada @ 2014-05-24 10:39 ` Jonathan Cameron 2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat 0 siblings, 1 reply; 9+ messages in thread From: Jonathan Cameron @ 2014-05-24 10:39 UTC (permalink / raw) To: Srinivas Pandruvada, Reyad Attiyat; +Cc: linux-kernel, linux-iio On 16/05/14 18:46, Srinivas Pandruvada wrote: > On 05/13/2014 07:14 PM, Reyad Attiyat wrote: >> Dear IIO/HID maintainers, >> >> I have a device, Surface Pro, that has the hid-sensor-hub and many >> sensors attached. With the help of Srinivas I was able to get them all >> working except for the magnometer. It uses the hid-magn-3d driver as >> it should but it does not contain an axis (X, Y, Z) usage attributes. >> Instead it only has a True North usage attribute. I see two solutions >> to this problem and was inquiring which one would work best? >> >> 1) Modify the hid-magn-3d driver to handle True North attribute. I >> realize there might not be many devices that have this so not sure if >> appropriate. I think this could be done; by passing a variable amount >> of IIO Channels when setting up the hid-magn-3d driver, depending on >> how many axis and/or if it find True/Magnetic North usage attribute. > I prefer this approach. The spec doesn't say whether magnetic flux for x,y or z are mandatory. > Ultimately they are used to calculate the true north. So if the hub is trying to expose true north, > we should add this attribute. > > "Heading True North SV – Indicates compass true north heading is not compensated. > Default unit of measure is degrees; can be overridden using > explicit Unit and/or Unit Exponent." > Agreed. Don't worry too much about the driver naming. Plenty of convention says that it has no real meaning other than labelling one part supported by the driver. > Thanks, > Srinivas >> 2) Create a whole new driver that handles True/Magnetic North. This >> would not work on my device as it is set to Compass 3D Usage >> Attribute. This could be resolved by adding another quirk for the >> Surface to ensure it used the new driver. No to this one as we'll end up with lots of similar cases and far too many similar drivers. >> >> For both options I think we'd need a new IIO_MOD_NORTH for the >> iio_chan_spec, as the current ones don't really apply. I like the >> first solution as it could allow for handling of devices with only one >> or two axis present. I do realize if the hid-mangn-3d driver was >> changed it's name would not make sense anymore and the pattern I'm >> notcing is a driver for each HID Usage. If you are introducing a north attribute, allow for both true and magnetic norths (only introduce the one you are using). IIO_MOD_NORTH_TRUE IIO_MOD_NORTH_MAGNETIC perhaps? I see the spec also mentions compensated variants of these... If you do include these I think IIO_MOD_NORTH_TRUE_TILT_COMPENSATED or similar would be needed to make it clear what was going on. >> >> Here's a link to the hid report description with some labels for my device: >> Bug 73321 Comment 7 >> https://bugzilla.kernel.org/show_bug.cgi?id=73321#c7 >> >> I'd be willing to work on this. Just wanted to know what would work best >> Cool. I'd suggest perhaps doing the documentation first for the new ABI elements then we can hammer that out in parallel with work on the driver. (it's usually the harder part!) >> Thank You, >> Reyad Attiyat >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] IIO: Support for True/Magnetic north 2014-05-24 10:39 ` Jonathan Cameron @ 2014-05-27 3:20 ` Reyad Attiyat 2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat 2014-05-27 15:34 ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada 0 siblings, 2 replies; 9+ messages in thread From: Reyad Attiyat @ 2014-05-27 3:20 UTC (permalink / raw) To: linux-kernel, linux-iio, srinivas.pandruvada, jic23; +Cc: Reyad Attiyat Hey Jonathan and Srinivas, I have added in the needed magn_north iio sysfs attributes to the documentation. I hope I did everything correct. I noticed that the line length was very long as compensated is a fairly long word. I'm thinking I could shorten some of the sysfs paths or shorten the name. For updating the hid-sensor-magn-3d do you have any tips on this? I'm thinking I'll need a dynamic iio_chan array that is passed to iio_register function. It would need to be dynamic in the sense it would only add channels if it found x, y, z, or one of the north attributes. I'll start working on this soon. Thank You, Reyad Attiyat Reyad Attiyat (1): IIO: Added iio magn_north ABI documentation Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) -- 1.9.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] IIO: Added iio magn_north ABI documentation 2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat @ 2014-05-27 3:20 ` Reyad Attiyat 2014-05-27 15:27 ` Srinivas Pandruvada 2014-05-27 15:34 ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada 1 sibling, 1 reply; 9+ messages in thread From: Reyad Attiyat @ 2014-05-27 3:20 UTC (permalink / raw) To: linux-kernel, linux-iio, srinivas.pandruvada, jic23; +Cc: Reyad Attiyat Added documentation for HID magnometer true/magnetic north sensor. --- Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio index 6e02c50..3305fe8 100644 --- a/Documentation/ABI/testing/sysfs-bus-iio +++ b/Documentation/ABI/testing/sysfs-bus-iio @@ -165,6 +165,10 @@ Description: What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_raw What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_raw What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_raw +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_raw +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_raw +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_raw +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_raw KernelVersion: 2.6.35 Contact: linux-iio@vger.kernel.org Description: @@ -249,6 +253,10 @@ What: /sys/bus/iio/devices/iio:deviceX/in_magn_scale What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_scale What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_scale What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_scale +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_scale +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_scale +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_scale +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_scale What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_scale What: /sys/bus/iio/devices/iio:deviceX/in_pressure_scale KernelVersion: 2.6.35 @@ -436,6 +444,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_thresh_rising_en What: /sys/.../iio:deviceX/events/in_magn_y_thresh_falling_en What: /sys/.../iio:deviceX/events/in_magn_z_thresh_rising_en What: /sys/.../iio:deviceX/events/in_magn_z_thresh_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_falling_en What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_rising_en What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_falling_en What: /sys/.../iio:deviceX/events/in_voltageY_thresh_rising_en @@ -481,6 +497,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_roc_rising_en What: /sys/.../iio:deviceX/events/in_magn_y_roc_falling_en What: /sys/.../iio:deviceX/events/in_magn_z_roc_rising_en What: /sys/.../iio:deviceX/events/in_magn_z_roc_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_falling_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_rising_en +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_falling_en What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_rising_en What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_falling_en What: /sys/.../iio:deviceX/events/in_voltageY_roc_rising_en @@ -527,6 +551,14 @@ What: /sys/.../events/in_magn_y_raw_thresh_rising_value What: /sys/.../events/in_magn_y_raw_thresh_falling_value What: /sys/.../events/in_magn_z_raw_thresh_rising_value What: /sys/.../events/in_magn_z_raw_thresh_falling_value +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_rising_value +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_falling_value +What: /sys/.../events/in_magn_north_true_raw_thresh_rising_value +What: /sys/.../events/in_magn_north_true_raw_thresh_falling_value +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_rising_value +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_falling_value +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_rising_value +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_falling_value What: /sys/.../events/in_voltageY_supply_raw_thresh_rising_value What: /sys/.../events/in_voltageY_supply_raw_thresh_falling_value What: /sys/.../events/in_voltageY_raw_thresh_rising_value @@ -577,6 +609,18 @@ What: /sys/.../events/in_magn_y_thresh_either_hysteresis What: /sys/.../events/in_magn_z_thresh_rising_hysteresis What: /sys/.../events/in_magn_z_thresh_falling_hysteresis What: /sys/.../events/in_magn_z_thresh_either_hysteresis +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_hysteresis +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_hysteresis +What: /sys/.../events/in_magn_north_magnetic_thresh_either_hysteresis +What: /sys/.../events/in_magn_north_true_thresh_rising_hysteresis +What: /sys/.../events/in_magn_north_true_thresh_falling_hysteresis +What: /sys/.../events/in_magn_north_true_thresh_either_hysteresis +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_hysteresis +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_hysteresis +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_either_hysteresis +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_hysteresis +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_hysteresis +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_either_hysteresis What: /sys/.../events/in_voltageY_thresh_rising_hysteresis What: /sys/.../events/in_voltageY_thresh_falling_hysteresis What: /sys/.../events/in_voltageY_thresh_either_hysteresis @@ -624,6 +668,14 @@ What: /sys/.../events/in_magn_y_raw_roc_rising_value What: /sys/.../events/in_magn_y_raw_roc_falling_value What: /sys/.../events/in_magn_z_raw_roc_rising_value What: /sys/.../events/in_magn_z_raw_roc_falling_value +What: /sys/.../events/in_magn_north_magnetic_raw_roc_rising_value +What: /sys/.../events/in_magn_north_magnetic_raw_roc_falling_value +What: /sys/.../events/in_magn_north_true_raw_roc_rising_value +What: /sys/.../events/in_magn_north_true_raw_roc_falling_value +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_rising_value +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_falling_value +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_rising_value +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_falling_value What: /sys/.../events/in_voltageY_supply_raw_roc_rising_value What: /sys/.../events/in_voltageY_supply_raw_roc_falling_value What: /sys/.../events/in_voltageY_raw_roc_rising_value @@ -679,6 +731,22 @@ What: /sys/.../events/in_magn_z_thresh_rising_period What: /sys/.../events/in_magn_z_thresh_falling_period What: /sys/.../events/in_magn_z_roc_rising_period What: /sys/.../events/in_magn_z_roc_falling_period +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_period +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_period +What: /sys/.../events/in_magn_north_magnetic_roc_rising_period +What: /sys/.../events/in_magn_north_magnetic_roc_falling_period +What: /sys/.../events/in_magn_north_true_thresh_rising_period +What: /sys/.../events/in_magn_north_true_thresh_falling_period +What: /sys/.../events/in_magn_north_true_roc_rising_period +What: /sys/.../events/in_magn_north_true_roc_falling_period +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_period +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_period +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_rising_period +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_falling_period +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_period +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_period +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_rising_period +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_falling_period What: /sys/.../events/in_voltageY_supply_thresh_rising_period What: /sys/.../events/in_voltageY_supply_thresh_falling_period What: /sys/.../events/in_voltageY_supply_roc_rising_period @@ -776,6 +844,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_en What: /sys/.../iio:deviceX/scan_elements/in_magn_x_en What: /sys/.../iio:deviceX/scan_elements/in_magn_y_en What: /sys/.../iio:deviceX/scan_elements/in_magn_z_en +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_en +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_en +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_en +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_en What: /sys/.../iio:deviceX/scan_elements/in_timestamp_en What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en What: /sys/.../iio:deviceX/scan_elements/in_voltageY_en @@ -840,6 +912,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_index What: /sys/.../iio:deviceX/scan_elements/in_magn_x_index What: /sys/.../iio:deviceX/scan_elements/in_magn_y_index What: /sys/.../iio:deviceX/scan_elements/in_magn_z_index +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_index +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_index +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_index +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_index What: /sys/.../iio:deviceX/scan_elements/in_incli_x_index What: /sys/.../iio:deviceX/scan_elements/in_incli_y_index What: /sys/.../iio:deviceX/scan_elements/in_timestamp_index -- 1.9.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] IIO: Added iio magn_north ABI documentation 2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat @ 2014-05-27 15:27 ` Srinivas Pandruvada 2014-05-31 10:20 ` Jonathan Cameron 0 siblings, 1 reply; 9+ messages in thread From: Srinivas Pandruvada @ 2014-05-27 15:27 UTC (permalink / raw) To: Reyad Attiyat; +Cc: linux-kernel, linux-iio, jic23 On 05/26/2014 08:20 PM, Reyad Attiyat wrote: > Added documentation for HID magnometer true/magnetic north sensor. > --- > Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > index 6e02c50..3305fe8 100644 > --- a/Documentation/ABI/testing/sysfs-bus-iio > +++ b/Documentation/ABI/testing/sysfs-bus-iio > @@ -165,6 +165,10 @@ Description: > What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_raw > What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_raw > What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_raw > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_raw These names are very long. May be we remove work "magnetic" as there attributes only apply to magnetometer. > KernelVersion: 2.6.35 > Contact: linux-iio@vger.kernel.org > Description: > @@ -249,6 +253,10 @@ What: /sys/bus/iio/devices/iio:deviceX/in_magn_scale > What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_scale > What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_scale > What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_scale > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_scale > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_scale > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_scale > +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_scale > What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_scale > What: /sys/bus/iio/devices/iio:deviceX/in_pressure_scale > KernelVersion: 2.6.35 > @@ -436,6 +444,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_thresh_rising_en > What: /sys/.../iio:deviceX/events/in_magn_y_thresh_falling_en > What: /sys/.../iio:deviceX/events/in_magn_z_thresh_rising_en > What: /sys/.../iio:deviceX/events/in_magn_z_thresh_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_falling_en > What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_rising_en > What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_falling_en > What: /sys/.../iio:deviceX/events/in_voltageY_thresh_rising_en > @@ -481,6 +497,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_roc_rising_en > What: /sys/.../iio:deviceX/events/in_magn_y_roc_falling_en > What: /sys/.../iio:deviceX/events/in_magn_z_roc_rising_en > What: /sys/.../iio:deviceX/events/in_magn_z_roc_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_falling_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_rising_en > +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_falling_en Same as above. Names are very long. Thanks, Srinivas > What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_rising_en > What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_falling_en > What: /sys/.../iio:deviceX/events/in_voltageY_roc_rising_en > @@ -527,6 +551,14 @@ What: /sys/.../events/in_magn_y_raw_thresh_rising_value > What: /sys/.../events/in_magn_y_raw_thresh_falling_value > What: /sys/.../events/in_magn_z_raw_thresh_rising_value > What: /sys/.../events/in_magn_z_raw_thresh_falling_value > +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_rising_value > +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_falling_value > +What: /sys/.../events/in_magn_north_true_raw_thresh_rising_value > +What: /sys/.../events/in_magn_north_true_raw_thresh_falling_value > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_rising_value > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_falling_value > +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_rising_value > +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_falling_value > What: /sys/.../events/in_voltageY_supply_raw_thresh_rising_value > What: /sys/.../events/in_voltageY_supply_raw_thresh_falling_value > What: /sys/.../events/in_voltageY_raw_thresh_rising_value > @@ -577,6 +609,18 @@ What: /sys/.../events/in_magn_y_thresh_either_hysteresis > What: /sys/.../events/in_magn_z_thresh_rising_hysteresis > What: /sys/.../events/in_magn_z_thresh_falling_hysteresis > What: /sys/.../events/in_magn_z_thresh_either_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_thresh_either_hysteresis > +What: /sys/.../events/in_magn_north_true_thresh_rising_hysteresis > +What: /sys/.../events/in_magn_north_true_thresh_falling_hysteresis > +What: /sys/.../events/in_magn_north_true_thresh_either_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_hysteresis > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_either_hysteresis > +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_hysteresis > +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_hysteresis > +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_either_hysteresis > What: /sys/.../events/in_voltageY_thresh_rising_hysteresis > What: /sys/.../events/in_voltageY_thresh_falling_hysteresis > What: /sys/.../events/in_voltageY_thresh_either_hysteresis > @@ -624,6 +668,14 @@ What: /sys/.../events/in_magn_y_raw_roc_rising_value > What: /sys/.../events/in_magn_y_raw_roc_falling_value > What: /sys/.../events/in_magn_z_raw_roc_rising_value > What: /sys/.../events/in_magn_z_raw_roc_falling_value > +What: /sys/.../events/in_magn_north_magnetic_raw_roc_rising_value > +What: /sys/.../events/in_magn_north_magnetic_raw_roc_falling_value > +What: /sys/.../events/in_magn_north_true_raw_roc_rising_value > +What: /sys/.../events/in_magn_north_true_raw_roc_falling_value > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_rising_value > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_falling_value > +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_rising_value > +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_falling_value > What: /sys/.../events/in_voltageY_supply_raw_roc_rising_value > What: /sys/.../events/in_voltageY_supply_raw_roc_falling_value > What: /sys/.../events/in_voltageY_raw_roc_rising_value > @@ -679,6 +731,22 @@ What: /sys/.../events/in_magn_z_thresh_rising_period > What: /sys/.../events/in_magn_z_thresh_falling_period > What: /sys/.../events/in_magn_z_roc_rising_period > What: /sys/.../events/in_magn_z_roc_falling_period > +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_period > +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_period > +What: /sys/.../events/in_magn_north_magnetic_roc_rising_period > +What: /sys/.../events/in_magn_north_magnetic_roc_falling_period > +What: /sys/.../events/in_magn_north_true_thresh_rising_period > +What: /sys/.../events/in_magn_north_true_thresh_falling_period > +What: /sys/.../events/in_magn_north_true_roc_rising_period > +What: /sys/.../events/in_magn_north_true_roc_falling_period > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_period > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_period > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_rising_period > +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_falling_period > +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_period > +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_period > +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_rising_period > +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_falling_period > What: /sys/.../events/in_voltageY_supply_thresh_rising_period > What: /sys/.../events/in_voltageY_supply_thresh_falling_period > What: /sys/.../events/in_voltageY_supply_roc_rising_period > @@ -776,6 +844,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_en > What: /sys/.../iio:deviceX/scan_elements/in_magn_x_en > What: /sys/.../iio:deviceX/scan_elements/in_magn_y_en > What: /sys/.../iio:deviceX/scan_elements/in_magn_z_en > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_en > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_en > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_en > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_en > What: /sys/.../iio:deviceX/scan_elements/in_timestamp_en > What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en > What: /sys/.../iio:deviceX/scan_elements/in_voltageY_en > @@ -840,6 +912,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_index > What: /sys/.../iio:deviceX/scan_elements/in_magn_x_index > What: /sys/.../iio:deviceX/scan_elements/in_magn_y_index > What: /sys/.../iio:deviceX/scan_elements/in_magn_z_index > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_index > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_index > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_index > +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_index > What: /sys/.../iio:deviceX/scan_elements/in_incli_x_index > What: /sys/.../iio:deviceX/scan_elements/in_incli_y_index > What: /sys/.../iio:deviceX/scan_elements/in_timestamp_index ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] IIO: Added iio magn_north ABI documentation 2014-05-27 15:27 ` Srinivas Pandruvada @ 2014-05-31 10:20 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2014-05-31 10:20 UTC (permalink / raw) To: Srinivas Pandruvada, Reyad Attiyat; +Cc: linux-kernel, linux-iio On 27/05/14 16:27, Srinivas Pandruvada wrote: > On 05/26/2014 08:20 PM, Reyad Attiyat wrote: >> Added documentation for HID magnometer true/magnetic north sensor. >> --- >> Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio >> index 6e02c50..3305fe8 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-iio >> +++ b/Documentation/ABI/testing/sysfs-bus-iio >> @@ -165,6 +165,10 @@ Description: >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_raw >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_raw >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_raw >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_raw >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_raw >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_raw >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_raw > These names are very long. May be we remove work "magnetic" as there attributes only apply to magnetometer. Not necessarily true - could be a gps bearing. I'd actually argue that these are rotation measures and userspace doesn't care where they come from. See other thread for my suggestions on that. Also, I'd much rather have along and clear name for the attribute than the possibility of any confusion. Hence I've just asked Reyad to put the magnetic back in the first one ;) (in other thread). Sorry for the slow response been travelling and working nights for the last week... We might even want to introduce a 'bearing' base type. Whilst these are rotations they are referenced to a very particular location. >> KernelVersion: 2.6.35 >> Contact: linux-iio@vger.kernel.org >> Description: >> @@ -249,6 +253,10 @@ What: /sys/bus/iio/devices/iio:deviceX/in_magn_scale >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_scale >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_scale >> What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_scale >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_scale >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_scale >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_scale >> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_scale >> What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_scale >> What: /sys/bus/iio/devices/iio:deviceX/in_pressure_scale >> KernelVersion: 2.6.35 >> @@ -436,6 +444,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_thresh_rising_en >> What: /sys/.../iio:deviceX/events/in_magn_y_thresh_falling_en >> What: /sys/.../iio:deviceX/events/in_magn_z_thresh_rising_en >> What: /sys/.../iio:deviceX/events/in_magn_z_thresh_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_falling_en >> What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_rising_en >> What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_falling_en >> What: /sys/.../iio:deviceX/events/in_voltageY_thresh_rising_en >> @@ -481,6 +497,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_roc_rising_en >> What: /sys/.../iio:deviceX/events/in_magn_y_roc_falling_en >> What: /sys/.../iio:deviceX/events/in_magn_z_roc_rising_en >> What: /sys/.../iio:deviceX/events/in_magn_z_roc_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_falling_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_rising_en >> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_falling_en > Same as above. Names are very long. > > Thanks, > Srinivas >> What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_rising_en >> What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_falling_en >> What: /sys/.../iio:deviceX/events/in_voltageY_roc_rising_en >> @@ -527,6 +551,14 @@ What: /sys/.../events/in_magn_y_raw_thresh_rising_value >> What: /sys/.../events/in_magn_y_raw_thresh_falling_value >> What: /sys/.../events/in_magn_z_raw_thresh_rising_value >> What: /sys/.../events/in_magn_z_raw_thresh_falling_value >> +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_rising_value >> +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_falling_value >> +What: /sys/.../events/in_magn_north_true_raw_thresh_rising_value >> +What: /sys/.../events/in_magn_north_true_raw_thresh_falling_value >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_rising_value >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_falling_value >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_rising_value >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_falling_value >> What: /sys/.../events/in_voltageY_supply_raw_thresh_rising_value >> What: /sys/.../events/in_voltageY_supply_raw_thresh_falling_value >> What: /sys/.../events/in_voltageY_raw_thresh_rising_value >> @@ -577,6 +609,18 @@ What: /sys/.../events/in_magn_y_thresh_either_hysteresis >> What: /sys/.../events/in_magn_z_thresh_rising_hysteresis >> What: /sys/.../events/in_magn_z_thresh_falling_hysteresis >> What: /sys/.../events/in_magn_z_thresh_either_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_thresh_either_hysteresis >> +What: /sys/.../events/in_magn_north_true_thresh_rising_hysteresis >> +What: /sys/.../events/in_magn_north_true_thresh_falling_hysteresis >> +What: /sys/.../events/in_magn_north_true_thresh_either_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_hysteresis >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_either_hysteresis >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_hysteresis >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_hysteresis >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_either_hysteresis >> What: /sys/.../events/in_voltageY_thresh_rising_hysteresis >> What: /sys/.../events/in_voltageY_thresh_falling_hysteresis >> What: /sys/.../events/in_voltageY_thresh_either_hysteresis >> @@ -624,6 +668,14 @@ What: /sys/.../events/in_magn_y_raw_roc_rising_value >> What: /sys/.../events/in_magn_y_raw_roc_falling_value >> What: /sys/.../events/in_magn_z_raw_roc_rising_value >> What: /sys/.../events/in_magn_z_raw_roc_falling_value >> +What: /sys/.../events/in_magn_north_magnetic_raw_roc_rising_value >> +What: /sys/.../events/in_magn_north_magnetic_raw_roc_falling_value >> +What: /sys/.../events/in_magn_north_true_raw_roc_rising_value >> +What: /sys/.../events/in_magn_north_true_raw_roc_falling_value >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_rising_value >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_falling_value >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_rising_value >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_falling_value >> What: /sys/.../events/in_voltageY_supply_raw_roc_rising_value >> What: /sys/.../events/in_voltageY_supply_raw_roc_falling_value >> What: /sys/.../events/in_voltageY_raw_roc_rising_value >> @@ -679,6 +731,22 @@ What: /sys/.../events/in_magn_z_thresh_rising_period >> What: /sys/.../events/in_magn_z_thresh_falling_period >> What: /sys/.../events/in_magn_z_roc_rising_period >> What: /sys/.../events/in_magn_z_roc_falling_period >> +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_period >> +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_period >> +What: /sys/.../events/in_magn_north_magnetic_roc_rising_period >> +What: /sys/.../events/in_magn_north_magnetic_roc_falling_period >> +What: /sys/.../events/in_magn_north_true_thresh_rising_period >> +What: /sys/.../events/in_magn_north_true_thresh_falling_period >> +What: /sys/.../events/in_magn_north_true_roc_rising_period >> +What: /sys/.../events/in_magn_north_true_roc_falling_period >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_period >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_period >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_rising_period >> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_falling_period >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_period >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_period >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_rising_period >> +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_falling_period >> What: /sys/.../events/in_voltageY_supply_thresh_rising_period >> What: /sys/.../events/in_voltageY_supply_thresh_falling_period >> What: /sys/.../events/in_voltageY_supply_roc_rising_period >> @@ -776,6 +844,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_en >> What: /sys/.../iio:deviceX/scan_elements/in_magn_x_en >> What: /sys/.../iio:deviceX/scan_elements/in_magn_y_en >> What: /sys/.../iio:deviceX/scan_elements/in_magn_z_en >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_en >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_en >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_en >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_en >> What: /sys/.../iio:deviceX/scan_elements/in_timestamp_en >> What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en >> What: /sys/.../iio:deviceX/scan_elements/in_voltageY_en >> @@ -840,6 +912,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_index >> What: /sys/.../iio:deviceX/scan_elements/in_magn_x_index >> What: /sys/.../iio:deviceX/scan_elements/in_magn_y_index >> What: /sys/.../iio:deviceX/scan_elements/in_magn_z_index >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_index >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_index >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_index >> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_index >> What: /sys/.../iio:deviceX/scan_elements/in_incli_x_index >> What: /sys/.../iio:deviceX/scan_elements/in_incli_y_index >> What: /sys/.../iio:deviceX/scan_elements/in_timestamp_index > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] IIO: Support for True/Magnetic north 2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat 2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat @ 2014-05-27 15:34 ` Srinivas Pandruvada 2014-05-31 10:17 ` Jonathan Cameron 1 sibling, 1 reply; 9+ messages in thread From: Srinivas Pandruvada @ 2014-05-27 15:34 UTC (permalink / raw) To: Reyad Attiyat; +Cc: linux-kernel, linux-iio, jic23 Hi Reyad, On 05/26/2014 08:20 PM, Reyad Attiyat wrote: > Hey Jonathan and Srinivas, > > I have added in the needed magn_north iio sysfs attributes to the documentation. > I hope I did everything correct. > I noticed that the line length was very long as compensated is a fairly long word. > I'm thinking I could shorten some of the sysfs paths or shorten the name. > > For updating the hid-sensor-magn-3d do you have any tips on this? I'm thinking I'll need a > dynamic iio_chan array that is passed to iio_register function. It would need to > be dynamic in the sense it would only add channels if it found x, y, z, or one of > the north attributes. I'll start working on this soon. I think you mean dynamic " iio_chan_spec magn_3d_channels[]". Currently this is a constant. So we can change this to add only channel, which are available. Also your other changes must be submitted as series of patches, including the drivers using them. Thanks, Srinivas > Thank You, > Reyad Attiyat > > > > Reyad Attiyat (1): > IIO: Added iio magn_north ABI documentation > > Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] IIO: Support for True/Magnetic north 2014-05-27 15:34 ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada @ 2014-05-31 10:17 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2014-05-31 10:17 UTC (permalink / raw) To: Srinivas Pandruvada, Reyad Attiyat; +Cc: linux-kernel, linux-iio On 27/05/14 16:34, Srinivas Pandruvada wrote: > Hi Reyad, > > On 05/26/2014 08:20 PM, Reyad Attiyat wrote: >> Hey Jonathan and Srinivas, >> >> I have added in the needed magn_north iio sysfs attributes to the documentation. >> I hope I did everything correct. >> I noticed that the line length was very long as compensated is a fairly long word. >> I'm thinking I could shorten some of the sysfs paths or shorten the name. >> >> For updating the hid-sensor-magn-3d do you have any tips on this? I'm thinking I'll need a >> dynamic iio_chan array that is passed to iio_register function. It would need to >> be dynamic in the sense it would only add channels if it found x, y, z, or one of >> the north attributes. I'll start working on this soon. > > I think you mean dynamic " iio_chan_spec magn_3d_channels[]". Currently this is a > constant. So we can change this to add only channel, which are available. > > Also your other changes must be submitted as series of patches, including the drivers using them. I specifically requested that Reyad get the proposal out asap so that we could discuss it 'before' the patch series using it. Obviously it won't get merged until there is a driver using this interface, but often the interface discussion takes longer than the review of the code so best to get it going asap! > > Thanks, > Srinivas > >> Thank You, >> Reyad Attiyat >> >> >> >> Reyad Attiyat (1): >> IIO: Added iio magn_north ABI documentation >> >> Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-31 10:18 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-14 2:14 HID Sensor support for True/Magnetic North usage attributes Reyad Attiyat 2014-05-16 17:46 ` Srinivas Pandruvada 2014-05-24 10:39 ` Jonathan Cameron 2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat 2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat 2014-05-27 15:27 ` Srinivas Pandruvada 2014-05-31 10:20 ` Jonathan Cameron 2014-05-27 15:34 ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada 2014-05-31 10:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).