From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Reyad Attiyat <reyad.attiyat@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] IIO: Added iio magn_north ABI documentation
Date: Sat, 31 May 2014 11:20:32 +0100 [thread overview]
Message-ID: <5389ACF0.6080003@kernel.org> (raw)
In-Reply-To: <5384AEFE.2010804@linux.intel.com>
On 27/05/14 16:27, Srinivas Pandruvada wrote:
> On 05/26/2014 08:20 PM, Reyad Attiyat wrote:
>> Added documentation for HID magnometer true/magnetic north sensor.
>> ---
>> Documentation/ABI/testing/sysfs-bus-iio | 76 +++++++++++++++++++++++++++++++++
>> 1 file changed, 76 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index 6e02c50..3305fe8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -165,6 +165,10 @@ Description:
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_raw
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_raw
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_raw
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_raw
> These names are very long. May be we remove work "magnetic" as there attributes only apply to magnetometer.
Not necessarily true - could be a gps bearing. I'd actually argue that these are rotation measures and userspace doesn't
care where they come from. See other thread for my suggestions on that. Also, I'd much rather have along
and clear name for the attribute than the possibility of any confusion. Hence I've just asked Reyad to
put the magnetic back in the first one ;) (in other thread). Sorry for the slow response
been travelling and working nights for the last week...
We might even want to introduce a 'bearing' base type. Whilst these are rotations they are referenced
to a very particular location.
>> KernelVersion: 2.6.35
>> Contact: linux-iio@vger.kernel.org
>> Description:
>> @@ -249,6 +253,10 @@ What: /sys/bus/iio/devices/iio:deviceX/in_magn_scale
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_x_scale
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_y_scale
>> What: /sys/bus/iio/devices/iio:deviceX/in_magn_z_scale
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_scale
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_scale
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_magnetic_tilt_compensated_scale
>> +What: /sys/bus/iio/devices/iio:deviceX/in_magn_north_true_tilt_compensated_scale
>> What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_scale
>> What: /sys/bus/iio/devices/iio:deviceX/in_pressure_scale
>> KernelVersion: 2.6.35
>> @@ -436,6 +444,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_thresh_rising_en
>> What: /sys/.../iio:deviceX/events/in_magn_y_thresh_falling_en
>> What: /sys/.../iio:deviceX/events/in_magn_z_thresh_rising_en
>> What: /sys/.../iio:deviceX/events/in_magn_z_thresh_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_thresh_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_thresh_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_thresh_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_thresh_falling_en
>> What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_rising_en
>> What: /sys/.../iio:deviceX/events/in_voltageY_supply_thresh_falling_en
>> What: /sys/.../iio:deviceX/events/in_voltageY_thresh_rising_en
>> @@ -481,6 +497,14 @@ What: /sys/.../iio:deviceX/events/in_magn_y_roc_rising_en
>> What: /sys/.../iio:deviceX/events/in_magn_y_roc_falling_en
>> What: /sys/.../iio:deviceX/events/in_magn_z_roc_rising_en
>> What: /sys/.../iio:deviceX/events/in_magn_z_roc_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_roc_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_roc_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_magnetic_tilt_compensated_roc_falling_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_rising_en
>> +What: /sys/.../iio:deviceX/events/in_magn_north_true_tilt_compensated_roc_falling_en
> Same as above. Names are very long.
>
> Thanks,
> Srinivas
>> What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_rising_en
>> What: /sys/.../iio:deviceX/events/in_voltageY_supply_roc_falling_en
>> What: /sys/.../iio:deviceX/events/in_voltageY_roc_rising_en
>> @@ -527,6 +551,14 @@ What: /sys/.../events/in_magn_y_raw_thresh_rising_value
>> What: /sys/.../events/in_magn_y_raw_thresh_falling_value
>> What: /sys/.../events/in_magn_z_raw_thresh_rising_value
>> What: /sys/.../events/in_magn_z_raw_thresh_falling_value
>> +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_rising_value
>> +What: /sys/.../events/in_magn_north_magnetic_raw_thresh_falling_value
>> +What: /sys/.../events/in_magn_north_true_raw_thresh_rising_value
>> +What: /sys/.../events/in_magn_north_true_raw_thresh_falling_value
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_rising_value
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_thresh_falling_value
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_rising_value
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_thresh_falling_value
>> What: /sys/.../events/in_voltageY_supply_raw_thresh_rising_value
>> What: /sys/.../events/in_voltageY_supply_raw_thresh_falling_value
>> What: /sys/.../events/in_voltageY_raw_thresh_rising_value
>> @@ -577,6 +609,18 @@ What: /sys/.../events/in_magn_y_thresh_either_hysteresis
>> What: /sys/.../events/in_magn_z_thresh_rising_hysteresis
>> What: /sys/.../events/in_magn_z_thresh_falling_hysteresis
>> What: /sys/.../events/in_magn_z_thresh_either_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_thresh_either_hysteresis
>> +What: /sys/.../events/in_magn_north_true_thresh_rising_hysteresis
>> +What: /sys/.../events/in_magn_north_true_thresh_falling_hysteresis
>> +What: /sys/.../events/in_magn_north_true_thresh_either_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_hysteresis
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_either_hysteresis
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_hysteresis
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_hysteresis
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_either_hysteresis
>> What: /sys/.../events/in_voltageY_thresh_rising_hysteresis
>> What: /sys/.../events/in_voltageY_thresh_falling_hysteresis
>> What: /sys/.../events/in_voltageY_thresh_either_hysteresis
>> @@ -624,6 +668,14 @@ What: /sys/.../events/in_magn_y_raw_roc_rising_value
>> What: /sys/.../events/in_magn_y_raw_roc_falling_value
>> What: /sys/.../events/in_magn_z_raw_roc_rising_value
>> What: /sys/.../events/in_magn_z_raw_roc_falling_value
>> +What: /sys/.../events/in_magn_north_magnetic_raw_roc_rising_value
>> +What: /sys/.../events/in_magn_north_magnetic_raw_roc_falling_value
>> +What: /sys/.../events/in_magn_north_true_raw_roc_rising_value
>> +What: /sys/.../events/in_magn_north_true_raw_roc_falling_value
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_rising_value
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_raw_roc_falling_value
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_rising_value
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_raw_roc_falling_value
>> What: /sys/.../events/in_voltageY_supply_raw_roc_rising_value
>> What: /sys/.../events/in_voltageY_supply_raw_roc_falling_value
>> What: /sys/.../events/in_voltageY_raw_roc_rising_value
>> @@ -679,6 +731,22 @@ What: /sys/.../events/in_magn_z_thresh_rising_period
>> What: /sys/.../events/in_magn_z_thresh_falling_period
>> What: /sys/.../events/in_magn_z_roc_rising_period
>> What: /sys/.../events/in_magn_z_roc_falling_period
>> +What: /sys/.../events/in_magn_north_magnetic_thresh_rising_period
>> +What: /sys/.../events/in_magn_north_magnetic_thresh_falling_period
>> +What: /sys/.../events/in_magn_north_magnetic_roc_rising_period
>> +What: /sys/.../events/in_magn_north_magnetic_roc_falling_period
>> +What: /sys/.../events/in_magn_north_true_thresh_rising_period
>> +What: /sys/.../events/in_magn_north_true_thresh_falling_period
>> +What: /sys/.../events/in_magn_north_true_roc_rising_period
>> +What: /sys/.../events/in_magn_north_true_roc_falling_period
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_rising_period
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_thresh_falling_period
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_rising_period
>> +What: /sys/.../events/in_magn_north_magnetic_tilt_compensated_roc_falling_period
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_rising_period
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_thresh_falling_period
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_rising_period
>> +What: /sys/.../events/in_magn_north_true_tilt_compensated_roc_falling_period
>> What: /sys/.../events/in_voltageY_supply_thresh_rising_period
>> What: /sys/.../events/in_voltageY_supply_thresh_falling_period
>> What: /sys/.../events/in_voltageY_supply_roc_rising_period
>> @@ -776,6 +844,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_en
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_x_en
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_y_en
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_z_en
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_en
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_en
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_en
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_en
>> What: /sys/.../iio:deviceX/scan_elements/in_timestamp_en
>> What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en
>> What: /sys/.../iio:deviceX/scan_elements/in_voltageY_en
>> @@ -840,6 +912,10 @@ What: /sys/.../iio:deviceX/scan_elements/in_anglvel_z_index
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_x_index
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_y_index
>> What: /sys/.../iio:deviceX/scan_elements/in_magn_z_index
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_index
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_index
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_magnetic_tilt_compensated_index
>> +What: /sys/.../iio:deviceX/scan_elements/in_magn_north_true_tilt_compensated_index
>> What: /sys/.../iio:deviceX/scan_elements/in_incli_x_index
>> What: /sys/.../iio:deviceX/scan_elements/in_incli_y_index
>> What: /sys/.../iio:deviceX/scan_elements/in_timestamp_index
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-31 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 2:14 HID Sensor support for True/Magnetic North usage attributes Reyad Attiyat
2014-05-16 17:46 ` Srinivas Pandruvada
2014-05-24 10:39 ` Jonathan Cameron
2014-05-27 3:20 ` [PATCH] IIO: Support for True/Magnetic north Reyad Attiyat
2014-05-27 3:20 ` [PATCH] IIO: Added iio magn_north ABI documentation Reyad Attiyat
2014-05-27 15:27 ` Srinivas Pandruvada
2014-05-31 10:20 ` Jonathan Cameron [this message]
2014-05-27 15:34 ` [PATCH] IIO: Support for True/Magnetic north Srinivas Pandruvada
2014-05-31 10:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5389ACF0.6080003@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reyad.attiyat@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).