From: Jonathan Cameron <jic23@kernel.org>
To: Federico Di Pierro <nierro92@gmail.com>,
gregkh@linuxfoundation.org, jg1.han@samsung.com,
sachin.kamat@linaro.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c
Date: Mon, 02 Jun 2014 18:44:37 +0100 [thread overview]
Message-ID: <538CB805.8030303@kernel.org> (raw)
In-Reply-To: <538CAEBD.5040501@gmail.com>
On 02/06/14 18:05, Federico Di Pierro wrote:
> Hi!
> This is my latest task of the eudyptula challenge.
> Just a very small patch! It fixes 3 little coding style problems.
> I'm using linux-next.
Fair enough, but you need to spend a little time working
on the 'how' of your patch submission.
See Documentation/SubmittingPatches and repost the patch according
to those guidelines.
Also at a quick glance, unless I am very bored I'm unlikely to take
such a minor white space and bracket adjustment patch. If it were
part of a bigger series doing something more interesting I'd be
more interested.
If you want to approach this driver, then feel free but there are
many more major issues within it to be looked at such as ABI
compliance. See Documentation/ABI/testing/sysfs-bus-iio and friends
and compare the driver with them. Off the top of my head I can't
remember how bad this driver is but I doubt everything is well
documented.
Don't feel disheartened, as I would be happy to see more substantial
cleanup patches from you as part of the challenge or otherwise.
Good luck,
Jonathan
next prev parent reply other threads:[~2014-06-02 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:05 [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c Federico Di Pierro
2014-06-02 17:14 ` Joe Perches
2014-06-02 17:21 ` Jianyu Zhan
2014-06-02 17:44 ` Jonathan Cameron [this message]
2014-06-02 19:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CB805.8030303@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nierro92@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).