From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 11/12] staging:iio-trig-periodic-rtc: Cleanup
Date: Mon, 09 Jun 2014 21:14:29 +0100 [thread overview]
Message-ID: <539615A5.7080105@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.01.1406092203120.17148@pmeerw.net>
On 09/06/14 21:04, Peter Meerwald wrote:
> Hello Jonathan,
>
>>> Fix extra space in module description
>>> Silence output about trigger frequency when trigger gets enabled/disabled
>>> Add dash to make trigger name look nicer (periodicrtc0 -> periodic-rtc0)
>> All good bar the last one. That's an ABI change unfortunately.
>> Whilst I agree the - would have been nice we are stuck with it for now.
>> (of course I'm aiming to drop this driver fairly soon anyway which I
>> guess is a rather larger ABI change, but lets be tidy until then!)
>
> what's going to happen with periodic-rtc?
> I noticed that the proposed hrtimer trigger hasn't been merged yet?
You hit the nail on the head. Hrtimer is more general purpose
and IIRC some periodic rtc stuff was implemented with hrtimers now
anyway.
So when hrtimer is in place I'd propose we officially deprecate
periodic-rtc and kill it off after a cycle or two. It was original
a dirty hack to allow me to use some spare timers on the pxa27x chips.
J
>
> regards, p.
>
>>> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
>>> b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
>>> index 38ecb4b..7283e50 100644
>>> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
>>> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
>>> @@ -33,7 +33,7 @@ static int iio_trig_periodic_rtc_set_state(struct
>>> iio_trigger *trig, bool state)
>>> struct iio_prtc_trigger_info *trig_info =
>>> iio_trigger_get_drvdata(trig);
>>> if (trig_info->frequency == 0)
>>> return -EINVAL;
>>> - dev_info(&trig_info->rtc->dev, "trigger frequency is %d\n",
>>> + dev_dbg(&trig_info->rtc->dev, "trigger frequency is %d\n",
>>> trig_info->frequency);
>>> return rtc_irq_set_state(trig_info->rtc, &trig_info->task, state);
>>> }
>>> @@ -113,7 +113,7 @@ static int iio_trig_periodic_rtc_probe(struct
>>> platform_device *dev)
>>> for (i = 0;; i++) {
>>> if (pdata[i] == NULL)
>>> break;
>>> - trig = iio_trigger_alloc("periodic%s", pdata[i]);
>>> + trig = iio_trigger_alloc("periodic-%s", pdata[i]);
>>> if (!trig) {
>>> ret = -ENOMEM;
>>> goto error_free_completed_registrations;
>>> @@ -128,8 +128,7 @@ static int iio_trig_periodic_rtc_probe(struct
>>> platform_device *dev)
>>> iio_trigger_set_drvdata(trig, trig_info);
>>> trig->ops = &iio_prtc_trigger_ops;
>>> /* RTC access */
>>> - trig_info->rtc
>>> - = rtc_class_open(pdata[i]);
>>> + trig_info->rtc = rtc_class_open(pdata[i]);
>>> if (trig_info->rtc == NULL) {
>>> ret = -EINVAL;
>>> goto error_free_trig_info;
>>> @@ -199,5 +198,5 @@ static struct platform_driver
>>> iio_trig_periodic_rtc_driver = {
>>> module_platform_driver(iio_trig_periodic_rtc_driver);
>>>
>>> MODULE_AUTHOR("Jonathan Cameron <jic23@kernel.org>");
>>> -MODULE_DESCRIPTION("Periodic realtime clock trigger for the iio
>>> subsystem");
>>> +MODULE_DESCRIPTION("Periodic realtime clock trigger for the iio
>>> subsystem");
>>> MODULE_LICENSE("GPL v2");
>>>
>>
>
next prev parent reply other threads:[~2014-06-09 20:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 15:42 [PATCH 00/12] misc IIO cleanup Peter Meerwald
2014-06-07 15:42 ` [PATCH 01/12] iio:adc:ad5791: Use BIT() and GENMASK() macros Peter Meerwald
2014-06-09 11:58 ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 02/12] iio:adc:ad5504: " Peter Meerwald
2014-06-07 15:42 ` [PATCH 03/12] iio:adc:ad7887: " Peter Meerwald
2014-06-09 11:59 ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 04/12] iio:adc:ad7476: Use GENMASK() macro Peter Meerwald
2014-06-09 12:00 ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 05/12] iio:adc:ad7298: Use BIT() and GENMASK() macros Peter Meerwald
2014-06-09 12:00 ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 06/12] iio: Move documentation of iio-trig-sysfs to ABI Peter Meerwald
2014-06-09 19:58 ` Jonathan Cameron
2014-06-07 15:42 ` [PATCH 07/12] staging:iio: Update iio_event_monitor program Peter Meerwald
2014-06-07 15:42 ` [PATCH 08/12] staging:iio: Fix iio_utils.h function prototypes Peter Meerwald
2014-06-07 15:42 ` [PATCH 09/12] staging:iio: Fix mention of INDIO_RING_TRIGGERED to INDIO_BUFFER_TRIGGERED Peter Meerwald
2014-06-07 15:42 ` [PATCH 10/12] staging:iio: Fix error handling in generic_buffer example Peter Meerwald
2014-06-07 15:42 ` [PATCH 11/12] staging:iio-trig-periodic-rtc: Cleanup Peter Meerwald
2014-06-09 20:02 ` Jonathan Cameron
2014-06-09 20:04 ` Peter Meerwald
2014-06-09 20:14 ` Jonathan Cameron [this message]
2014-06-07 15:42 ` [PATCH 12/12] staging:iio-trig-periodic-rtc: Allow to reset frequency to 0 Peter Meerwald
2014-06-09 20:05 ` [PATCH 00/12] misc IIO cleanup Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539615A5.7080105@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).