From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.samsung.com ([203.254.224.33]:53437 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933839AbaFRIvg (ORCPT ); Wed, 18 Jun 2014 04:51:36 -0400 Message-id: <53A15315.6060304@samsung.com> Date: Wed, 18 Jun 2014 17:51:33 +0900 From: Chanwoo Choi MIME-version: 1.0 To: Tomasz Figa Cc: jic23@kernel.org, ch.naveen@samsung.com, t.figa@samsung.com, kgene.kim@samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rdunlap@infradead.org, sachin.kamat@linaro.org, linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCHv4 4/4] ARM: dts: Fix wrong compatible string for Exynos3250 ADC References: <1403058061-24271-1-git-send-email-cw00.choi@samsung.com> <1403058061-24271-5-git-send-email-cw00.choi@samsung.com> <53A14FAC.3050700@gmail.com> In-reply-to: <53A14FAC.3050700@gmail.com> Content-type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Hi Tomasz, On 06/18/2014 05:37 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06.2014 04:21, Chanwoo Choi wrote: >> This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC >> need to control only special clock for ADC. Exynos SoC except for Exynos3250 >> has not included special clock for ADC. The exynos ADC driver can control >> special clock if compatible string is 'exynos3250-adc-v2'. >> >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 6c1fb67..107dc44 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -414,10 +414,10 @@ >> }; >> >> adc: adc@126C0000 { >> - compatible = "samsung,exynos-adc-v3"; >> + compatible = "samsung,exynos3250-adc-v2"; >> reg = <0x126C0000 0x100>, <0x10020718 0x4>; >> interrupts = <0 137 0>; >> - clock-names = "adc", "sclk_tsadc"; >> + clock-names = "adc", "sclk_adc"; > > So, is it "sclk_adc" or "sclk_tsadc"? The code uses the former, while > the documentation mentions the latter. Please fix this. OK, I'll fix it by using 'sclk_adc' clock name. Best Regards, Chanwoo Choi