* [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table. @ 2014-02-14 14:25 Marek Belisko 2014-02-14 14:25 ` [PATCH 2/2] Documentation: iio: Extend documentation for hmc5843 bindings Marek Belisko 2014-02-18 10:40 ` [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Jonathan Cameron 0 siblings, 2 replies; 6+ messages in thread From: Marek Belisko @ 2014-02-14 14:25 UTC (permalink / raw) To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, rob, jic23 Cc: pmeerw, devicetree, linux-doc, linux-kernel, linux-iio, devel, hns, Marek Belisko Signed-off-by: Marek Belisko <marek@goldelico.com> --- drivers/staging/iio/magnetometer/hmc5843.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c index d4f4dd9..f595fdc 100644 --- a/drivers/staging/iio/magnetometer/hmc5843.c +++ b/drivers/staging/iio/magnetometer/hmc5843.c @@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = { MODULE_DEVICE_TABLE(i2c, hmc5843_id); static const struct of_device_id hmc5843_of_match[] = { - { .compatible = "honeywell,hmc5843" }, + { .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID }, + { .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID }, + { .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID }, {} }; MODULE_DEVICE_TABLE(of, hmc5843_of_match); -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Documentation: iio: Extend documentation for hmc5843 bindings. 2014-02-14 14:25 [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Marek Belisko @ 2014-02-14 14:25 ` Marek Belisko 2014-02-18 10:40 ` [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Jonathan Cameron 1 sibling, 0 replies; 6+ messages in thread From: Marek Belisko @ 2014-02-14 14:25 UTC (permalink / raw) To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, rob, jic23 Cc: pmeerw, devicetree, linux-doc, linux-kernel, linux-iio, devel, hns, Marek Belisko Signed-off-by: Marek Belisko <marek@goldelico.com> --- Documentation/devicetree/bindings/iio/magnetometer/hmc5843.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/magnetometer/hmc5843.txt b/Documentation/devicetree/bindings/iio/magnetometer/hmc5843.txt index 90d5f34..b8cbdd5 100644 --- a/Documentation/devicetree/bindings/iio/magnetometer/hmc5843.txt +++ b/Documentation/devicetree/bindings/iio/magnetometer/hmc5843.txt @@ -3,6 +3,9 @@ Required properties: - compatible : should be "honeywell,hmc5843" + Other models which are supported with driver are: + "honeywell,hmc5883" + "honeywell,hmc5883l" - reg : the I2C address of the magnetometer - typically 0x1e Optional properties: -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table. 2014-02-14 14:25 [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Marek Belisko 2014-02-14 14:25 ` [PATCH 2/2] Documentation: iio: Extend documentation for hmc5843 bindings Marek Belisko @ 2014-02-18 10:40 ` Jonathan Cameron 2014-02-18 20:35 ` Belisko Marek 1 sibling, 1 reply; 6+ messages in thread From: Jonathan Cameron @ 2014-02-18 10:40 UTC (permalink / raw) To: Marek Belisko, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, rob Cc: pmeerw, devicetree, linux-doc, linux-kernel, linux-iio, devel, hns On 14/02/14 14:25, Marek Belisko wrote: > Signed-off-by: Marek Belisko <marek@goldelico.com> I wonder how this got missed. However, for those data elements to be useful, you will need to read them somewhere in the driver I think.... (if there is any magic that puts this in the relevant i2c locations then point it out to me!) > --- > drivers/staging/iio/magnetometer/hmc5843.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c > index d4f4dd9..f595fdc 100644 > --- a/drivers/staging/iio/magnetometer/hmc5843.c > +++ b/drivers/staging/iio/magnetometer/hmc5843.c > @@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = { > MODULE_DEVICE_TABLE(i2c, hmc5843_id); > > static const struct of_device_id hmc5843_of_match[] = { > - { .compatible = "honeywell,hmc5843" }, > + { .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID }, > + { .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID }, > + { .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID }, > {} > }; > MODULE_DEVICE_TABLE(of, hmc5843_of_match); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table. 2014-02-18 10:40 ` [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Jonathan Cameron @ 2014-02-18 20:35 ` Belisko Marek 2014-06-27 20:48 ` Belisko Marek 0 siblings, 1 reply; 6+ messages in thread From: Belisko Marek @ 2014-02-18 20:35 UTC (permalink / raw) To: Jonathan Cameron Cc: Rob Herring, Pawel Moll, Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala, Rob Landley, Peter Meerwald, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, LKML, linux-iio, devel, Dr. H. Nikolaus Schaller Hi Jonathan, On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron <jic23@kernel.org> wrote: > On 14/02/14 14:25, Marek Belisko wrote: >> >> Signed-off-by: Marek Belisko <marek@goldelico.com> > > I wonder how this got missed. However, for those data elements to be > useful, you will > need to read them somewhere in the driver I think.... (if there is any magic > that puts this in the relevant i2c locations then point it out to me!) There is a table called hmc5843_chip_info_tbl which contains entries for all models which this driver can handle. And magic is that correct model variant is set probe function: line: idata->variant = &hmc5843_chip_info_tbl[id->driver_data]; (id->driver_data contains model value). > >> --- >> drivers/staging/iio/magnetometer/hmc5843.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c >> b/drivers/staging/iio/magnetometer/hmc5843.c >> index d4f4dd9..f595fdc 100644 >> --- a/drivers/staging/iio/magnetometer/hmc5843.c >> +++ b/drivers/staging/iio/magnetometer/hmc5843.c >> @@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = { >> MODULE_DEVICE_TABLE(i2c, hmc5843_id); >> >> static const struct of_device_id hmc5843_of_match[] = { >> - { .compatible = "honeywell,hmc5843" }, >> + { .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID }, >> + { .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID }, >> + { .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID >> }, >> {} >> }; >> MODULE_DEVICE_TABLE(of, hmc5843_of_match); >> > BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table. 2014-02-18 20:35 ` Belisko Marek @ 2014-06-27 20:48 ` Belisko Marek 2014-06-29 10:57 ` Jonathan Cameron 0 siblings, 1 reply; 6+ messages in thread From: Belisko Marek @ 2014-06-27 20:48 UTC (permalink / raw) To: Jonathan Cameron Cc: Rob Herring, Pawel Moll, Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala, Rob Landley, Peter Meerwald, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, LKML, linux-iio, devel, Dr. H. Nikolaus Schaller PIng? Jonathan do you have any objections to this approach? Can you please pick it? Thx. On Tue, Feb 18, 2014 at 9:35 PM, Belisko Marek <marek.belisko@gmail.com> wrote: > Hi Jonathan, > > On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron <jic23@kernel.org> wrote: >> On 14/02/14 14:25, Marek Belisko wrote: >>> >>> Signed-off-by: Marek Belisko <marek@goldelico.com> >> >> I wonder how this got missed. However, for those data elements to be >> useful, you will >> need to read them somewhere in the driver I think.... (if there is any magic >> that puts this in the relevant i2c locations then point it out to me!) > There is a table called hmc5843_chip_info_tbl which contains entries > for all models > which this driver can handle. And magic is that correct model variant > is set probe function: > line: idata->variant = &hmc5843_chip_info_tbl[id->driver_data]; > (id->driver_data contains model value). >> >>> --- >>> drivers/staging/iio/magnetometer/hmc5843.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c >>> b/drivers/staging/iio/magnetometer/hmc5843.c >>> index d4f4dd9..f595fdc 100644 >>> --- a/drivers/staging/iio/magnetometer/hmc5843.c >>> +++ b/drivers/staging/iio/magnetometer/hmc5843.c >>> @@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = { >>> MODULE_DEVICE_TABLE(i2c, hmc5843_id); >>> >>> static const struct of_device_id hmc5843_of_match[] = { >>> - { .compatible = "honeywell,hmc5843" }, >>> + { .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID }, >>> + { .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID }, >>> + { .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID >>> }, >>> {} >>> }; >>> MODULE_DEVICE_TABLE(of, hmc5843_of_match); >>> >> > > BR, > > marek > > -- > as simple and primitive as possible > ------------------------------------------------- > Marek Belisko - OPEN-NANDRA > Freelance Developer > > Ruska Nova Ves 219 | Presov, 08005 Slovak Republic > Tel: +421 915 052 184 > skype: marekwhite > twitter: #opennandra > web: http://open-nandra.com BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table. 2014-06-27 20:48 ` Belisko Marek @ 2014-06-29 10:57 ` Jonathan Cameron 0 siblings, 0 replies; 6+ messages in thread From: Jonathan Cameron @ 2014-06-29 10:57 UTC (permalink / raw) To: Belisko Marek Cc: Rob Herring, Pawel Moll, Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala, Rob Landley, Peter Meerwald, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, LKML, linux-iio, devel, Dr. H. Nikolaus Schaller On 27/06/14 21:48, Belisko Marek wrote: > PIng? Jonathan do you have any objections to this approach? Can you > please pick it? Thx. Sorry, this one dropped through the cracks. Applied to the togreg branch of iio.git along with the documentation patch that goes with it. Jonathan > > On Tue, Feb 18, 2014 at 9:35 PM, Belisko Marek <marek.belisko@gmail.com> wrote: >> Hi Jonathan, >> >> On Tue, Feb 18, 2014 at 11:40 AM, Jonathan Cameron <jic23@kernel.org> wrote: >>> On 14/02/14 14:25, Marek Belisko wrote: >>>> >>>> Signed-off-by: Marek Belisko <marek@goldelico.com> >>> >>> I wonder how this got missed. However, for those data elements to be >>> useful, you will >>> need to read them somewhere in the driver I think.... (if there is any magic >>> that puts this in the relevant i2c locations then point it out to me!) >> There is a table called hmc5843_chip_info_tbl which contains entries >> for all models >> which this driver can handle. And magic is that correct model variant >> is set probe function: >> line: idata->variant = &hmc5843_chip_info_tbl[id->driver_data]; >> (id->driver_data contains model value). >>> >>>> --- >>>> drivers/staging/iio/magnetometer/hmc5843.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c >>>> b/drivers/staging/iio/magnetometer/hmc5843.c >>>> index d4f4dd9..f595fdc 100644 >>>> --- a/drivers/staging/iio/magnetometer/hmc5843.c >>>> +++ b/drivers/staging/iio/magnetometer/hmc5843.c >>>> @@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = { >>>> MODULE_DEVICE_TABLE(i2c, hmc5843_id); >>>> >>>> static const struct of_device_id hmc5843_of_match[] = { >>>> - { .compatible = "honeywell,hmc5843" }, >>>> + { .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID }, >>>> + { .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID }, >>>> + { .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID >>>> }, >>>> {} >>>> }; >>>> MODULE_DEVICE_TABLE(of, hmc5843_of_match); >>>> >>> >> >> BR, >> >> marek >> >> -- >> as simple and primitive as possible >> ------------------------------------------------- >> Marek Belisko - OPEN-NANDRA >> Freelance Developer >> >> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic >> Tel: +421 915 052 184 >> skype: marekwhite >> twitter: #opennandra >> web: http://open-nandra.com > > BR, > > marek > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-29 10:55 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-14 14:25 [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Marek Belisko 2014-02-14 14:25 ` [PATCH 2/2] Documentation: iio: Extend documentation for hmc5843 bindings Marek Belisko 2014-02-18 10:40 ` [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table Jonathan Cameron 2014-02-18 20:35 ` Belisko Marek 2014-06-27 20:48 ` Belisko Marek 2014-06-29 10:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).