linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Federico Di Pierro <nierro92@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jingoo Han <jg1.han@samsung.com>,
	Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: iio: Coding style issues fix.
Date: Sun, 29 Jun 2014 14:37:49 +0100	[thread overview]
Message-ID: <53B016AD.3020008@kernel.org> (raw)
In-Reply-To: <1404034862-5789-1-git-send-email-nierro92@gmail.com>

On 29/06/14 10:41, Federico Di Pierro wrote:
> Fix some little style issues in drivers/staging/iio/frequency/ad9832.c .
> This is my latest task of the eudyptula challenge (third attempt!)
>
> Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
I'd have preferred more meaty work on this driver, but I guess every
little bit helps...

Applied to the togreg branch of iio.git

Thanks,


> ---
>   drivers/staging/iio/frequency/ad9832.c | 14 ++++++--------
>   1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index c7d0307..b7c8351 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -57,7 +57,7 @@ static int ad9832_write_frequency(struct ad9832_state *st,
>   }
>
>   static int ad9832_write_phase(struct ad9832_state *st,
> -				  unsigned long addr, unsigned long phase)
> +			      unsigned long addr, unsigned long phase)
>   {
>   	if (phase > (1 << AD9832_PHASE_BITS))
>   		return -EINVAL;
> @@ -72,10 +72,8 @@ static int ad9832_write_phase(struct ad9832_state *st,
>   	return spi_sync(st->spi, &st->phase_msg);
>   }
>
> -static ssize_t ad9832_write(struct device *dev,
> -		struct device_attribute *attr,
> -		const char *buf,
> -		size_t len)
> +static ssize_t ad9832_write(struct device *dev, struct device_attribute *attr,
> +			    const char *buf, size_t len)
>   {
>   	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>   	struct ad9832_state *st = iio_priv(indio_dev);
> @@ -109,11 +107,11 @@ static ssize_t ad9832_write(struct device *dev,
>   		ret = spi_sync(st->spi, &st->msg);
>   		break;
>   	case AD9832_FREQ_SYM:
> -		if (val == 1)
> +		if (val == 1) {
>   			st->ctrl_fp |= AD9832_FREQ;
> -		else if (val == 0)
> +		} else if (val == 0) {
>   			st->ctrl_fp &= ~AD9832_FREQ;
> -		else {
> +		} else {
>   			ret = -EINVAL;
>   			break;
>   		}
>


      reply	other threads:[~2014-06-29 13:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29  9:41 [PATCH 1/1] staging: iio: Coding style issues fix Federico Di Pierro
2014-06-29 13:37 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B016AD.3020008@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nierro92@gmail.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).