[PATCH 1/5] iio: adis16400: Remove unused variable

[PATCH 1/5] iio: adis16400: Remove unused variable

[Sachin Kamat]

'rx' is not used in this function. Remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/iio/imu/adis16400_buffer.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/imu/adis16400_buffer.c b/drivers/iio/imu/adis16400_buffer.c
index f2cf829..6e727ff 100644
--- a/drivers/iio/imu/adis16400_buffer.c
+++ b/drivers/iio/imu/adis16400_buffer.c
@@ -18,7 +18,7 @@ int adis16400_update_scan_mode(struct iio_dev *indio_dev,
 {
 	struct adis16400_state *st = iio_priv(indio_dev);
 	struct adis *adis = &st->adis;
-	uint16_t *tx, *rx;
+	uint16_t *tx;
 
 	if (st->variant->flags & ADIS16400_NO_BURST)
 		return adis_update_scan_mode(indio_dev, scan_mask);
@@ -35,7 +35,6 @@ int adis16400_update_scan_mode(struct iio_dev *indio_dev,
 	if (!adis->buffer)
 		return -ENOMEM;
 
-	rx = adis->buffer;
 	tx = adis->buffer + indio_dev->scan_bytes;
 
 	tx[0] = ADIS_READ_REG(ADIS16400_GLOB_CMD);
-- 
1.7.9.5

[PATCH 2/5] iio: ad5624r_spi: Remove redundant variable

[Sachin Kamat]

By re-arranging the code, 'ret' can be removed from this
function.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Barry Song <21cnbao@gmail.com>
---
 drivers/iio/dac/ad5624r_spi.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/iio/dac/ad5624r_spi.c b/drivers/iio/dac/ad5624r_spi.c
index e8199cc..61bb9d4 100644
--- a/drivers/iio/dac/ad5624r_spi.c
+++ b/drivers/iio/dac/ad5624r_spi.c
@@ -67,7 +67,6 @@ static int ad5624r_write_raw(struct iio_dev *indio_dev,
 			       long mask)
 {
 	struct ad5624r_state *st = iio_priv(indio_dev);
-	int ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
@@ -79,10 +78,8 @@ static int ad5624r_write_raw(struct iio_dev *indio_dev,
 				chan->address, val,
 				chan->scan_type.shift);
 	default:
-		ret = -EINVAL;
+		return -EINVAL;
 	}
-
-	return -EINVAL;
 }
 
 static const char * const ad5624r_powerdown_modes[] = {
-- 
1.7.9.5

Re: [PATCH 2/5] iio: ad5624r_spi: Remove redundant variable

[Lars-Peter Clausen]

On 07/03/2014 08:38 AM, Sachin Kamat wrote:
> By re-arranging the code, 'ret' can be removed from this
> function.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Barry Song <21cnbao@gmail.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

Re: [PATCH 2/5] iio: ad5624r_spi: Remove redundant variable

[Jonathan Cameron]

On 03/07/14 08:24, Lars-Peter Clausen wrote:
> On 07/03/2014 08:38 AM, Sachin Kamat wrote:
>> By re-arranging the code, 'ret' can be removed from this
>> function.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> Cc: Barry Song <21cnbao@gmail.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] iio: ad5504: Remove redundant variable

[Sachin Kamat]

By re-arranging the code, 'ret' can be removed from this
function.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
---
 drivers/iio/dac/ad5504.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index c917dd2..581ec14 100644
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -125,7 +125,6 @@ static int ad5504_write_raw(struct iio_dev *indio_dev,
 			       long mask)
 {
 	struct ad5504_state *st = iio_priv(indio_dev);
-	int ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
@@ -134,10 +133,8 @@ static int ad5504_write_raw(struct iio_dev *indio_dev,
 
 		return ad5504_spi_write(st, chan->address, val);
 	default:
-		ret = -EINVAL;
+		return -EINVAL;
 	}
-
-	return -EINVAL;
 }
 
 static const char * const ad5504_powerdown_modes[] = {
-- 
1.7.9.5

Re: [PATCH 3/5] iio: ad5504: Remove redundant variable

[Lars-Peter Clausen]

On 07/03/2014 08:38 AM, Sachin Kamat wrote:
> By re-arranging the code, 'ret' can be removed from this
> function.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

Re: [PATCH 3/5] iio: ad5504: Remove redundant variable

[Jonathan Cameron]

On 03/07/14 08:24, Lars-Peter Clausen wrote:
> On 07/03/2014 08:38 AM, Sachin Kamat wrote:
>> By re-arranging the code, 'ret' can be removed from this
>> function.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

Thanks,
>
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] iio: ad5686: Remove redundant variable

[Sachin Kamat]

‘regdone’ is not used in the function. Remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
---
 drivers/iio/dac/ad5686.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index 17aca4d..f57562a 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -313,7 +313,7 @@ static int ad5686_probe(struct spi_device *spi)
 {
 	struct ad5686_state *st;
 	struct iio_dev *indio_dev;
-	int ret, regdone = 0, voltage_uv = 0;
+	int ret, voltage_uv = 0;
 
 	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
 	if (indio_dev == NULL)
@@ -355,7 +355,6 @@ static int ad5686_probe(struct spi_device *spi)
 	indio_dev->channels = st->chip_info->channel;
 	indio_dev->num_channels = AD5686_DAC_CHANNELS;
 
-	regdone = 1;
 	ret = ad5686_spi_write(st, AD5686_CMD_INTERNAL_REFER_SETUP, 0,
 				!!voltage_uv, 0);
 	if (ret)
-- 
1.7.9.5

Re: [PATCH 4/5] iio: ad5686: Remove redundant variable

[Lars-Peter Clausen]

On 07/03/2014 08:38 AM, Sachin Kamat wrote:
> ‘regdone’ is not used in the function. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Re: [PATCH 4/5] iio: ad5686: Remove redundant variable

[Jonathan Cameron]

On 03/07/14 08:25, Lars-Peter Clausen wrote:
> On 07/03/2014 08:38 AM, Sachin Kamat wrote:
>> ‘regdone’ is not used in the function. Remove it.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
Applied to the togreg branch of iio.git

Thanks,

[PATCH 5/5] iio: xilinx-xadc: Remove unused variable

[Sachin Kamat]

'offset’ is not used in the function. Remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Lars-Peter Clauen <lars@metafoo.de>
Cc: Michal Simek <michal.simek@xilinx.com>
---
 drivers/iio/adc/xilinx-xadc-events.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/iio/adc/xilinx-xadc-events.c b/drivers/iio/adc/xilinx-xadc-events.c
index 3e7f0d7..edcf3aa 100644
--- a/drivers/iio/adc/xilinx-xadc-events.c
+++ b/drivers/iio/adc/xilinx-xadc-events.c
@@ -31,17 +31,11 @@ static const struct iio_chan_spec *xadc_event_to_channel(
 static void xadc_handle_event(struct iio_dev *indio_dev, unsigned int event)
 {
 	const struct iio_chan_spec *chan;
-	unsigned int offset;
 
 	/* Temperature threshold error, we don't handle this yet */
 	if (event == 0)
 		return;
 
-	if (event < 4)
-		offset = event;
-	else
-		offset = event + 4;
-
 	chan = xadc_event_to_channel(indio_dev, event);
 
 	if (chan->type == IIO_TEMP) {
-- 
1.7.9.5

Re: [PATCH 5/5] iio: xilinx-xadc: Remove unused variable

[Lars-Peter Clausen]

On 07/03/2014 08:38 AM, Sachin Kamat wrote:
> 'offset’ is not used in the function. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Lars-Peter Clauen <lars@metafoo.de>
> Cc: Michal Simek <michal.simek@xilinx.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

Re: [PATCH 5/5] iio: xilinx-xadc: Remove unused variable

[Jonathan Cameron]

On 03/07/14 08:25, Lars-Peter Clausen wrote:
> On 07/03/2014 08:38 AM, Sachin Kamat wrote:
>> 'offset’ is not used in the function. Remove it.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> Cc: Lars-Peter Clauen <lars@metafoo.de>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
Applied to the togreg branch of iio.git

Thanks,

Re: [PATCH 1/5] iio: adis16400: Remove unused variable

[Lars-Peter Clausen]

On 07/03/2014 08:38 AM, Sachin Kamat wrote:
> 'rx' is not used in this function. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

Re: [PATCH 1/5] iio: adis16400: Remove unused variable

[Jonathan Cameron]

On 03/07/14 08:23, Lars-Peter Clausen wrote:
> On 07/03/2014 08:38 AM, Sachin Kamat wrote:
>> 'rx' is not used in this function. Remove it.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> Cc: Lars-Peter Clausen <lars@metafoo.de>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
Applied to the togreg branch of iio.git

Thanks,

J