From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.19.201]:56013 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbaGEKG5 (ORCPT ); Sat, 5 Jul 2014 06:06:57 -0400 Message-ID: <53B7CEC3.7050309@kernel.org> Date: Sat, 05 Jul 2014 11:09:07 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Sachin Kamat , linux-iio@vger.kernel.org CC: spk.linux@gmail.com, Srinivas Pandruvada Subject: Re: [PATCH 2/7] iio: hid-sensor-accel-3d: Fix return values References: <1404369852-3255-1-git-send-email-sachin.kamat@samsung.com> <1404369852-3255-2-git-send-email-sachin.kamat@samsung.com> In-Reply-To: <1404369852-3255-2-git-send-email-sachin.kamat@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 03/07/14 07:44, Sachin Kamat wrote: > IIO_CHAN_INFO_SAMP_FREQ and IIO_CHAN_INFO_HYSTERESIS cases ignored > the actual return values (which could be -EINVAL) and instead > returned IIO_VAL_INT_PLUS_MICRO always. Return the actual value > obtained from the functions. Both functions return IIO_VAL_INT_PLUS_MICRO > upon success. > > Signed-off-by: Sachin Kamat > Cc: Srinivas Pandruvada Applied to the fixes-togreg branch of iio.git Thanks > --- > drivers/iio/accel/hid-sensor-accel-3d.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c > index 69abf91..54e464e 100644 > --- a/drivers/iio/accel/hid-sensor-accel-3d.c > +++ b/drivers/iio/accel/hid-sensor-accel-3d.c > @@ -110,7 +110,6 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev, > struct accel_3d_state *accel_state = iio_priv(indio_dev); > int report_id = -1; > u32 address; > - int ret; > int ret_type; > s32 poll_value; > > @@ -151,14 +150,12 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev, > ret_type = IIO_VAL_INT; > break; > case IIO_CHAN_INFO_SAMP_FREQ: > - ret = hid_sensor_read_samp_freq_value( > + ret_type = hid_sensor_read_samp_freq_value( > &accel_state->common_attributes, val, val2); > - ret_type = IIO_VAL_INT_PLUS_MICRO; > break; > case IIO_CHAN_INFO_HYSTERESIS: > - ret = hid_sensor_read_raw_hyst_value( > + ret_type = hid_sensor_read_raw_hyst_value( > &accel_state->common_attributes, val, val2); > - ret_type = IIO_VAL_INT_PLUS_MICRO; > break; > default: > ret_type = -EINVAL; >