From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>, pmeerw@pmeerw.net
Cc: gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: remove duplicate case labels
Date: Mon, 07 Jul 2014 17:16:15 +0100 [thread overview]
Message-ID: <53BAC7CF.2020501@kernel.org> (raw)
In-Reply-To: <1404742333-22681-1-git-send-email-daniel.baluta@intel.com>
On 07/07/14 15:12, Daniel Baluta wrote:
> Otherwise, compiling iio_event_monitor program fails:
>
> io_event_monitor.c: In function ‘event_is_known’:
> iio_event_monitor.c:125:2: error: duplicate case value
> case IIO_MOD_LIGHT_BOTH:
> ^
> iio_event_monitor.c:121:2: error: previously used here
> case IIO_MOD_LIGHT_BOTH:
>
> Fixes: da4db94 (iio staging: add recently added modifiers to iio_event_monitor)
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the togreg branch of iio.git. It's a fix to example code so
probably not worth pushing out any faster.
Thanks,
Jonathan
> ---
> drivers/staging/iio/Documentation/iio_event_monitor.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/Documentation/iio_event_monitor.c b/drivers/staging/iio/Documentation/iio_event_monitor.c
> index cb35a97..569d6f8 100644
> --- a/drivers/staging/iio/Documentation/iio_event_monitor.c
> +++ b/drivers/staging/iio/Documentation/iio_event_monitor.c
> @@ -122,8 +122,6 @@ static bool event_is_known(struct iio_event_data *event)
> case IIO_MOD_LIGHT_IR:
> case IIO_MOD_ROOT_SUM_SQUARED_X_Y:
> case IIO_MOD_SUM_SQUARED_X_Y_Z:
> - case IIO_MOD_LIGHT_BOTH:
> - case IIO_MOD_LIGHT_IR:
> case IIO_MOD_LIGHT_CLEAR:
> case IIO_MOD_LIGHT_RED:
> case IIO_MOD_LIGHT_GREEN:
>
prev parent reply other threads:[~2014-07-07 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 14:12 [PATCH] staging: iio: remove duplicate case labels Daniel Baluta
2014-07-07 16:16 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BAC7CF.2020501@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).