linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hartmut Knaack <knaack.h@gmx.de>
To: Martin Fuzzey <mfuzzey@parkeon.com>,
	linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: mma8452: Use correct acceleration units.
Date: Sat, 12 Jul 2014 12:50:59 +0200	[thread overview]
Message-ID: <53C11313.20803@gmx.de> (raw)
In-Reply-To: <20140711125431.22109.59659.stgit@localhost>

Martin Fuzzey schrieb:
> The userspace interface for acceleration sensors is documented as using
> m/s^2 units [Documentation/ABI/testing/sysfs-bus-iio]
>
> The fullscale raw value for the mma8452 (-2048) corresponds to -2G, -4G or -8G
> depending on the seleted mode.
>
> The scale table was converting to G rather than m/s^2.
> Change the scaling table to match the documented interface.
>
> Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
> ---
>  drivers/iio/accel/mma8452.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 17aeea1..61eba5a 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -111,8 +111,13 @@ static const int mma8452_samp_freq[8][2] = {
>  	{6, 250000}, {1, 560000}
>  };
>  
The first line of the comment should just contain /*
> +/* Hardware has fullscale of -2G, -4G, -8G corresponding to raw value -2048
> + * The userspace interface uses m/s^2 and we declare micro units
> + * So scale factor is given by:
> + * 	g * N * 1000000 / 2048 for N = 2, 4, 8 and g=9.80665
> + */
>  static const int mma8452_scales[3][2] = {
> -	{0, 977}, {0, 1953}, {0, 3906}
> +	{0, 9577}, {0, 19154}, {0, 38307}
>  };
>  
>  static ssize_t mma8452_show_samp_freq_avail(struct device *dev,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


  reply	other threads:[~2014-07-12 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 12:54 [PATCH] iio: mma8452: Use correct acceleration units Martin Fuzzey
2014-07-12 10:50 ` Hartmut Knaack [this message]
2014-07-12 12:19   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C11313.20803@gmx.de \
    --to=knaack.h@gmx.de \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mfuzzey@parkeon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).