* [PATCH] staging: iio: adc: ad7192: fix coding style
@ 2014-07-12 19:16 Marcus Folkesson
2014-07-13 9:11 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2014-07-12 19:16 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman, Marcus Folkesson,
Sachin Kamat
Cc: linux-iio, devel, linux-kernel
Line over 80 characters. This is for Eudyptula Challenge.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/staging/iio/adc/ad7192.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 83bb44b..c25c9ab 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
id &= AD7192_ID_MASK;
if (id != st->devid)
- dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
+ dev_warn(&st->sd.spi->dev,
+ "device ID query failed (0x%X)\n", id);
switch (pdata->clock_source_sel) {
case AD7192_CLK_EXT_MCLK1_2:
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: iio: adc: ad7192: fix coding style
2014-07-12 19:16 [PATCH] staging: iio: adc: ad7192: fix coding style Marcus Folkesson
@ 2014-07-13 9:11 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-07-13 9:11 UTC (permalink / raw)
To: Marcus Folkesson, Greg Kroah-Hartman, Sachin Kamat
Cc: linux-iio, devel, linux-kernel
On 12/07/14 20:16, Marcus Folkesson wrote:
> Line over 80 characters. This is for Eudyptula Challenge.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Sorry Marcus,
There is a level of trivial cleanup below which it's not worth
taking patches. The 80 character limit is not a hard and fast
rule. Here, if this had been picked up during review of the original
patch, or was fixed as a part of a more substantial series, I'd
have no objection taking it. On it's own it's just too small.
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 83bb44b..c25c9ab 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
> id &= AD7192_ID_MASK;
>
> if (id != st->devid)
> - dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
> + dev_warn(&st->sd.spi->dev,
> + "device ID query failed (0x%X)\n", id);
>
> switch (pdata->clock_source_sel) {
> case AD7192_CLK_EXT_MCLK1_2:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-13 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-12 19:16 [PATCH] staging: iio: adc: ad7192: fix coding style Marcus Folkesson
2014-07-13 9:11 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).