* [PATCH] staging: iio: ad5933: fix sparse warnings
@ 2014-07-25 8:50 Teodora Baluta
2014-07-27 13:34 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Teodora Baluta @ 2014-07-25 8:50 UTC (permalink / raw)
To: linux-iio; +Cc: Teodora Baluta
Fix the following sparse warnings:
CHECK drivers/staging/iio/impedance-analyzer/ad5933.c
drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: warning:
incorrect type in assignment (different base types)
drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: expected
unsigned int [unsigned] [usertype] d32
drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: got
restricted __be32 [usertype] <noident>
drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: warning:
incorrect type in assignment (different base types)
drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: expected
unsigned short [unsigned] dat
drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: got
restricted __be16 [usertype] <noident>
drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: warning:
incorrect type in assignment (different base types)
drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: expected
unsigned short [unsigned] [addressable] dat
drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: got
restricted __be16 [usertype] <noident>
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
restricted __be32
drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: warning:
incorrect type in assignment (different base types)
drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: expected
unsigned short [unsigned] dat
drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: got
restricted __be16 [usertype] <noident>
drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: warning:
incorrect type in assignment (different base types)
drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: expected
unsigned short [unsigned] [addressable] dat
drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: got
restricted __be16 [usertype] <noident>
drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
restricted __be16
drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
restricted __be16
Signed-off-by: Teodora Baluta <teodora.baluta@intel.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index 2b96665..2cef4b9 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -220,7 +220,7 @@ static int ad5933_set_freq(struct ad5933_state *st,
{
unsigned long long freqreg;
union {
- u32 d32;
+ __be32 d32;
u8 d8[4];
} dat;
@@ -244,7 +244,7 @@ static int ad5933_set_freq(struct ad5933_state *st,
static int ad5933_setup(struct ad5933_state *st)
{
- unsigned short dat;
+ __be16 dat;
int ret;
ret = ad5933_reset(st);
@@ -297,7 +297,7 @@ static ssize_t ad5933_show_frequency(struct device *dev,
int ret;
unsigned long long freqreg;
union {
- u32 d32;
+ __be32 d32;
u8 d8[4];
} dat;
@@ -402,7 +402,7 @@ static ssize_t ad5933_store(struct device *dev,
struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
u16 val;
int i, ret = 0;
- unsigned short dat;
+ __be16 dat;
if (this_attr->address != AD5933_IN_PGA_GAIN) {
ret = kstrtou16(buf, 10, &val);
@@ -521,7 +521,7 @@ static int ad5933_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad5933_state *st = iio_priv(indio_dev);
- unsigned short dat;
+ __be16 dat;
int ret = -EINVAL;
mutex_lock(&indio_dev->mlock);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: iio: ad5933: fix sparse warnings
2014-07-25 8:50 [PATCH] staging: iio: ad5933: fix sparse warnings Teodora Baluta
@ 2014-07-27 13:34 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-07-27 13:34 UTC (permalink / raw)
To: Teodora Baluta, linux-iio, Lars-Peter Clausen
On 25/07/14 09:50, Teodora Baluta wrote:
> Fix the following sparse warnings:
>
> CHECK drivers/staging/iio/impedance-analyzer/ad5933.c
> drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: warning:
> incorrect type in assignment (different base types)
> drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: expected
> unsigned int [unsigned] [usertype] d32
> drivers/staging/iio/impedance-analyzer/ad5933.c:241:17: got
> restricted __be32 [usertype] <noident>
> drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: warning:
> incorrect type in assignment (different base types)
> drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: expected
> unsigned short [unsigned] dat
> drivers/staging/iio/impedance-analyzer/ad5933.c:263:13: got
> restricted __be16 [usertype] <noident>
> drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: warning:
> incorrect type in assignment (different base types)
> drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: expected
> unsigned short [unsigned] [addressable] dat
> drivers/staging/iio/impedance-analyzer/ad5933.c:271:13: got
> restricted __be16 [usertype] <noident>
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:310:19: warning: cast to
> restricted __be32
> drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: warning:
> incorrect type in assignment (different base types)
> drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: expected
> unsigned short [unsigned] dat
> drivers/staging/iio/impedance-analyzer/ad5933.c:446:21: got
> restricted __be16 [usertype] <noident>
> drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: warning:
> incorrect type in assignment (different base types)
> drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: expected
> unsigned short [unsigned] [addressable] dat
> drivers/staging/iio/impedance-analyzer/ad5933.c:454:21: got
> restricted __be16 [usertype] <noident>
> drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
> restricted __be16
> drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
> restricted __be16
> drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
> restricted __be16
> drivers/staging/iio/impedance-analyzer/ad5933.c:548:23: warning: cast to
> restricted __be16
>
> Signed-off-by: Teodora Baluta <teodora.baluta@intel.com>
Applied to the togreg branch of iio.git. Pushed out as testing for now
to let the autobuilders play with it.
Also cc'd Lars who looks after most of of the Analog Devices drivers in IIO.
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 2b96665..2cef4b9 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -220,7 +220,7 @@ static int ad5933_set_freq(struct ad5933_state *st,
> {
> unsigned long long freqreg;
> union {
> - u32 d32;
> + __be32 d32;
> u8 d8[4];
> } dat;
>
> @@ -244,7 +244,7 @@ static int ad5933_set_freq(struct ad5933_state *st,
>
> static int ad5933_setup(struct ad5933_state *st)
> {
> - unsigned short dat;
> + __be16 dat;
> int ret;
>
> ret = ad5933_reset(st);
> @@ -297,7 +297,7 @@ static ssize_t ad5933_show_frequency(struct device *dev,
> int ret;
> unsigned long long freqreg;
> union {
> - u32 d32;
> + __be32 d32;
> u8 d8[4];
> } dat;
>
> @@ -402,7 +402,7 @@ static ssize_t ad5933_store(struct device *dev,
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> u16 val;
> int i, ret = 0;
> - unsigned short dat;
> + __be16 dat;
>
> if (this_attr->address != AD5933_IN_PGA_GAIN) {
> ret = kstrtou16(buf, 10, &val);
> @@ -521,7 +521,7 @@ static int ad5933_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad5933_state *st = iio_priv(indio_dev);
> - unsigned short dat;
> + __be16 dat;
> int ret = -EINVAL;
>
> mutex_lock(&indio_dev->mlock);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-27 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-25 8:50 [PATCH] staging: iio: ad5933: fix sparse warnings Teodora Baluta
2014-07-27 13:34 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).