From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:46742 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbaHYUlG (ORCPT ); Mon, 25 Aug 2014 16:41:06 -0400 Message-ID: <53FB9F60.7030501@kernel.org> Date: Mon, 25 Aug 2014 21:41:04 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: linux-iio@vger.kernel.org Subject: Re: [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment References: <1408740516-31261-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1408740516-31261-3-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1408740516-31261-3-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 22/08/14 21:48, Srinivas Pandruvada wrote: > This can result in wrong reference count for trigger device, call > iio_trigger_get to increment reference. > Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion > with Jonathan. > > Signed-off-by: Srinivas Pandruvada Applied to the fixes-togreg branch of iio.git. > --- > drivers/iio/accel/bma180.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c > index a7e68c8..e35a892e 100644 > --- a/drivers/iio/accel/bma180.c > +++ b/drivers/iio/accel/bma180.c > @@ -569,7 +569,7 @@ static int bma180_probe(struct i2c_client *client, > trig->ops = &bma180_trigger_ops; > iio_trigger_set_drvdata(trig, indio_dev); > data->trig = trig; > - indio_dev->trig = trig; > + indio_dev->trig = iio_trigger_get(trig); > > ret = iio_trigger_register(trig); > if (ret) >