From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:46765 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933329AbaHYUnA (ORCPT ); Mon, 25 Aug 2014 16:43:00 -0400 Message-ID: <53FB9FD3.8080203@kernel.org> Date: Mon, 25 Aug 2014 21:42:59 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: linux-iio@vger.kernel.org Subject: Re: [PATCH v1 4/8] iio: hid_sensor_hub: Fix indio_dev->trig assignment References: <1408740516-31261-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1408740516-31261-5-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1408740516-31261-5-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 22/08/14 21:48, Srinivas Pandruvada wrote: > This can result in wrong reference count for trigger device, call > iio_trigger_get to increment reference. > Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion > with Jonathan. > > Signed-off-by: Srinivas Pandruvada Applied to the fixes-togreg branch of iio.git Thanks, > --- > drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > index a3109a6..92068cd 100644 > --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > @@ -122,7 +122,8 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name, > dev_err(&indio_dev->dev, "Trigger Register Failed\n"); > goto error_free_trig; > } > - indio_dev->trig = attrb->trigger = trig; > + attrb->trigger = trig; > + indio_dev->trig = iio_trigger_get(trig); > > return ret; > >