* [PATCH v1 1/8] iio:trigger: modify return value for iio_trigger_get
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:35 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment Srinivas Pandruvada
` (6 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
Instead of a void function, return the trigger pointer.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
include/linux/iio/trigger.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 4b79ffe..fa76c79 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -84,10 +84,12 @@ static inline void iio_trigger_put(struct iio_trigger *trig)
put_device(&trig->dev);
}
-static inline void iio_trigger_get(struct iio_trigger *trig)
+static inline struct iio_trigger *iio_trigger_get(struct iio_trigger *trig)
{
get_device(&trig->dev);
__module_get(trig->ops->owner);
+
+ return trig;
}
/**
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 1/8] iio:trigger: modify return value for iio_trigger_get
2014-08-22 20:48 ` [PATCH v1 1/8] iio:trigger: modify return value for iio_trigger_get Srinivas Pandruvada
@ 2014-08-25 20:35 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:35 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> Instead of a void function, return the trigger pointer.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thanks for doing this,
Applied to the fixes-togreg branch of iio.git.
Jonathan
> ---
> include/linux/iio/trigger.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 4b79ffe..fa76c79 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -84,10 +84,12 @@ static inline void iio_trigger_put(struct iio_trigger *trig)
> put_device(&trig->dev);
> }
>
> -static inline void iio_trigger_get(struct iio_trigger *trig)
> +static inline struct iio_trigger *iio_trigger_get(struct iio_trigger *trig)
> {
> get_device(&trig->dev);
> __module_get(trig->ops->owner);
> +
> + return trig;
> }
>
> /**
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
2014-08-22 20:48 ` [PATCH v1 1/8] iio:trigger: modify return value for iio_trigger_get Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:41 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 3/8] iio: adc: ad_sigma_delta: " Srinivas Pandruvada
` (5 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/accel/bma180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index a7e68c8..e35a892e 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -569,7 +569,7 @@ static int bma180_probe(struct i2c_client *client,
trig->ops = &bma180_trigger_ops;
iio_trigger_set_drvdata(trig, indio_dev);
data->trig = trig;
- indio_dev->trig = trig;
+ indio_dev->trig = iio_trigger_get(trig);
ret = iio_trigger_register(trig);
if (ret)
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment Srinivas Pandruvada
@ 2014-08-25 20:41 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:41 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git.
> ---
> drivers/iio/accel/bma180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index a7e68c8..e35a892e 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -569,7 +569,7 @@ static int bma180_probe(struct i2c_client *client,
> trig->ops = &bma180_trigger_ops;
> iio_trigger_set_drvdata(trig, indio_dev);
> data->trig = trig;
> - indio_dev->trig = trig;
> + indio_dev->trig = iio_trigger_get(trig);
>
> ret = iio_trigger_register(trig);
> if (ret)
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 3/8] iio: adc: ad_sigma_delta: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
2014-08-22 20:48 ` [PATCH v1 1/8] iio:trigger: modify return value for iio_trigger_get Srinivas Pandruvada
2014-08-22 20:48 ` [PATCH v1 2/8] iio: accel: bma180: Fix indio_dev->trig assignment Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-23 7:00 ` Lars-Peter Clausen
2014-08-22 20:48 ` [PATCH v1 4/8] iio: hid_sensor_hub: " Srinivas Pandruvada
` (4 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/adc/ad_sigma_delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index c55b81f..d10bd0c 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -472,7 +472,7 @@ static int ad_sd_probe_trigger(struct iio_dev *indio_dev)
goto error_free_irq;
/* select default trigger */
- indio_dev->trig = sigma_delta->trig;
+ indio_dev->trig = iio_trigger_get(sigma_delta->trig);
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 3/8] iio: adc: ad_sigma_delta: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 3/8] iio: adc: ad_sigma_delta: " Srinivas Pandruvada
@ 2014-08-23 7:00 ` Lars-Peter Clausen
2014-08-25 20:41 ` Jonathan Cameron
0 siblings, 1 reply; 19+ messages in thread
From: Lars-Peter Clausen @ 2014-08-23 7:00 UTC (permalink / raw)
To: Srinivas Pandruvada, jic23; +Cc: linux-iio
On 08/22/2014 10:48 PM, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> drivers/iio/adc/ad_sigma_delta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index c55b81f..d10bd0c 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -472,7 +472,7 @@ static int ad_sd_probe_trigger(struct iio_dev *indio_dev)
> goto error_free_irq;
>
> /* select default trigger */
> - indio_dev->trig = sigma_delta->trig;
> + indio_dev->trig = iio_trigger_get(sigma_delta->trig);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v1 3/8] iio: adc: ad_sigma_delta: Fix indio_dev->trig assignment
2014-08-23 7:00 ` Lars-Peter Clausen
@ 2014-08-25 20:41 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:41 UTC (permalink / raw)
To: Lars-Peter Clausen, Srinivas Pandruvada; +Cc: linux-iio
On 23/08/14 08:00, Lars-Peter Clausen wrote:
> On 08/22/2014 10:48 PM, Srinivas Pandruvada wrote:
>> This can result in wrong reference count for trigger device, call
>> iio_trigger_get to increment reference.
>> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
>> with Jonathan.
>>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied
>
> Thanks.
>
>> ---
>> drivers/iio/adc/ad_sigma_delta.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
>> index c55b81f..d10bd0c 100644
>> --- a/drivers/iio/adc/ad_sigma_delta.c
>> +++ b/drivers/iio/adc/ad_sigma_delta.c
>> @@ -472,7 +472,7 @@ static int ad_sd_probe_trigger(struct iio_dev *indio_dev)
>> goto error_free_irq;
>>
>> /* select default trigger */
>> - indio_dev->trig = sigma_delta->trig;
>> + indio_dev->trig = iio_trigger_get(sigma_delta->trig);
>>
>> return 0;
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 4/8] iio: hid_sensor_hub: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
` (2 preceding siblings ...)
2014-08-22 20:48 ` [PATCH v1 3/8] iio: adc: ad_sigma_delta: " Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:42 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 5/8] iio: st_sensors: " Srinivas Pandruvada
` (3 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index a3109a6..92068cd 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -122,7 +122,8 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name,
dev_err(&indio_dev->dev, "Trigger Register Failed\n");
goto error_free_trig;
}
- indio_dev->trig = attrb->trigger = trig;
+ attrb->trigger = trig;
+ indio_dev->trig = iio_trigger_get(trig);
return ret;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 4/8] iio: hid_sensor_hub: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 4/8] iio: hid_sensor_hub: " Srinivas Pandruvada
@ 2014-08-25 20:42 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:42 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index a3109a6..92068cd 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -122,7 +122,8 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name,
> dev_err(&indio_dev->dev, "Trigger Register Failed\n");
> goto error_free_trig;
> }
> - indio_dev->trig = attrb->trigger = trig;
> + attrb->trigger = trig;
> + indio_dev->trig = iio_trigger_get(trig);
>
> return ret;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 5/8] iio: st_sensors: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
` (3 preceding siblings ...)
2014-08-22 20:48 ` [PATCH v1 4/8] iio: hid_sensor_hub: " Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:43 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 6/8] iio: gyro: itg3200: " Srinivas Pandruvada
` (2 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/common/st_sensors/st_sensors_trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
index 8fc3a97..8d8ca6f 100644
--- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
+++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
@@ -49,7 +49,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
dev_err(&indio_dev->dev, "failed to register iio trigger.\n");
goto iio_trigger_register_error;
}
- indio_dev->trig = sdata->trig;
+ indio_dev->trig = iio_trigger_get(sdata->trig);
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 5/8] iio: st_sensors: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 5/8] iio: st_sensors: " Srinivas Pandruvada
@ 2014-08-25 20:43 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:43 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio, Denis CIOCCA
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git.
> ---
> drivers/iio/common/st_sensors/st_sensors_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> index 8fc3a97..8d8ca6f 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> @@ -49,7 +49,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
> dev_err(&indio_dev->dev, "failed to register iio trigger.\n");
> goto iio_trigger_register_error;
> }
> - indio_dev->trig = sdata->trig;
> + indio_dev->trig = iio_trigger_get(sdata->trig);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 6/8] iio: gyro: itg3200: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
` (4 preceding siblings ...)
2014-08-22 20:48 ` [PATCH v1 5/8] iio: st_sensors: " Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:44 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 7/8] iio: inv_mpu6050: " Srinivas Pandruvada
2014-08-22 20:48 ` [PATCH v1 8/8] iio: meter: ade7758: " Srinivas Pandruvada
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/gyro/itg3200_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/gyro/itg3200_buffer.c b/drivers/iio/gyro/itg3200_buffer.c
index e3b3c50..eef50e9 100644
--- a/drivers/iio/gyro/itg3200_buffer.c
+++ b/drivers/iio/gyro/itg3200_buffer.c
@@ -132,7 +132,7 @@ int itg3200_probe_trigger(struct iio_dev *indio_dev)
goto error_free_irq;
/* select default trigger */
- indio_dev->trig = st->trig;
+ indio_dev->trig = iio_trigger_get(st->trig);
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 6/8] iio: gyro: itg3200: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 6/8] iio: gyro: itg3200: " Srinivas Pandruvada
@ 2014-08-25 20:44 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:44 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio, Thorsten Nowak, Manuel Stahl
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> drivers/iio/gyro/itg3200_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/itg3200_buffer.c b/drivers/iio/gyro/itg3200_buffer.c
> index e3b3c50..eef50e9 100644
> --- a/drivers/iio/gyro/itg3200_buffer.c
> +++ b/drivers/iio/gyro/itg3200_buffer.c
> @@ -132,7 +132,7 @@ int itg3200_probe_trigger(struct iio_dev *indio_dev)
> goto error_free_irq;
>
> /* select default trigger */
> - indio_dev->trig = st->trig;
> + indio_dev->trig = iio_trigger_get(st->trig);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 7/8] iio: inv_mpu6050: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
` (5 preceding siblings ...)
2014-08-22 20:48 ` [PATCH v1 6/8] iio: gyro: itg3200: " Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-25 20:45 ` Jonathan Cameron
2014-08-22 20:48 ` [PATCH v1 8/8] iio: meter: ade7758: " Srinivas Pandruvada
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
index 03b9372..926fcce 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
@@ -135,7 +135,7 @@ int inv_mpu6050_probe_trigger(struct iio_dev *indio_dev)
ret = iio_trigger_register(st->trig);
if (ret)
goto error_free_irq;
- indio_dev->trig = st->trig;
+ indio_dev->trig = iio_trigger_get(st->trig);
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 7/8] iio: inv_mpu6050: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 7/8] iio: inv_mpu6050: " Srinivas Pandruvada
@ 2014-08-25 20:45 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:45 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio
On 22/08/14 21:48, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.igt
Thanks,
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> index 03b9372..926fcce 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> @@ -135,7 +135,7 @@ int inv_mpu6050_probe_trigger(struct iio_dev *indio_dev)
> ret = iio_trigger_register(st->trig);
> if (ret)
> goto error_free_irq;
> - indio_dev->trig = st->trig;
> + indio_dev->trig = iio_trigger_get(st->trig);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v1 8/8] iio: meter: ade7758: Fix indio_dev->trig assignment
2014-08-22 20:48 [PATCH v1 0/8] Fix iio_dev->trig assignment Srinivas Pandruvada
` (6 preceding siblings ...)
2014-08-22 20:48 ` [PATCH v1 7/8] iio: inv_mpu6050: " Srinivas Pandruvada
@ 2014-08-22 20:48 ` Srinivas Pandruvada
2014-08-23 7:00 ` Lars-Peter Clausen
7 siblings, 1 reply; 19+ messages in thread
From: Srinivas Pandruvada @ 2014-08-22 20:48 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
This can result in wrong reference count for trigger device, call
iio_trigger_get to increment reference.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7758_trigger.c b/drivers/staging/iio/meter/ade7758_trigger.c
index ea01b8f..6f45ce0 100644
--- a/drivers/staging/iio/meter/ade7758_trigger.c
+++ b/drivers/staging/iio/meter/ade7758_trigger.c
@@ -85,7 +85,7 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
ret = iio_trigger_register(st->trig);
/* select default trigger */
- indio_dev->trig = st->trig;
+ indio_dev->trig = iio_trigger_get(st->trig);
if (ret)
goto error_free_irq;
--
1.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v1 8/8] iio: meter: ade7758: Fix indio_dev->trig assignment
2014-08-22 20:48 ` [PATCH v1 8/8] iio: meter: ade7758: " Srinivas Pandruvada
@ 2014-08-23 7:00 ` Lars-Peter Clausen
2014-08-25 20:50 ` Jonathan Cameron
0 siblings, 1 reply; 19+ messages in thread
From: Lars-Peter Clausen @ 2014-08-23 7:00 UTC (permalink / raw)
To: Srinivas Pandruvada, jic23; +Cc: linux-iio
On 08/22/2014 10:48 PM, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, call
> iio_trigger_get to increment reference.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7758_trigger.c b/drivers/staging/iio/meter/ade7758_trigger.c
> index ea01b8f..6f45ce0 100644
> --- a/drivers/staging/iio/meter/ade7758_trigger.c
> +++ b/drivers/staging/iio/meter/ade7758_trigger.c
> @@ -85,7 +85,7 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
> ret = iio_trigger_register(st->trig);
>
> /* select default trigger */
> - indio_dev->trig = st->trig;
> + indio_dev->trig = iio_trigger_get(st->trig);
> if (ret)
> goto error_free_irq;
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v1 8/8] iio: meter: ade7758: Fix indio_dev->trig assignment
2014-08-23 7:00 ` Lars-Peter Clausen
@ 2014-08-25 20:50 ` Jonathan Cameron
0 siblings, 0 replies; 19+ messages in thread
From: Jonathan Cameron @ 2014-08-25 20:50 UTC (permalink / raw)
To: Lars-Peter Clausen, Srinivas Pandruvada; +Cc: linux-iio
On 23/08/14 08:00, Lars-Peter Clausen wrote:
> On 08/22/2014 10:48 PM, Srinivas Pandruvada wrote:
>> This can result in wrong reference count for trigger device, call
>> iio_trigger_get to increment reference.
>> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
>> with Jonathan.
>>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the fixes-togreg branch of iio.git
Whole series marked for stable. I debated whether this mades sense, but
concluded that it did given the nasty effect of the double free this
prevents.
Thanks,
J
>
> Thanks.
>
>> ---
>> drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/meter/ade7758_trigger.c b/drivers/staging/iio/meter/ade7758_trigger.c
>> index ea01b8f..6f45ce0 100644
>> --- a/drivers/staging/iio/meter/ade7758_trigger.c
>> +++ b/drivers/staging/iio/meter/ade7758_trigger.c
>> @@ -85,7 +85,7 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
>> ret = iio_trigger_register(st->trig);
>>
>> /* select default trigger */
>> - indio_dev->trig = st->trig;
>> + indio_dev->trig = iio_trigger_get(st->trig);
>> if (ret)
>> goto error_free_irq;
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread