Linux IIO development
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
	jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	mranostay@gmail.com
Cc: ~lkcamp/patches@lists.sr.ht, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v4] dt-bindings: iio: proximity: move LIDAR-Lite out of trivial-devices
Date: Fri, 7 Aug 2026 13:14:59 -0500	[thread overview]
Message-ID: <53ded669-6dec-4472-840c-91052b1afcb3@baylibre.com> (raw)
In-Reply-To: <0ca14770-bb0c-4be7-a9b0-6e07d521550d@gmail.com>

On 8/7/26 12:10 PM, Rodrigo Gobbi wrote:
> On 7/14/26 19:44, David Lechner wrote:
>>
>> interrupts:
>>   description: 
>>     Mode control pin can be used as a status output to provide interrupt.
>>   maxItems: 1
>>
>> Mode control pin can also be clock output, so we could add:
>>
>> '#clock-cells':
>>   const: 0
>>
>> if:
>>   required:
>>     interrupts
>> then:
>>   '#clock-cells': false
>>
>> I only checked Lidar Lite v3 docs, so we should see if these are available
>> on v2 as well.
> David, quick pushback on the #clock-cells suggestion:
> 
> The oscillator-output mode, per the Garmin datasheet, page 8 reg 0x4 from [1], isn't really
> meant to supply a clock for another device's logic. As I understand it, it exists so the host
> can measure it against its own reference and compute a compensation factor for the device's
> own distance readings, since the on-chip oscillator is only rated to ~1% accuracy.
> 
> That seems like a different relationship than what #clock-cells models: a provider is
> expected to report a rate that a consumer just uses to drive its own logic. Here it's the
> opposite — the rate itself is what's untrustworthy and needs an external measurement, and
> there's no consumer that would actually want to clock anything off of it.
> 
> Given that, maybe it's better to just describe this rather than model it as a clock property,
> or leave it out of the binding entirely for now until there's an actual consumer for it? My
> point is more about whether #clock-cells is the right semantics for potential consumers here.

Yes, this sounds like one of those cases where there isn't an obvious
correct binding and we should leave it until there is an actual use
case to make sure we get it right.

> 
> Tks and regards.
> 
> [1] https://static.garmin.com/pumac/LIDAR_Lite_v3_Operation_Manual_and_Technical_Specifications.pdf


      reply	other threads:[~2026-08-07 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 21:30 [PATCH v4] dt-bindings: iio: proximity: move LIDAR-Lite out of trivial-devices Rodrigo Gobbi
2026-07-14 22:44 ` David Lechner
2026-07-19 22:41   ` Jonathan Cameron
2026-08-07 17:10   ` Rodrigo Gobbi
2026-08-07 18:14     ` David Lechner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ded669-6dec-4472-840c-91052b1afcb3@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox