* [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static
@ 2014-08-27 8:31 Josh Wu
2014-08-27 8:36 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Josh Wu @ 2014-08-27 8:31 UTC (permalink / raw)
To: linux-kernel, linux-iio, jic23
Cc: alexandre.belloni, maxime.ripard, nicolas.ferre, Josh Wu
The handle_adc_eoc_trigger() in only used in at91_adc.c. So make it
static.
Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
drivers/iio/adc/at91_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 772e869..7807e0e 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -266,7 +266,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
}
/* Handler for classic adc channel eoc trigger */
-void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
+static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
{
struct at91_adc_state *st = iio_priv(idev);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static
2014-08-27 8:31 [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static Josh Wu
@ 2014-08-27 8:36 ` Nicolas Ferre
2014-08-30 9:48 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2014-08-27 8:36 UTC (permalink / raw)
To: Josh Wu, linux-kernel, linux-iio, jic23, maxime.ripard; +Cc: alexandre.belloni
On 27/08/2014 10:31, Josh Wu :
> The handle_adc_eoc_trigger() in only used in at91_adc.c. So make it
> static.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
Absolutely.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
> ---
> drivers/iio/adc/at91_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 772e869..7807e0e 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -266,7 +266,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
> }
>
> /* Handler for classic adc channel eoc trigger */
> -void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
> +static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
> {
> struct at91_adc_state *st = iio_priv(idev);
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static
2014-08-27 8:36 ` Nicolas Ferre
@ 2014-08-30 9:48 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2014-08-30 9:48 UTC (permalink / raw)
To: Nicolas Ferre, Josh Wu, linux-kernel, linux-iio, maxime.ripard
Cc: alexandre.belloni
On 27/08/14 09:36, Nicolas Ferre wrote:
> On 27/08/2014 10:31, Josh Wu :
>> The handle_adc_eoc_trigger() in only used in at91_adc.c. So make it
>> static.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>
> Absolutely.
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> Thanks, bye.
>
>> ---
>> drivers/iio/adc/at91_adc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
>> index 772e869..7807e0e 100644
>> --- a/drivers/iio/adc/at91_adc.c
>> +++ b/drivers/iio/adc/at91_adc.c
>> @@ -266,7 +266,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
>> }
>>
>> /* Handler for classic adc channel eoc trigger */
>> -void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
>> +static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
>> {
>> struct at91_adc_state *st = iio_priv(idev);
>>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-30 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 8:31 [PATCH] iio: adc: at91: make the function handle_adc_eoc_trigger() static Josh Wu
2014-08-27 8:36 ` Nicolas Ferre
2014-08-30 9:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).