From: Jonathan Cameron <jic23@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: handle -EPROBE_DEFER in of_iio_channel_get_by_name
Date: Sat, 30 Aug 2014 11:29:04 +0100 [thread overview]
Message-ID: <5401A770.3040204@kernel.org> (raw)
In-Reply-To: <4420839.L1RSpT2Pjo@diego>
On 28/08/14 23:13, Heiko Stübner wrote:
> Till now of_iio_channel_get_by_name always tried to find the channel without
> evaluating the return code from of_iio_channel_get. This might include
> -EPROBE_DEFER in which case the channel is present but its driver simply not
> probed yet. Therefore simply return on -EPROBE_DEFER so that the driver
> requesting the channel can also defer.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
I already have a patch queued up for this change in the fixes-togreg branch
[PATCH] iio:inkern: fix overwritten -EPROBE_DEFER in of_iio_channel_get_by_name by Johannes Pointner
I'm just being a little slow catching up with patches at the moment.
J
> ---
> drivers/iio/inkern.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index c749700..f084610 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -178,7 +178,7 @@ static struct iio_channel *of_iio_channel_get_by_name(struct device_node *np,
> index = of_property_match_string(np, "io-channel-names",
> name);
> chan = of_iio_channel_get(np, index);
> - if (!IS_ERR(chan))
> + if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER)
> break;
> else if (name && index >= 0) {
> pr_err("ERROR: could not get IIO channel %s:%s(%i)\n",
>
next prev parent reply other threads:[~2014-08-30 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 22:13 [PATCH] iio: handle -EPROBE_DEFER in of_iio_channel_get_by_name Heiko Stübner
2014-08-30 10:29 ` Jonathan Cameron [this message]
2014-08-30 10:51 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5401A770.3040204@kernel.org \
--to=jic23@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).