From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5408983D.30002@metafoo.de> Date: Thu, 04 Sep 2014 18:50:05 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Sudip Mukherjee , Jonathan Cameron , Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman CC: "open list:STAGING - INDUSTR..." , open list:STAGING SUBSYSTEM , open list Subject: Re: [PATCH] staging: iio: adc: mxs-lradc.c: sparse warning of incorrect type References: <1409849142-12185-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1409849142-12185-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed List-ID: On 09/04/2014 06:45 PM, Sudip Mukherjee wrote: > fixed sparse warning : incorrect type in argument 1 > (different address spaces) > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/iio/adc/mxs-lradc.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c > index 468327f..d8d1fe1 100644 > --- a/drivers/staging/iio/adc/mxs-lradc.c > +++ b/drivers/staging/iio/adc/mxs-lradc.c > @@ -1545,9 +1545,12 @@ static int mxs_lradc_probe(struct platform_device *pdev) > /* Grab the memory area */ > iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > lradc->dev = &pdev->dev; > - lradc->base = devm_ioremap_resource(dev, iores); > - if (IS_ERR(lradc->base)) > - return PTR_ERR(lradc->base); > + void *tempptr; > + > + tempptr = devm_ioremap_resource(dev, iores); > + if (IS_ERR(tempptr)) > + return PTR_ERR(tempptr); > + lradc->base = tempptr; This makes no sense at all... devm_ioremap_resource() returns a iomem pointer lrdac->base is a iomem pointer. Please make sure that you have the latest version of sparse installed on your system. > > lradc->clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(lradc->clk)) { >