* [PATCH] iio: magn: ak8975: fix unnecessary casting between char* and const char*
@ 2014-09-02 11:04 Irina Tirdea
2014-09-06 12:23 ` Hartmut Knaack
0 siblings, 1 reply; 2+ messages in thread
From: Irina Tirdea @ 2014-09-02 11:04 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Srinivas Pandruvada, linux-kernel, Beomho Seo, Irina Tirdea
Use const char* instead of casting const char* to char*.
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
drivers/iio/magnetometer/ak8975.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index a235792..61edc66 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -477,7 +477,7 @@ static const struct acpi_device_id ak_acpi_match[] = {
};
MODULE_DEVICE_TABLE(acpi, ak_acpi_match);
-static char *ak8975_match_acpi_device(struct device *dev,
+static const char *ak8975_match_acpi_device(struct device *dev,
enum asahi_compass_chipset *chipset)
{
const struct acpi_device_id *id;
@@ -487,7 +487,7 @@ static char *ak8975_match_acpi_device(struct device *dev,
return NULL;
*chipset = (int)id->driver_data;
- return (char *)dev_name(dev);
+ return dev_name(dev);
}
static int ak8975_probe(struct i2c_client *client,
@@ -497,7 +497,7 @@ static int ak8975_probe(struct i2c_client *client,
struct iio_dev *indio_dev;
int eoc_gpio;
int err;
- char *name = NULL;
+ const char *name = NULL;
/* Grab and set up the supplied GPIO. */
if (client->dev.platform_data)
@@ -539,7 +539,7 @@ static int ak8975_probe(struct i2c_client *client,
if (id) {
data->chipset =
(enum asahi_compass_chipset)(id->driver_data);
- name = (char *) id->name;
+ name = id->name;
} else if (ACPI_HANDLE(&client->dev))
name = ak8975_match_acpi_device(&client->dev, &data->chipset);
else
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: magn: ak8975: fix unnecessary casting between char* and const char*
2014-09-02 11:04 [PATCH] iio: magn: ak8975: fix unnecessary casting between char* and const char* Irina Tirdea
@ 2014-09-06 12:23 ` Hartmut Knaack
0 siblings, 0 replies; 2+ messages in thread
From: Hartmut Knaack @ 2014-09-06 12:23 UTC (permalink / raw)
To: Irina Tirdea, Jonathan Cameron, linux-iio
Cc: Lars-Peter Clausen, Peter Meerwald, Srinivas Pandruvada,
linux-kernel, Beomho Seo
Irina Tirdea schrieb:
> Use const char* instead of casting const char* to char*.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> ---
> drivers/iio/magnetometer/ak8975.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index a235792..61edc66 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -477,7 +477,7 @@ static const struct acpi_device_id ak_acpi_match[] = {
> };
> MODULE_DEVICE_TABLE(acpi, ak_acpi_match);
>
> -static char *ak8975_match_acpi_device(struct device *dev,
> +static const char *ak8975_match_acpi_device(struct device *dev,
> enum asahi_compass_chipset *chipset)
This second line should also be indented properly, it will exactly fit 80 characters.
> {
> const struct acpi_device_id *id;
> @@ -487,7 +487,7 @@ static char *ak8975_match_acpi_device(struct device *dev,
> return NULL;
> *chipset = (int)id->driver_data;
>
> - return (char *)dev_name(dev);
> + return dev_name(dev);
> }
>
> static int ak8975_probe(struct i2c_client *client,
> @@ -497,7 +497,7 @@ static int ak8975_probe(struct i2c_client *client,
> struct iio_dev *indio_dev;
> int eoc_gpio;
> int err;
> - char *name = NULL;
> + const char *name = NULL;
>
> /* Grab and set up the supplied GPIO. */
> if (client->dev.platform_data)
> @@ -539,7 +539,7 @@ static int ak8975_probe(struct i2c_client *client,
> if (id) {
> data->chipset =
> (enum asahi_compass_chipset)(id->driver_data);
> - name = (char *) id->name;
> + name = id->name;
> } else if (ACPI_HANDLE(&client->dev))
> name = ak8975_match_acpi_device(&client->dev, &data->chipset);
> else
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-06 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 11:04 [PATCH] iio: magn: ak8975: fix unnecessary casting between char* and const char* Irina Tirdea
2014-09-06 12:23 ` Hartmut Knaack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).