From: Jonathan Cameron <jic23@kernel.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>,
IIO <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
DEVICE TREE <devicetree@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>
Cc: Carlo Caione <carlo@caione.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Aaron Lu <aaron.lu@intel.com>, Alan Cox <alan@linux.intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Fugang Duan <B38611@freescale.com>, Arnd Bergmann <arnd@arndb.de>,
Zubair Lutfullah <zubair.lutfullah@gmail.com>,
Sebastian Reichel <sre@debian.org>,
Johannes Thumshirn <johannes.thumshirn@men.de>,
Philippe Reynes <tremyfr@yahoo.fr>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Doug Anderson <dianders@chromium.org>,
Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH v3 3/5] regulator/axp20x: use axp2xx consolidated header
Date: Sat, 13 Sep 2014 21:01:51 +0100 [thread overview]
Message-ID: <5414A2AF.6000005@kernel.org> (raw)
In-Reply-To: <1410477357-6407-4-git-send-email-jacob.jun.pan@linux.intel.com>
On 12/09/14 00:15, Jacob Pan wrote:
> AXP20x driver has been extended to support axp288 variant. Header file
> and common data structures has also been renamed to suit the new
> scope of devices supported.
>
> This patch makes use of the renamed header and structure.
>
> Acked-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
> drivers/regulator/axp20x-regulator.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index 004aadb..c9b6803 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -20,7 +20,7 @@
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> -#include <linux/mfd/axp20x.h>
> +#include <linux/mfd/axp2xx.h>
Err, doesn't this break bisection. Rename 'must' be done in one go, not
split across patches.
> #include <linux/regulator/driver.h>
> #include <linux/regulator/of_regulator.h>
>
> @@ -161,7 +161,7 @@ static struct of_regulator_match axp20x_matches[] = {
>
> static int axp20x_set_dcdc_freq(struct platform_device *pdev, u32 dcdcfreq)
> {
> - struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> + struct axp2xx_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
>
> if (dcdcfreq < 750) {
> dcdcfreq = 750;
> @@ -232,7 +232,7 @@ static int axp20x_set_dcdc_workmode(struct regulator_dev *rdev, int id, u32 work
> static int axp20x_regulator_probe(struct platform_device *pdev)
> {
> struct regulator_dev *rdev;
> - struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> + struct axp2xx_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
> struct regulator_config config = { };
> struct regulator_init_data *init_data;
> int ret, i;
>
next prev parent reply other threads:[~2014-09-13 20:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 23:15 [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Jacob Pan
2014-09-11 23:15 ` [PATCH v3 1/5] mfd/axp20x: rename files to support more devices Jacob Pan
2014-09-13 20:00 ` Jonathan Cameron
2014-09-15 16:28 ` Jacob Pan
2014-09-15 22:18 ` Lee Jones
2014-09-11 23:15 ` [PATCH v3 2/5] mfd/axp2xx: extend axp20x to support axp288 pmic Jacob Pan
2014-09-15 22:22 ` Lee Jones
2014-09-15 22:32 ` Jacob Pan
2014-09-15 23:34 ` Lee Jones
2014-09-11 23:15 ` [PATCH v3 3/5] regulator/axp20x: use axp2xx consolidated header Jacob Pan
2014-09-13 20:01 ` Jonathan Cameron [this message]
2014-09-11 23:15 ` [PATCH v3 4/5] iio/adc/axp288: add support for axp288 gpadc Jacob Pan
2014-09-12 12:44 ` Peter Meerwald
2014-09-13 19:52 ` Jonathan Cameron
2014-09-14 13:09 ` Hartmut Knaack
2014-09-16 18:21 ` Jacob Pan
2014-09-16 22:24 ` Hartmut Knaack
2014-09-16 10:00 ` Jacob Pan
2014-09-11 23:15 ` [PATCH v3 5/5] iio: add documentation for current attribute Jacob Pan
2014-09-13 19:55 ` Jonathan Cameron
2014-09-14 13:13 ` Hartmut Knaack
2014-09-15 20:29 ` Jacob Pan
2014-09-12 15:18 ` [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Maxime Ripard
2014-09-12 19:36 ` Jacob Pan
2014-09-15 9:02 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414A2AF.6000005@kernel.org \
--to=jic23@kernel.org \
--cc=B38611@freescale.com \
--cc=aaron.lu@intel.com \
--cc=alan@linux.intel.com \
--cc=angelo.compagnucci@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=johannes.thumshirn@men.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=pmeerw@pmeerw.net \
--cc=ramakrishna.pallala@intel.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@debian.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tremyfr@yahoo.fr \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).