From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:55677 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878AbaINRaG (ORCPT ); Sun, 14 Sep 2014 13:30:06 -0400 Message-ID: <5415D09A.4070204@kernel.org> Date: Sun, 14 Sep 2014 18:30:02 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Hartmut Knaack , Irina Tirdea , linux-iio@vger.kernel.org CC: Lars-Peter Clausen , Peter Meerwald , Srinivas Pandruvada , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined References: <1410185127-13039-1-git-send-email-irina.tirdea@intel.com> <540F7BB5.2080801@gmx.de> In-Reply-To: <540F7BB5.2080801@gmx.de> Content-Type: text/plain; charset=iso-8859-15 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/09/14 23:14, Hartmut Knaack wrote: > Irina Tirdea schrieb, Am 08.09.2014 16:05: >> When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power >> off the device, bmg160_set_power_state will call pm_runtime_put_autosuspend, >> which is not implemented (wil return -ENOSYS). >> >> Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined. >> >> Signed-off-by: Irina Tirdea > Acked-by: Hartmut Knaack Applied to the togreg branch of iio.git. Initially pushed out as testing for the autobuilders to play. Thanks, Jonathan >> --- >> >> Changes in v2: >> - moved ifdef CONFIG_PM_RUNTIME inside bmg160_set_power_state as >> Hartmut Knaack suggested >> >> drivers/iio/gyro/bmg160.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c >> index 7524698..1f967e0d 100644 >> --- a/drivers/iio/gyro/bmg160.c >> +++ b/drivers/iio/gyro/bmg160.c >> @@ -237,6 +237,7 @@ static int bmg160_chip_init(struct bmg160_data *data) >> >> static int bmg160_set_power_state(struct bmg160_data *data, bool on) >> { >> +#ifdef CONFIG_PM_RUNTIME >> int ret; >> >> if (on) >> @@ -251,6 +252,7 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on) >> "Failed: bmg160_set_power_state for %d\n", on); >> return ret; >> } >> +#endif >> >> return 0; >> } >> >