From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:56377 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752702AbaINTUZ (ORCPT ); Sun, 14 Sep 2014 15:20:25 -0400 Message-ID: <5415EA75.4040007@kernel.org> Date: Sun, 14 Sep 2014 20:20:21 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Peter Meerwald CC: linux-iio@vger.kernel.org, Oleksandr Kravchenko Subject: Re: [PATCH v2 06/11] iio:bma180: Drop _update_scan_mode() References: <1408488206-2633-1-git-send-email-pmeerw@pmeerw.net> <1408488206-2633-7-git-send-email-pmeerw@pmeerw.net> In-Reply-To: <1408488206-2633-7-git-send-email-pmeerw@pmeerw.net> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 19/08/14 23:43, Peter Meerwald wrote: > statically allocate maximum size > > Signed-off-by: Peter Meerwald > Cc: Oleksandr Kravchenko applied > --- > drivers/iio/accel/bma180.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c > index 91260a0..5838318 100644 > --- a/drivers/iio/accel/bma180.c > +++ b/drivers/iio/accel/bma180.c > @@ -82,7 +82,7 @@ struct bma180_data { > int scale; > int bw; > bool pmode; > - char *buff; > + u8 buff[16]; /* 3x 16-bit + 8-bit + padding + timestamp */ > }; > > enum bma180_chan { > @@ -408,26 +408,10 @@ static int bma180_write_raw(struct iio_dev *indio_dev, > } > } > > -static int bma180_update_scan_mode(struct iio_dev *indio_dev, > - const unsigned long *scan_mask) > -{ > - struct bma180_data *data = iio_priv(indio_dev); > - > - if (data->buff) > - devm_kfree(&indio_dev->dev, data->buff); > - data->buff = devm_kzalloc(&indio_dev->dev, > - indio_dev->scan_bytes, GFP_KERNEL); > - if (!data->buff) > - return -ENOMEM; > - > - return 0; > -} > - > static const struct iio_info bma180_info = { > .attrs = &bma180_attrs_group, > .read_raw = bma180_read_raw, > .write_raw = bma180_write_raw, > - .update_scan_mode = bma180_update_scan_mode, > .driver_module = THIS_MODULE, > }; > >